Commit graph

4245 commits

Author SHA1 Message Date
Zeno Tajoli
ce3518b164 Fix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 08:06:57 -05:00
Garry Collum
6f66396ff9 Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed.  The user clicks on the marc tag's title to expand the marc fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 07:03:41 -05:00
Joe Atzberger
82f362673c Allow option to preserve Extended Attributes on patron import update.
Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.

Several functions added to Members::Attributes with corresponding tests.

[ LL ref. 342 ]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:50:39 -05:00
Galen Charlton
38b3eacde0 bug 2641, 3263: minor fixes to labeled MARC view
* fixed to XHTML validation errors
* corrected copyright statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:35 -05:00
Galen Charlton
822e0ffeae bug 2642, 3263: new MARC display system preferences (DB rev 036)
* Added definitions of the new display sysprefs:

  viewISBD - Allow display of ISBD view of bibiographic records
  viewLabeledMARC - Allow display of labeled MARC view of bibiographic records
  viewMARC - viewMARC  Allow display of MARC view of bibiographic records

* Adjusted IntranetBiblioDefaultView
  * made type choice (fixing bug 1933)
  * added better description for English
  * added labeled_marc option

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:32 -05:00
Galen Charlton
6a86ce7581 bug 3263: fixed ersatz references to AmazonContent
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:28 -05:00
Rick Welykochy
7504a1bb5a bug 2641, 3263: Staff Search Results Interface Changes
New detail view: labeled MARC

New bib record view in the staff interface that
displays the MARC record in a single page.

Featured sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:27 -05:00
Galen Charlton
17ab0a7532 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:20 -05:00
Galen Charlton
ee4de2f652 various improvements to subscription editing
* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:57 -05:00
Henri-Damien LAURENT
af32ae0962 Adding and managing location in subscription
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:55 -05:00
Ryan Higgins
ca5e412c1b bug 3244: Support for multiple PAC interfaces.
Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:52:23 -05:00
d9c63270d0 Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 08:04:18 -05:00
Joe Atzberger
8c0ac886bf Cleanup waitingreserves.pl and .tmpl
Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:25:14 -05:00
400f2bad9e Bug 3169 - Google jacket display, remove preview image on result page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:29 -05:00
Garry Collum
34f08ca117 Bug 1687: Can't assign holidays to all branches at once.
This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:26 -05:00
Garry Collum
22b55a4a1d Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Added code to detect if the syspref for item-level_itypes is being used.  The report now correctly returns data based on the syspref.  There are some pre-existing XML errors with the FORM view of catalogue_stats.pl.  I'll send a subsequent patch to deal with these.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:24 -05:00
Garry Collum
7457bc6d10 Bug 3261: Fix for invalid XHTML on Personal Details page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:02:36 -05:00
Joe Atzberger
85b09f8d0e Cleanup view_holdsqueue.pl and .tmpl (minor)
Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:55:49 -05:00
Joe Atzberger
b83ee6b483 Cleanup branchtransfers
Remove unused sub and variables.
Convert to using GetBranchesLoop instead of local code.
Use elsif where appropriate.
Added fallback values and enabled warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:46:52 -05:00
Joe Atzberger
3c9ed58cba Cleanup transferstoreceive.pl and .tmpl
Removed unused variables.  Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field.  Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.

Mostly whitespace edits in template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:43:17 -05:00
Garry Collum
6d75e726d5 Bug 3241: Place hold button appears on results page if opacuserlogin is off
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 10:20:12 -05:00
Nicole Engard
0d6e559c56 Fixed capitalization and standardized statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:51 -05:00
Garry Collum
7eff11f229 Bug 3253: Fixes XHTML for the Patron Statistics form page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:31 -05:00
Garry Collum
6d8cb8fa2c Bug 3254: Fixes the Catalog by Item Type report XHTML.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:30 -05:00
dc7472aef9 Fix for Bug 3233, tabs on detail page change when clicking on MARC view
This change adds a check for the XSLTDetailsDisplay preference since different MARC view tabs display on the detail page if that pref is on or off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:55:48 -05:00
Joe Atzberger
26a18d3d0d Cleanup circ/overdue.pl
This also fixes a deficiency with overdue.tmpl not retaining the
user's selection of sort order when displaying results.
Removed 9 unused variables.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:55:45 -05:00
Nahuel ANGELINETTI
3b1d91d04f (bug #3020) add a grace period to subscriptions
This patch modify the database to have a grace period which can be set. And is used to create automatically new waited issues with a
cronjob(which is in this patch), and set old issues to "late" status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:46:36 -05:00
Galen Charlton
20b2bbba5e bug 3222: fix display of message queue
If no messages have been sent to the patron, display
a notice that that effect in the staff patron messaging
tab rather than just a blank page.

[LL bug 452]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:21:02 -05:00
Galen Charlton
d036fd463d bug 3222: fix Safari display of patron category preferences
[LL bug 454]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:59 -05:00
Galen Charlton
b6e62489d8 bug 3222: moved messaging preference editing
The display and editing of messaging preferences
for a patron have been moved as follows:

* the prefs for a patron are now displayed on the
  patron details tab, not the messaging tab.
* the prefs are now modified by editing the patron
  record, not on the messaging tab.

The messaging tab now contains only the list of
messages that have been or will be sent to the patron.

When creating a new patron record, changing the patron
category via the category dropdown now also changes
the default messaging preferences for that patron.  If
you start editing a new patron, change one of the messaging
preferences, then change the patron category, the form will
ask you if you want to keep the preferences or get
the defaults belonging to the new patron category.

Note that when you edit an existing patron record, changing
the patron category will *not* cause the messaging preferences
to be automatically changed.

Programmer's note: this commit introduces a new web service,
members/default_messagingprefs.pl, that uses Jesse Weaver's
C4::Service module.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:56 -05:00
Galen Charlton
a1200e6498 bug 3222: messaging preferences for patron categories
Add the ability to set the default circulation messages preferences
for a patron category.  When the EnhancedMessagingPreferences
syspref is ON, the administrator will be able to define
default patron messaging preferences for a patron category.  When
a new patron record is created (either manually or via a patron
import), the new patron's preferences will be copied from the default
for that patron's category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:52 -05:00
Galen Charlton
ca7db466d6 bug 3222: changes to messaging preferences form
Moved the messaging preferences form to a new
include, messaging-preference-form.inc, so that
it can be used to set messaging prefs both for a
patron and for a patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:49 -05:00
Galen Charlton
1a23381418 bug 3243: fix adding patron after resorting in patron label search
Also needed to keep track of the batch type.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 09:32:40 -05:00
MJ Ray
c234ec4c2d bug 3243: pcard-members-search fails to add patrons to batch after using some links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 08:57:04 -05:00
MJ Ray
55e079d023 Add patron card member searching by category code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 08:56:26 -05:00
Galen Charlton
d832ae4bc3 followup to previous patch - don't use TMPL_IF EXPR
Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:

non-initialized variable new_subfield

For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 07:43:46 -05:00
Andrei V. Toutoukine
aa8422889a =?utf-8?q?Usability=20of=20marc=5Fsubfield=D1=8B=5Fstructure
modified:   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 07:36:31 -05:00
Galen Charlton
391a6d3261 bug 2001, 2432: improve unAPI implementation
Improves Koha's unAPI support as follows:

* The implementation no longer depends on there being
  an accessible Zebra or SRW server.  Instead, responses
  are created by running the bib MARCXML through local
  stylesheets.
* unAPI now works for all bibs, not just ones that have
  an ISBN.  The ID format is changed from koha:isbn:ISBN
  to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
  http://validator.unapi.info/ .
* MODS3 support now works correctly.  As a consequence, this
  patch fixes bug 2432 (Zotero support when using the XSLT
  OPAC stylesheets).

TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 07:31:43 -05:00
Michael Hafen
5d30ed4ce8 followup to patch by Galen - add javascript to prevent premature submission of forms in Fines pages
Adds javascript to the manual invoice and manual credit pages to prevent
the premature submission of these forms when using a barcode scanner.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-21 15:20:50 -05:00
Nahuel ANGELINETTI
02d23609b1 Show "no title", when a notice doesn't have a title
This patch just check if there is a title, else show "No Title".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-21 11:13:05 -05:00
Joe Atzberger
3c76a8334f Cleanup and enhance bookcount.pl and .tmpl
Eliminated bug with date handling outputting an English string.
Row striping added.  Highlight for "my branch" row added.
GetBranchesLoop used instead of recreating data structure, so we get the
benefit of branches being sorted (by display name).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-21 08:18:01 -05:00
Nicole Engard
6bb030a0f7 BUG 2736 - added link for MARC country codes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-20 08:38:09 -05:00
Galen Charlton
3f49ad62c8 bug 3236: remove disused scripts and a function
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files.  According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.

Also removed C4::Search::findseealso(), which was used
only by the two scripts.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-20 08:37:58 -05:00
Nicole Engard
eb2513887d BUG #2736 Fix. Updated link to go to list of language codes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-18 16:47:05 -05:00
Garry Collum
5a0f7dfc89 Bug 1768: Calendar now retains the month on which the user was entering data.
If a user adds or edits a holiday, the calendar will now return to the month in which the user was working.  Also after an add or an edit, if the user selects another location, the calendar remains in the same month for which the add or edit took place.  The user sees a 'calendardate' parameter in the URL in the format that is chosen as the system preference.  If an invalid date is entered in the url, the current date is used.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-18 16:37:58 -05:00
Nicole Engard
794b39a84e Bug 2736 fix. Updated link to go to LOC instead of itsmarc.com
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-18 16:22:38 -05:00
Nicole Engard
3abb4ec5b7 Bug 3102 Fix Part 2: Fixed terminology on Transfers to Receive.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-18 16:22:29 -05:00
Galen Charlton
0982338feb fix permissions on new icons
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 20:21:07 -05:00
35d17f9fe2 Adding 4 additional icons to the bridge set: Software, Audio, Journal, and Realia.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 20:18:37 -05:00
Galen Charlton
ace9aa7248 bug 1448: improve subject classification browser
* turn on warnings
* fix problem where the top level of the classification
  hiearchy wasn't displayed, instead pointing to
  the link to the Wiki page with instructions on
  how to set up the feature.
* fix XHTML validation errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 15:52:28 -05:00