Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:
non-initialized variable new_subfield
For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Improves Koha's unAPI support as follows:
* The implementation no longer depends on there being
an accessible Zebra or SRW server. Instead, responses
are created by running the bib MARCXML through local
stylesheets.
* unAPI now works for all bibs, not just ones that have
an ISBN. The ID format is changed from koha:isbn:ISBN
to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
http://validator.unapi.info/ .
* MODS3 support now works correctly. As a consequence, this
patch fixes bug 2432 (Zotero support when using the XSLT
OPAC stylesheets).
TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Adds javascript to the manual invoice and manual credit pages to prevent
the premature submission of these forms when using a barcode scanner.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Eliminated bug with date handling outputting an English string.
Row striping added. Highlight for "my branch" row added.
GetBranchesLoop used instead of recreating data structure, so we get the
benefit of branches being sorted (by display name).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files. According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.
Also removed C4::Search::findseealso(), which was used
only by the two scripts.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If a user adds or edits a holiday, the calendar will now return to the month in which the user was working. Also after an add or an edit, if the user selects another location, the calendar remains in the same month for which the add or edit took place. The user sees a 'calendardate' parameter in the URL in the format that is chosen as the system preference. If an invalid date is entered in the url, the current date is used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
* turn on warnings
* fix problem where the top level of the classification
hiearchy wasn't displayed, instead pointing to
the link to the Wiki page with instructions on
how to set up the feature.
* fix XHTML validation errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fixes the date formats in the holiday display tables. They are now based on the syspref for date formats.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed XHTML error that was introduced in the first patch. Added zebra striping to the tables. Removed an erroneous line with a date experiment that had no affect on the dates.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch adds displays for holidays. A table for each type of holiday. It could be improved by adding a link for a holiday listed in one of the tables to the edit panel. The date formats could also be changed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
this patch do a lot of things :
* Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
This will be usefull for OpenURL support.
* Replace the span in opac-detail, and put the var get from GetCOinSBiblio
* Fix an <img> tag that wasn't autoclosed
* Add the COinS in search result
* Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
When a borrower can't issue any book (issuingrules=0), the message should be
"this user can't issue book" and not "too many books already issued"wrong message
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
There are a couple more forms in circulation.tmpl that need the
stickyduedate and duedatespec hidden inputs. The 'Don't Check Out' form
of the needsconfirmation block, and the findborrower form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fix 3 things:
* fix order by
* take care of item_level-itype
* use join in sql query
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it. Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'. Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.
This patch also fixes the descriptions of the Leader/09
and Leader/17.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Also made the following updates to the MARC21 leader plugin
[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
With those stylesheets result and detail pages
render better UNIMARC biblio record than normal
views. But works still have to be done in order
to reach UNIMARC-ISBD compliant display.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If the syspref RequestOnOpac is turned off, the link to place a hold does not
show in the detail page. However, the link is still present in the results
list as well as in the basket and in lists. Modified templates to check
for the syspref and to obey it.
NOTE: This does not turn off the display of the Holds tab in the OPAC
user account. I think there are situations where library staff may be
allowed to place holds but users are not allowed to do so through the
OPAC. Leaving the Holds tab visible shows users what they have on hold,
but does not allow them to place holds. It does allow users to cancel
holds. If there is a need to hide this tab, that would probably be
best accomplished by a separate syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
this patch just set a marclist argument value on search authority, else the pagination won't work.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If the items.location field was NULL, then the current
SQL query would produce no results. I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.
In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open. This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element. The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank. Added code to check for an empty string in the first
element.
You can test this by making salutation (title) mandatory.
Also fixed some typos in some of the comments. Why? Because I'm a Librarian.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.
Added Publication Date Range search to advanced search screen
Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).
Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Added support for the Syndetics AV summary and AV profile
data elements. The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If a Syndetics title profile (AKA fiction notes page) exists
and is avaailable to the user, add a link to to in the OPAC
detail page.
TODO: add a system preference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional. jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.
There were several other errors addressed by this patch:
~ 13 unused variables deleted.
~ regexps run on user-supplied $var before checking $var defined
~ decimal ratio prohibited and silently replaced with "3"
I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click. Hidden .sql div now contains the actual query run,
like the other wizard reports.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Resent with additional comments.
Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music. Modified record display to use Sound.
Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource. Changed the record display page
to also use Continuing Resource.
Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display. Modified the utils file
to force a space.
The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png). Also, corrected spelling of icon name
from pencile.png to pencil.png.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
LTFL content needs to appear in div rather than span elements. This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
AllowNotForLoanOverride is ON, if the operator attempts
to check out an item that is normally not for loan due to
its item type or because the item is explicitly marked as
not-for-loan, the operator is given the chance to check
out the item anyway.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.
Changed so that <div> for the language chooser is output
only if there is more than one enabled language.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fixes Amazon content use in pro interface :
* Control Amazon Editorial Review by a new syspref:
AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
It displays only Editorial review in Description tab.
This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Reworked ViewLog.pl and the template. Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.
This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch allows staff users to request reserves on multiple
items at one time.
Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page. Place-hold button will only appear if
the user has permission to place holds for others. Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.
Patron input page now shows multiple items, if applicable.
Hold confirmation page shows results for multiple items, if
applicable. Those which cannot be reserved are highlighted and
are excluded from the reservation. The reservation is placed at
the biblio number (i.e. next available) level.
Fixed display of item type.
Removed side menu for multiple items; removed item-oriented button for multiple items.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC. Most libraries will want
to leave this turned off!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Formatting bugs not fixed. Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected. Go figure.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Clip trailing comma in js list argument.
Column selection improved with jquery and submit time check.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.
In addition I have made it so that the Date Received
only shows if the item is 'Available'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Standardized all references to Address and Zip/Postal Code.
Also fixed bug #3138 by making the Alt address ready City, State.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
