Commit graph

21 commits

Author SHA1 Message Date
Sophie Meynieux
141a52ac30 Bug #6064 Improvement of default value usage in overdue
Change default value in overduerules table for delayn (NULL instead of 0) and fix GetBranchcodesWithOverdueRules function

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-07 21:33:40 +12:00
Nahuel ANGELINETTI
5d268a83a0 (bug #4295) fix overduerules edition
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:57:18 -04:00
Lars Wirzenius
49e0a8fc78 Fix FSF address in directory tools/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:51 -04:00
Nahuel ANGELINETTI
e1c2f85c2c (bug #3791) overduerules and numeric categorycodes
this fix overduesrules.pl when library have numeric category codes.
2009-11-18 17:42:22 +01:00
fce5a2f10e bug 2505: remove additional warning messages
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 19:52:18 -04:00
Colin Campbell
038c485ba5 enable warnings in overduerules.pl Call GetBranchesLoop instead of duplicating code make countletters a count as it says check for definedness before doing string comparisons do as not to generate warnings 2009-09-05 19:15:51 -04:00
Nahuel ANGELINETTI
9dc44fefaf (bug #3304) fix notices trigger with diacritics in categorycodes
This just utf8::encode the $key if needed to permit categorycodes with diacritics.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 17:51:31 -05:00
Garry Collum
48f958fb19 Bug 2889: Removed toggle variable from overduerules.tmpl - added __odd__
Removed toggle variable from overduerules.pl and overduerules.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:58 -05:00
John Beppu
55eb4efa71 bug 2707 - overdue rules not being deleted
* I added some code to detect the rows which were blank,
  and I deleted them upon saving the form.
* Updated to get the categories from the database
  instead of hardcoding them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:29:11 -06:00
Ryan Higgins
04c4be5b48 Bug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overly restrictive
removing requirements for parameters &  management respectively for these two tools.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 14:47:31 -05:00
Galen Charlton
b8e404700a bug 2293: better validation in overdue rules editor
If a rule should not be saved because a delay is
given but no letter or debar action is specified
for that delay, an error message is now reported.

Also:

* use "dialog alert" CSS class for confirmation
  that form was saved
* if form input is saved, retrieve the settings from the
  database again when displaying the form - this will
  help turn up any bugs where the script is not
  saving the overdue rules correctly.
* fix display of patron category in error messages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-02 12:25:50 -05:00
Galen Charlton
a3bdf666f9 bug 2291: sort branches and letter types
The drop-down lists of branches and letter templates
in the overdue notice/status triggers tool are now
sorted in ascending alphabetical order.

No documentation change.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-02 12:25:37 -05:00
Galen Charlton
fc6ccb1a61 granular permissions - updated Tools
Updated all scripts appearing on the tools page
to respect a granular permission defined for
each of them.

The tools menu and home page have been changed so
that only the specific tools that a user has
access are displayed.  This is simple, but depending on
the module and circumstance, it may be better to
display functions that the user has does not have
access to, but disable the links and do some sort
of visual styling to indicate that a function exists
but requires additional privileges to access.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:30 -05:00
Paul POULAIN
1e3e69fe99 Overdues fixes (unfinished)
- reindenting
- upcasing SQL
- the script at least compiles...

... but it does seem not work yet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:15:41 -05:00
Paul POULAIN
bf988e4dc8 just reindenting
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 16:03:23 -05:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
fc1342f73d rel_3_0 moved to HEAD 2007-03-09 15:12:54 +00:00
tgarip1957
5b41a8e262 New XML API 2006-09-11 17:41:54 +00:00
toins
92284686aa Code cleaning : Some subs renamed. 2006-07-19 08:58:38 +00:00
hdl
d2c04ade4f Adding some checking and feedback. 2006-02-28 14:58:32 +00:00
hdl
e139654acb Adding getletters to Koha.pm :
allow to get a list of letters for a module.

overduerules is a tool relying on letter.pl
It will allow ppl to manage three levels of overdue thanks to a brand new overduenotice script to come out soon.
2006-02-27 18:15:41 +00:00