Commit graph

12299 commits

Author SHA1 Message Date
d40488fe65 fixes to xt/sysprefs.t test case
* use root of source tree as base directory
* ignore case when comparing system preference codes;
  at present this is also case-insenstive in the database
* added German sysprefs file
* corrected paths to Russian and Ukrainian system preference files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 15:56:07 -04:00
aebaf6bc08 fixed permissions for item batch deletion and modification for French
Solves bug where granular permissions for batch deletion and modification
would not work correction for a fresh installation using the French
translation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 15:51:25 -04:00
05ca029055 fixed problems in xt/permissions.t test case
* now looks for permissions SQL files in the current
  source tree, not in intranetdir; tests in xt/ and
  t/ are meant to be run without requiring a full Koha
  installation
* added path to German
* fixed paths to permissions SQL for Russian and Ukrainian
* handles case where SQL script contains more than just
  inserts into to permissions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 15:48:28 -04:00
Katrin Fischer
3dfecafc56 Bug 4895: Add missing granular permissions
Add missing granular permissions for serials to userpermissons.sql
de-DE, pl-PL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 09:28:12 -04:00
0abb62be46 set DBversion to 139
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 09:03:45 -04:00
Katrin Fischer
c7e421d995 Bug 3682: change message_attributes.message_name from varchar(20) to varchar(40)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 09:03:19 -04:00
4e6a664fb0 Fix for Bug 4868 - Improve controls for cloning and deleting MARC subfields
Changes "+" and "-" controls to actively linked images giving
better feedback about their clickability and an increased click
target area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:23:26 -04:00
2fe930dae2 Page structure correction, helps Bug 3850 (Page Need Design Work)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:16:26 -04:00
Ian Walls
6ba2b9c87c Fixes bug 3619: _send_message_by_email not respecting AutoEmailPrimaryAddress = 'OFF'
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:14:27 -04:00
Katrin Fischer
a18bdb0bfe BUG 4883: Staff - remove \n from strings for translation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:09:09 -04:00
Katrin Fischer
252d595194 Bug 4833: OPAC - remove \n from strings for translation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:09:08 -04:00
Katrin Fischer
3a63dda868 Bug 4895: Add missing granular permissions to ru-RU, uk-UA
Files are different from en files, combining userpermissions.sql and userflags.sql.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:07:14 -04:00
Katrin Fischer
b4b92c3d98 Bug 4895: Add missing granular permissions to de-DE, pl-PL
Added missing permissions, files are translations of en.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:07:13 -04:00
Garry Collum
b717110c14 But 4890: Fixes invalid XHTML in basket.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:58:13 -04:00
Garry Collum
8876393d16 Bug 4889: Fixes minor XHTML error in booksellers.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:58:12 -04:00
Garry Collum
1e9c425950 Bug 4827: Fixes library drop-down list in aqbudgets.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:58:11 -04:00
0700a8b732 bug 4896: granular permissions now always on (DB rev 138)
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha.  This patch removes
the GranularPermissions system preference.

[1] http://lists.koha-community.org/pipermail/koha-devel/2010-February/033670.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:56:03 -04:00
Chris Cormack
ac5047b887 Follow up patch, removing missed conflict marker
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:23:50 -04:00
Chris Cormack
b3feb54ee0 Cherry-picked onto master, fixing conflicts: MT 1816: Granular permissions for the serials module
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>

Conflicts:

	installer/data/mysql/en/mandatory/userpermissions.sql
	installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql
	installer/data/mysql/updatedatabase30.pl
	koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
	koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tmpl
	serials/member-search.pl
	serials/serials-edit.pl
	serials/subscription-add.pl
	serials/subscription-bib-search.pl
	serials/subscription-detail.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:23:46 -04:00
9f806f2611 Missing indexes and a missing column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:18:38 -04:00
36e68effae Missing tables in the kohastructure.sql table.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:16:45 -04:00
Liz Rea
aa3ac3e319 Changing <p> to <span> per gmcharlt's suggestion re: Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-17 19:40:57 -04:00
Liz Rea
24b8e9c384 Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.
A later patch might come that changes the text entirely, as it does not match the OPAC, and is often confusing for staff.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-17 19:40:56 -04:00
Chris Cormack
e0c72d37fa Bug 4472 - Missing / in img tags breaking xslt (and other img tags)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-17 19:37:57 -04:00
Chris Cormack
b453f7ed5c Updated history file, 2 more committers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-17 19:33:51 -04:00
Colin Campbell
d7a6f17f11 Fix depreciation warnings in acqui/z3950_search.pl
Perl generates depreciation warnings on compilation
caused by use of ambiguous syntax. Seemed that an
underlying confusion as to row's type

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-17 19:32:33 -04:00
77f04bd426 Bug 2789 Fix UNIMAC leader plugin
The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 10:14:11 -04:00
Nahuel ANGELINETTI
5f0f488596 (bug #4853) change rights needed to renew loans
Use "circulate" right, instead of "borrower".

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 09:55:29 -04:00
Garry Collum
34936223f3 Bug 2505: Enabled warnings in patron-attr-types.pl
Fixed all resulting  errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 09:49:34 -04:00
Andrew Elwell
4370a19d75 Final batch of POD cleanups.
Should fix any remaining warnings with 'podchecker'

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:39:01 -04:00
Andrew Elwell
aa9b4d92cd POD Cleanups
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:38:59 -04:00
Andrew Elwell
546a0244bb More POD cleanups
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:38:58 -04:00
Andrew Elwell
2856bb8295 POD Cleanups - Few minor ones this time
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:38:57 -04:00
Andrew Elwell
8480f56370 Another batch of POD cleanups
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:38:56 -04:00
Andrew Elwell
c6bf50d052 The start of some POD cleanups in C4/*.pm
If these are acceptable I'll continue - target is to get rid of all warnings
and errors with podcheck and make sure that any man and html formatted pod
docs look 'OK'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:38:55 -04:00
02b9e03567 applied paranoia
RM note: we've had our fun; next patch will be to trim
the comment to something that makes sense in context.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:33:19 -04:00
Lars Wirzenius
604d871d27 Build with pdebuild, not debuild.
This checks build dependency declarations more thoroughly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:31:40 -04:00
Lars Wirzenius
73152b7ac4 Remove dependencies on perl-base.
perl-base is a required package, so it is always installed on a Debian
system, and Debian packages should not depend on it, unless they need
it a specific version, and I don't think we do.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:31:38 -04:00
Colin Campbell
b3489aa045 Bug #4864 Add SIPServer Perl Module Dependencies
SIPServer requires Net::Server and UNIVERSAL::require

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 08:29:51 -04:00
72fb44ce26 set DBrev to 136 for previous patch to add edit_items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 21:04:17 -04:00
Henri-Damien LAURENT
39d70cf05b MT2938 : Adds a permission for editing items
This patch adds a permission on edit_items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 21:04:01 -04:00
ad1047dce7 Fix for Bug 3081, Url's contain spaces
My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:59:31 -04:00
dfb2c77435 Fix for Bug 3770, 'Add to list' page only allows adding to private lists
This patch is a reformat of chad@pennmanor.net's submission to
the bug report on 2010-02-16.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:53:04 -04:00
6af71b5f8d Fix for Bug 3722 - Branch deletion results in incorrect message
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:46:31 -04:00
d346179a9b Fix for Bug 3926, inadvertantly resurrected by me.
The template-side fix for Bug 3926 was overwritten by
another template change I submitted later. My bad.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:36:33 -04:00
c6b94ab730 Fix for Bug 3992 - New Sys Prefs Branch - Local Use Tab not Highlighted
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:25:43 -04:00
Nicole Engard
c4f7259cc1 bug 4205 remove extra 'plan by' option
There wasn't a conditional in place to stop the planning
pull down from showing a blank 'plan by' option.

This patch also makes the other 'plan by' options look
cleaner by removing the all caps.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:04:23 -04:00
Colin Campbell
e08d35bdc3 Bug 4844 Remove a circular dependency in koha_perl_deps.pl
Remove 'use Installer' which had external dependencies we're trying to
report on. Instead call Installer::PerlModules directly

added use warnings and strict
updated FSF address in License statement

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 19:59:10 -04:00
58969c958c Fix for Bug 4504, Confirmation messages in opac account not translated
Strings within JavaScript onclick attributes are not getting picked
up by the translator:

onclick="return confirmDelete(_('Are you sure you want to cancel this
hold?'));"

This patch converts those to use variables defined in the main
script block:

onclick="return confirmDelete(MSG_CONFIRM_DELETE_HOLD);"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 19:52:22 -04:00
Nicole Engard
5bdbd73f63 bug 4845 change language from reserves to holds
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 19:50:07 -04:00