Commit graph

4005 commits

Author SHA1 Message Date
d79ac60b90 Fix for Bug 2984, Error when generating CSV output from "Generate labels for Batch" button
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-25 16:32:24 -06:00
Galen Charlton
4d7500b73c bug 2952 followup
The feature in question is described in bug 2952; to
summarize the enhancement, which the earlier patch
description did not do, the list of bibs in an
import record batch now includes a column linking
each import record to the bib that was actually created
or updated when the import batch was committed.

The improvements in this patch are:

* If bib in import batch has not been committed, it
  has not been linked to a matching new or updated bib.
  In that case, do not create a link to a guaranteed
  404 (/cgi-bin/koha/catalogue/detail.pl?biblionumber=)

* When reverting an import batch, set matched_biblionumber
  to NULL for affected records - otherwise, the Bib
  column will include links to bibs that may no longer
  exist.

* Fixed a minor HTML validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 17:04:48 -06:00
Mason James
1afc398a1c bug 2952: 1 char typo
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 16:39:46 -06:00
Mason James
31adf4ef83 patch for feature 2952 - v3
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 16:39:33 -06:00
b0deccd971 Changes to improve keyboard access to global search box tabs.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 16:32:01 -06:00
Nahuel ANGELINETTI
6b4fed3b47 (bug #2956) fix another results calculation
this patch fix more about 4XX plugin, for results display and calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:47:41 -06:00
b246e1bf60 Correcting title of link to admin/itemtypes.pl from "Item types and circulationcodes" to just "Item types." Ccodes are authorized values.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:46:13 -06:00
Michael Hafen
330ddf4857 add some search indexes to opac advanced search that are on quick search
This adds ISBN and Call Number, which are in the quick search index
list, but are not in the advanced search index lists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:46:10 -06:00
Daniel Sweeney
871f0f27e3 Added empty item call number test to copies for reserve; added ending punctuation to availability statuses.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:58 -06:00
Joshua Ferraro
d2cb0a20de Fixes to two issues with status display on OPAC:
1. rather than testing for notforloan == -1, test for any negative values to set the On order status
2. in cases where itemcallnumber is blank or null, don't display the itemcallnumber brackets []

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:56 -06:00
Joshua Ferraro
344912cd41 Displays the itemcallnumber in brackets next to location in XSL Results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:53 -06:00
Joshua Ferraro
04270d01b2 Distinguish between items marked 'not for loan' and 'Available'
This patch works with XSL* sysprefs == ON, a future patch will address XSL sysprefs==OFF

Items with notforloan set to a negative number still designate an 'ordered' status

Some items are marked 'not for loan' by setting that value at the item level, others by assigning
that value to that item's itemtype. This patch works for both scenarios.

Specific changes this patch introduces to the OPAC:

* Adds a new OPAC results page key 'Copies available for reference:'
* Changes 'Copies available at:' to 'Copies available for loan:'
* Changes the availability limit label in opac-advsearch from:
    'Only items currently available' to 'Only items currently
	available for loan or reference
* Displays the authorised value for the specific notforloan value in the OPAC detail page in
	parentheses next to 'Not for Loan'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:51 -06:00
John Beppu
5279faf72e bug 356: removed redundant interface
The messaging tab already provided a way to configure these
notifications, so this isn't needed.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 13:48:47 -06:00
8bdd270189 Fix for Bug 2911: popup calendar not available in IE
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 13:44:30 -06:00
John Beppu
9035706950 bug 323: Item Circulation Alerts UI Fixes
- fixed cross browser issues.  (IE and Safari don't let you say
  someobject.class, presumably because "class" is a keyword that's reserved
  for future versions of JS.  Firefox and Opera allow it.)

- added text to the grid for added clarity.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:59:03 -06:00
John Beppu
2270ecaa90 Brand New UI for Alert Configuration
- grid layout (javascript required now)
- makes distinction between checkin and checkout messages
- no longer have to click on a button to submit the branch selection form

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:57:48 -06:00
John Beppu
12045fd099 Removed RSS Option from UI
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:57:41 -06:00
John Beppu
233010f451 Branch Level Notification Config
- This will allow admins to disable notifications for any combination of
  branch, patron category, and item_type.
- Still working on this...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:38 -06:00
John Beppu
a8accfb4c5 Messaging Preferences for Intranet
- Added ability to modify per-user messaging preferences.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:09 -06:00
John Beppu
65b0ca3923 Messaging Preferences for OPAC
- Added ability to request a messaging config change.
  (Apparently, users aren't allowed to directly change these settings.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:54:45 -06:00
526a39b62d Showing totals for charges and replacement costs on patron detail screen and print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:41:18 -06:00
Nahuel ANGELINETTI
ba34bea474 (bug #2938)[follow previous] Add new report in menus
Just adding the new report in miscellaneous menus

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:42:00 -06:00
Nahuel ANGELINETTI
720cddeca6 (bug #2938) add a serials subscriptions report
this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:41:48 -06:00
Joe Atzberger
01230ccd5e Minor rework of template js.
Lines explicitly ended with semicolons.  Allow some better behavior if TMPL_VAR's
are undefined or zero.

Note FIXME added.  I believe this is part of the fragmentary integration of
Katipo code for GST.  Would be obliged if someone with access there can confirm.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:20:50 -06:00
Galen Charlton
cb04440f44 language fix: "branch" => "library"
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:22:18 -06:00
Jesse Weaver
1301705150 Add holds policies
This adds holds policy creation support to smart rules and read support to
C4/Circulation.pm, and the two reservation pages. It also adds a system
preference, AllowHoldPolicyOverride, to control whether the staff can override
these policies.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:21:07 -06:00
Nahuel ANGELINETTI
0209a96db7 Unescape some double quotes, that make a validation error.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:29:34 -06:00
011fa47b9d Related to earlier patch: adding body id to add flexibility to CSS customizations.
This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:21:20 -06:00
Galen Charlton
b99e65ca76 bug 2908 followup - use "list", not "shelf"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:18:03 -06:00
Nahuel ANGELINETTI
bfebda4ad9 (bug #2908) adding send shelf by e-mail feature
This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:51:59 -06:00
Danny Bouman
277049ada5 bug 2687 followup: Increase maxlength attribute to support 64 characters
Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:05:25 -06:00
Allen Reinmeyer
7ca82ab5d2 Bug 2902 Public shelves do not display when user not logged in.
An ending </div> was not placed correctly and encompassed both
privateshelves and publicshelves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 12:28:45 -06:00
Joe Atzberger
cdb4b60d93 Bug 2747 for staff interface itemtype display.
Prefer accuracy over graphical icon.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-07 15:13:43 -06:00
ac196cddcc Hiding SMS messaging preferences if there is no SMSSendDriver defined in system preferences.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:53 -06:00
3686361d3e Hiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove SMS column from patron messaging preferences if SMSSendDriver is not defined
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:43 -06:00
Joe Atzberger
a581f7203c Bug 2842: ->regexp('syspref') failed for users of iso dateformat.
Sticky due date and patron import were the two areas affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:24:46 -06:00
20a609b587 A few more tweaks to the OPAC detail view menu
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:12:30 -06:00
ef612e5667 Providing options for adding to order when existing record search has failed.
I've duplicated the "Add to Order" block on the search results page to display after a user has searched for an existing record to add to an order. This block is displayed whether or not results were found on the assumption that a non-empty result set may not contain the desired result. Changes to neworderbiblio.pl allow supplier name to appear in breadcrumb nav.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:09:29 -06:00
f4fcd9e35a Fix for Bug 2700, Keeping Data When Adding Multiple Items
When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-05 16:37:07 -06:00
Galen Charlton
ca7ae0ab41 remove TMPL_IF EXPR in member.tmpl
Quells following error message in Apache log:

EXPR:at pos 8: non-initialized variable overdues,
referer: http://example.edu/cgi-bin/koha/members/members-home.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 15:53:07 -06:00
Galen Charlton
330edb157f followup to Mason's labels patch
* fix XHTML errors
* fix problems with paging through results list

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 15:35:08 -06:00
Mason James
990e315471 The current searching in labels is a bit minimal, and current only does keyword searching.
there is some old 2.2 code for more complete labels-searching, thats been commented out

ive logged a 'bug' for this - 2777

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2777

this fix...
  - enables the index-searching functionality
  - adds date-ranges
  - uses the numSearchResults syspref, not a hardcoded '20'
  - rewrote old 2.2 page-num code, (didnt work for 3.x)
  - some indent and whitepages tidys.
  - unused 2.2 search-code removed.

Mason

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 11:15:44 -06:00
96d0ea56df Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:44:02 -06:00
Nahuel ANGELINETTI
92afb0dd56 (bug #2887) Change the "Cart" box from js to tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:33:59 -06:00
Joe Atzberger
5af1eb2061 Remove "toggle" from template, use loop_context_vars __odd__ instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:53:26 -06:00
Stan Brinkerhoff
7989a831db Removing ':' from table headers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:52:44 -06:00
Nahuel ANGELINETTI
61ebf9160f (bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set
This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:46:11 -06:00
John Beppu
7b683cf583 bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:00 -06:00
7a9658cddc Improvements to offline circ report (linking to title and patron records), and moving English strings from the script into the template to allow translation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-22 17:24:34 -06:00
Galen Charlton
a3136e22bf bug 2799: followup 2
* fix TMPL_IF embedded in HTML tag
* convert a remaining <TMPL_VAR> to a comment

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:26 -06:00