Commit graph

202 commits

Author SHA1 Message Date
Chris Cormack
39fad89745 Fix for bug 1253 borrowers names sorted case sensitivly in circulation.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 12:07:59 -06:00
Galen Charlton
26fa7bf58d use syspref date format for manual due date
NOTE: will fail if user manages to enter date
in wrong format.  This is not a change from before
this patch, but is pointed out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:14:41 -06:00
Galen Charlton
af0b208bdf use standard template var for DHTML date format
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:13:59 -06:00
Chris Cormack
6cfe88b7b2 Fix for bug 1427
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-19 18:55:20 -06:00
0e675ef820 - Changes to the way patron renewals are handled. Circulation page now offers 'renew' link alongside warning about patron expiration (as in dev_week), using the new setstatus script.
- Member pages now use member toolbar include instead of circ one
- setstatus.pl now uses 3.0's patron renewal function
- Adding missing item-bullet.gif (Bug 1659)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 19:24:49 -06:00
Chris Cormack
ea7cbfff43 Fix for bug 1648, specifying a due date resulted in a blank due date
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 08:19:55 -06:00
Joshua Ferraro
e428929bff adding format_date to 'use C4::Date' 2007-12-04 18:29:18 -06:00
Joe Atzberger
82b8c496fd circ subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:12 -06:00
266b59cf65 Moving "Check Out" from the action toolbar to the view menu
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:56:22 -06:00
f46ebf69a0 Passing "adultborrower" variable to the template so that "Add Child" button can be displayed in the toolbar when appropriate. Fixes Bug 1510.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 15:06:29 -06:00
Galen Charlton
958b5a097c new C4::Auth::get_session for single place to get CGI::Session object
Refactoring to provide single place to get CGI::Session ojbject;
fixes bug for DB storage method other than 'mysql'.

This refactoring is also part of the patch series for
handling large input files for staging and processing
MARC records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:43:26 -06:00
Ryan Higgins
cb1ec158c0 Adding calendar widget to circulation/stickyduedate
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:27:25 -06:00
Ryan Higgins
9c2d58a470 update item-at-wrong-branch error message to show homebranch.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:45 -06:00
Chris Cormack
5342904792 We were calling get biblioitemdata when we should have been calling get bibliodata
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 11:19:26 -06:00
Chris Cormack
5fa4703ee0 Fix for 404 error when clicking on a reserve in circulations
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-12 17:40:23 -06:00
Ryan Higgins
3967fa9c79 further mods to change from ccode to itype at item-level itypes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:40:20 -06:00
Chris Cormack
24af640015 Rest of the fix for 1402
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:05:20 -06:00
Joshua Ferraro
58d3b163d0 merge mason's fix to circulation 2007-11-06 06:19:17 -06:00
Mason James
275e3eb8b1 undeclared @issued_itemtypes_count_loop;
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-06 06:18:15 -06:00
Joshua Ferraro
9e8dc6b021 adding back my @issued_itemtypes_count_loop; 2007-11-05 08:41:11 -06:00
Ryan Higgins
371efb047b adding item-level itypes: based on systempref: item-level_itypes, we use items.ccode as the circ code rather than biblioitems.itemtype. This is initial commit -- still requiring interface changes basic loanlength, maxissues should be by ccode now.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:37:53 -06:00
Ryan Higgins
d6eea9c622 fixed redefined itemtype_count variable .
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:37:38 -06:00
b453d173ae Standardizing information shown in sidebar when patron-related pages are displayed (making sure address, phone, email variables are available to all templates). Adding tabs to account-related pages as means of section navigation.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:31:32 -06:00
4a9745dbb0 More interface changes for circulation: Further tweaking of circ warning dialog, formatting patron selection form, adding 'focus' class to patron selection select list.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:31:02 -06:00
Ryan Higgins
dac69bc799 Couple of minor changes to staff client view on patron.
item-level_itypes still need display changes in both opac and staff.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:27:59 -06:00
Chris Cormack
ff179bb1d4 Fix for bug 1518
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:21:46 -05:00
701d6ef020 Circulation borrower name autocompletion
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 16:17:08 -05:00
Joe Atzberger
6f15e48f65 circulation.pl cleaned up. I think you'll like the difference. Less
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 21:21:31 -05:00
Paul POULAIN
47321d0068 Adding dates for display to circulation.pl Minor bug fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 18:44:46 -05:00
Chris Cormack
ee56e731ab Fix for bug 1436, changing to use issuedate, not timestamp for sorting issues
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 20:45:46 -05:00
34b67109d1 A couple more tweaks to member entry form. Still unfinished: inline CSS will have to be generalized and moved to external stylesheet. Trying some changes to circ page, including moving patron info into sidebar, consolidating messages and warnings. Also unfinished!
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-25 14:47:02 -05:00
a37daca905 More efforts with toolbars, nothing solved. Also corrections, and modifications to resident search to place focus on displayed form field.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-25 14:46:56 -05:00
Paul POULAIN
c4d4b6ecf2 Bug fixing : 1396
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:31:40 -05:00
Paul POULAIN
3568e20644 bug fixing on 1396 :
Conflicts:

	circ/circulation.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:29:42 -05:00
Paul POULAIN
e809eff05f BUGFIX : branch CPL was hardcoded
What is the branch CPL ?

Anyway, this was buggy and reseted the branch to empty
which was a bug ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-18 15:06:47 -05:00
Chris Cormack
f12fc20e1d Fix to get selectbranchandprinter working fine with the Session
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-06 20:48:13 -05:00
Paul POULAIN
497bbd84b0 show the departure date if close or past
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-14 21:32:22 -05:00
toins
ee5c4c303c display enhancement. 2007-07-24 14:17:07 +00:00
toins
cae655f928 removing a compilation warn. 2007-06-05 09:48:31 +00:00
alaurin
5c4a2c3e4b bugfixing for circulation. 2007-05-04 10:18:00 +00:00
hdl
a171035f1d GetBorrowerIssues is deleted from C4::Circulation
Use GetPendingIssues from C4::Members instead.
2007-04-25 14:07:34 +00:00
tipaul
fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
hdl
b642e687d2 Still Code Cleaning.
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
2007-04-24 15:41:27 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
9f42b8ad49 renaming currenttransfers to transferstoreceive 2007-04-23 15:21:17 +00:00
tipaul
3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl
0b66bd800d Code Cleaning Members.
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
b71839d85c circulation cleaning continued: bufixing 2007-04-17 08:44:49 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
tipaul
987ceb8ce7 using C4::Date instead of C4::Circulation::Date 2007-03-30 11:58:48 +00:00
kados
b4d72b977f fix for bug 1276: Cannot search for patron wtih apostrophe in their name 2007-03-18 04:13:21 +00:00
tipaul
2ffd5b7228 rel_3_0 moved to HEAD 2007-03-09 14:28:54 +00:00
tgarip1957
4843e0ee78 Resynching Savannah 2006-11-15 01:41:51 +00:00
tgarip1957
7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
toins
3c6410111b subs renamed according to coding guidelines. 2006-07-21 10:10:29 +00:00
rangi
f30b030af8 Code to allow the associated borrowers to work 2006-06-20 22:35:47 +00:00
bob_lyon
9161eba4bd merging katipo changes...
Adding flag for being in credit vs being in debt and added checks to see if
one can renew before trying to renew
2006-06-07 04:13:22 +00:00
alaurin
0f00577a9e bug fix : for item reservation, now the system don't keep the reserve if the document is returned, works fine !!!! 2006-06-06 12:26:57 +00:00
alaurin
795fffef13 Improvements for reserves infos in circulation.pl
new infos displayed :

 -Waiting position of borrower on document reserve .
 -Follow the document he's in transfert 	.
 -more infos of document are displayed in a specific cell ....

N.B : the old display of reserves infos are only commented, will be removed, if new display is ok for everybody ...
2006-06-01 10:03:08 +00:00
rangi
c1c08d65b1 Allows a person to choose an associated borrower (orgranisation) when Issuing.
This is to allow a person who is associated with many organisations to choose the one he/she is borrowing an item for

No changes to the issuing code, or the issues table, the associated borrower number is stored in the statistics table
2006-06-01 01:44:16 +00:00
plg
dc986ecac5 bug fixed: the issue timestamp had not the same format as the today's date
to which it was compared. The comparison separate issues on display between
today issues and older issues.
2006-03-31 15:31:44 +00:00
tipaul
d5938493d7 synch'ing head and rel_2_2 (from 2.2.5, including npl templates)
Seems not to break too many things, but i'm probably wrong here.
at least, new features/bugfixes from 2.2.5 are here (tested on some features on my head local copy)

- removing useless directories (koha-html and koha-plucene)
2006-01-06 16:39:37 +00:00
tipaul
b38997925f big commit, still breaking things...
* synch with rel_2_2. Probably the last non manual synch, as rel_2_2 should not be modified deeply.
* code cleaning (cleaning warnings from perl -w) continued
2005-10-26 09:11:02 +00:00
tipaul
e82eca42c9 see mail on koha-devel : code cleaning on Search.pm + normalizing API + use of biblionumber everywhere (instead of bn, biblio, ...) 2005-09-22 10:01:45 +00:00
genjimoto
f9d2fa784c modified script to enable circulation system to show picture of borrower for verification purposes. 2005-08-22 12:53:48 +00:00
oleonard
98687d85ad Synch with rel_2_2: Fixing section that was supposed to allow for alternating table row colors 2005-07-19 18:52:37 +00:00
tipaul
4dea4ae494 synch'ing 2.2 and head 2005-05-04 08:50:48 +00:00
tipaul
93ff09d081 merging 2.2 branch with head. Sorry for not making it before, many many commits done here 2005-03-01 13:40:35 +00:00
oleonard
cb2dc1d759 Adding 'flagged' variable to help control display in the template 2005-02-16 22:25:17 +00:00
oleonard
ea39d8bd8f Adding email address to list of returned variables 2005-02-10 17:27:32 +00:00
tipaul
52a123a1a4 fix for :
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=858

* added a button to cancel issue
* adding checkbox to cancel reserve on the book (checked by default)
* the cancelation reserve is done on reserves done for a given item or for any item

Nelsonville, pls test & confirm it's OK
2004-12-15 10:47:09 +00:00
oleonard
000a96fb4b Fix from Joshua for Bug 851: stripping out comma and apostrophe from search terms 2004-12-13 17:54:15 +00:00
rangi
1ce34b32b3 Fix for bug 865
Allows a librarian to tell Koha you want to start issuing to a new borrower
by entering no data. Essentiall by just hitting the enter  key
2004-11-28 08:32:36 +00:00
tipaul
1424addcc2 fix for bug 858 (no warning when issuing a reserved book) 2004-11-18 10:32:39 +00:00
oleonard
935db49ba8 Re-adding patrontable subroutine so that borrower flags and waiting item information can be displayed 2004-11-03 22:40:14 +00:00
tipaul
9aec896627 * Showing the borrowernotes in issues (was shown only in issues before) 2004-10-04 20:29:07 +00:00
tipaul
f927e8eb36 bugfix for manually fixed duedate on issue. 2004-09-15 16:27:18 +00:00
tipaul
ab39e57393 fixes in circulation module 2004-08-18 15:52:14 +00:00
oleonard
00fc740011 Adding overduecount, issuecount, and finetotal variables to template 2004-07-12 20:44:48 +00:00
tipaul
cc5e837309 bugfixes in circulation 2004-06-17 08:17:39 +00:00
tipaul
b56f035183 bugfixes 2004-05-03 16:36:53 +00:00
tipaul
040bcdf92b CIRCULATION : the big rewrite...
This 1st commit reorders deeply the circulation module.
The goal is to :
* have something 100% templated/translatable.
* have something easy to read & modify, to say to customers/users : you can define your circulation rules as you want if you accept to look in C4/Circ/Circ2.pm

The circulation now works :
1=> ask for the borrower barcode (as previously)
2=> ask for the item barcode.
3=> check "canbookbeissued". This new sub returns 2 arrays :
- IMPOSSIBLE : if something is here, then the issue is not possible and is not done.
- TOBECONFIRMED : if something is here, then the issue can be donc if the user confirms it.
4=> if TOBECONFIRMED is set : ask for confirmation, loop. if neither  are set or confirmation flag is set (2nd pass of the loop), then issue.

The IMPOSSIBLE & TOBECONFIRMED hashs contains :
* the reason of the line. always in capitals, with words separated by _ : BARCODE_UNKNOWN, DEBTS ... as key of the hash
* more information, as value of the hash ( TOBECONFIRMED{ALREADY_ISSUED} = "previous_borrower_name", for example)

This commit :
* compiles
* works on certain situations, not on other
* does NOT issue (the line is # )
* does not check issuing rules depending of # of books allowed / already issued

The next step is :
- check issuing rule.
- extend issuing rule to have a 3D array : for each branch / itemtype / borrowertype = issuing number and issuing length.
2004-05-03 09:10:51 +00:00
tipaul
21a379acda CIRCULATION : the big rewrite...
This 1st commit reorders deeply the circulation module.
The goal is to :
* have something 100% templated/translatable.
* have something easy to read & modify, to say to customers/users : you can define your circulation rules as you want if you accept to look in C4/Circ/Circ2.pm

The circulation now works :
1=> ask for the borrower barcode (as previously)
2=> ask for the item barcode.
3=> check "canbookbeissued". This new sub returns 2 arrays :
- IMPOSSIBLE : if something is here, then the issue is not possible and is not done.
- TOBECONFIRMED : if something is here, then the issue can be donc if the user confirms it.
4=> if TOBECONFIRMED is set : ask for confirmation, loop. if neither  are set or confirmation flag is set (2nd pass of the loop), then issue.

The IMPOSSIBLE & TOBECONFIRMED hashs contains :
* the reason of the line. always in capitals, with words separated by _ : BARCODE_UNKNOWN, DEBTS ... as key of the hash
* more information, as value of the hash ( TOBECONFIRMED{ALREADY_ISSUED} = "previous_borrower_name", for example)

This commit :
* compiles
* works on certain situations, not on other
* does NOT issue (the line is # )
* does not check issuing rules depending of # of books allowed / already issued

The next step is :
- check issuing rule.
- extend issuing rule to have a 3D array : for each branch / itemtype / borrowertype = issuing number and issuing length.
2004-05-03 09:02:12 +00:00
oleonard
e0d4eee48f Small changes to help fix Bug 436 2004-02-25 18:09:29 +00:00
tipaul
af08d677c5 synch'ing 2.0.0 branch (RC4 tag) and head 2004-02-11 08:42:01 +00:00
oleonard
0f8e6bfb73 Added variables available to template: streetaddress, city, phone, cardnumber. Added FIXME comments to sections where HTML should be moved to template 2004-01-26 19:32:36 +00:00
rangi
cf67d8bb8f Bug 605 fixed 2004-01-21 20:49:54 +00:00
rangi
9c998cda51 Fix for bug 535, and adding the classification column to the variables
available to the template
2003-11-04 19:48:50 +00:00
rangi
d187195a75 Fix for bug 592
Re-issuing book does not renew correctly
2003-10-31 21:02:16 +00:00
rangi
8576e81ea9 moving more html out of the script 2003-10-22 20:01:28 +00:00
rangi
68067f6400 Fix for bug 436, thanks to Pierre 2003-10-16 20:36:25 +00:00
rangi
4fe953202a fix for bug 535 2003-07-24 08:33:35 +00:00
rangi
44ee726663 Fixing the internal server error bug 2003-07-10 09:39:12 +00:00
tipaul
c101d517bb *** empty log message *** 2003-07-07 14:46:55 +00:00
plugz
a0de7c08fd Added allowborrow to the template parameters to check if a borrower can borrow books or not according to the "borrow" flag. 2003-07-01 11:22:48 +00:00
rangi
f8d250abfa Fixing the sticky due date problem reported by jerome 2003-06-26 09:31:39 +00:00
tipaul
a72d9621ae removing searchborrower from circ2.pm.
Already exists in Search.pm
this fixes bug #439 and improve consistency.
2003-06-05 17:03:31 +00:00
rangi
02196feed9 Shifted the todays issues and previous issues html out into the template
And fixed a bug that was causing the enter a borrowers card or surname box
to show. Even if you were currently issuing to a borrower
2003-05-30 20:37:09 +00:00
wolfpac444
d9ebc9a714 Fixed bug #169 2003-05-08 13:04:15 +00:00