Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Kyle Hall	dbc24783ee	Bug 17826: Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Mauchley <dmauchley@duchesne.utah.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: added parentheses on line 488 when assigning hashref to array. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	8 years ago
Marcel de Rooy	12a754a703	Bug 19386: [QA Follow-up] Remove some default values In the meantime bug 19403 added default nulls for gonenoaddress, lost and debarred. So these lines can be removed safely. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	6545cfe3f3	Bug 19386: Prevent t/db_dependent/SIP/Patron.t to fail randomly Depending on the values used by TestBuilder, some tests from t/db_dependent/SIP/Patron.t can fail # Failed test 'Not blocked without overdues when set to 'Don't block'' # at t/db_dependent/SIP/Patron.t line 55. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'confirmation'' # at t/db_dependent/SIP/Patron.t line 61. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'Block'' # at t/db_dependent/SIP/Patron.t line 67. # got: '0' # expected: '1' Caused by this check in C4::SIP::ILS::Patron->new 110 for (qw(EXPIRED CHARGES CREDITS GNA LOST DBARRED NOTES)) { 111 ($flags->{$_}) or next; [...] 115 if ($flags->{$_}->{noissues}) { 116 foreach my $toggle (qw(charge_ok renew_ok recall_ok hold_ok inet)) { 117 $ilspatron{$toggle} = 0; # if we get noissues, disable everything 118 } 119 } 120 } Test plan: Execute several times (50x?) these tests. Without this patch they may fail With this patch they must never fail Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Nick Clemens	ff4f085895	Bug 18812 - SIP Patron status does not respect OverduesBlockCirc To test: 1 - Set 'OverduesBlockCirc' to block 2 - Find or create a patron with overdues 3 - Perform a SIP patron lookup on that patron misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron {userid or cardnumber} --password {pass} -m patron_information 4 - Note the first character of response is a ' ' 5 - Apply patch 6 - Restart memcached, apache, and plack 7 - Perform SIP patron lookup 8 - Note the first character of response is 'Y' 9 - prove t/db_dependent/SIP/Patron.t 10 - Test should return green Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Marcel de Rooy	7ce9008a00	Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago