Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Martin Renvoize	3c9004357d	BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	ca17512a8e	Bug 11232: (qa followup) empty ID due to namespace mistake Note: NORMARC is missing the id field. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This patch makes t/db_dependent/Search.t pass again. NORMARC is currently not tested. I checked the results before and after applying the patch and the facets are now looking the same as before. Passes all tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	ccf7ae56f6	Bug 11232: (qa followup) Add missing fields/subfields to the item types faceta The itype facet was missing 952$y for both MARC21 and NORMARC. This patch adds that. And also modifies the zebra-biblios-dom.cfg file (also the debian/ version) so facetNumRecs is set to 1000 for zebra. It is the amount of records that are taken into account. The more record, the more exact the facets for the result set. 1000 was chosen as it changed the time to reindex 1000 records from 18s to 19s. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	1d28da41fb	Bug 11232: (followup) Configuration variable for enabling Zebra facets This patch adds a variable to koha-conf.xml controlling the use of Zebra facets. Usage: - use_zebra_facets = 1 \| 0 Zebra facets work only on DOM. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	e95cd1b126	Bug 11232: (followup) remove unnecesary namespace definition from all XML elements The previous patches for facet extraction from Zebra indexes set a default namespace on the following files: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/normarc/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and hence the XML file index_subfields can be cleaned by removing the namespace. To test: - Apply this patch - Run $ for i in marc21 normarc unimarc do xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/$i/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/$i/biblios/biblio-zebra-indexdefs.xsl done => SUCCESS: no errors reported - Run $ git diff => SUCCESS: no differences on the xsl files - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook <dcook@prosentient.com.au> Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	c1e384f250	Bug 11232: NORMARC facet definition and updated XSL file for DOM This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based on what is hardcoded on C4::Koha::getFacets(). The biblio-zebra-indexdefs.xsl file for NORMARC is generated using the usual: xsltproc ...koha-indexdefs-to-zebra.xsl ...normarc/biblios/biblio-koha-indexdefs.xml > \ ...normarc/biblios/biblio-zebra-indexdefs.xsl Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook <dcook@prosentient.com.au> Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	eafeb34097	Bug 11232: UNIMARC facet definition and updated XSL file for DOM This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based on what is hardcoded on C4::Koha::getFacets(). The biblio-zebra-indexdefs.xsl file for UNIMARC is generated using the usual: xsltproc ...koha-indexdefs-to-zebra.xsl ...unimarc/biblios/biblio-koha-indexdefs.xml > \ ...unimarc/biblios/biblio-zebra-indexdefs.xsl Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook <dcook@prosentient.com.au> Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	2cc293ecd6	Bug 11232: MARC21 facet definition and updated XSL file for DOM This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based on what is hardcoded on C4::Koha::getFacets(). The biblio-zebra-indexdefs.xsl file for MARC21 is generated using the usual: xsltproc ...koha-indexdefs-to-zebra.xsl ...marc21/biblios/biblio-koha-indexdefs.xml > \ ...marc21/biblios/biblio-zebra-indexdefs.xsl Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook <dcook@prosentient.com.au> Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	ca074c9253	Bug 11232: Add new syntax for facets definition on koha-indexdefs-to-zebra.xsl This patch changes koha-indexdefs-to-zebra.xsl to correctly process a new syntax for defining facet indexes on the XML files. It also changes the retrieval file to allow access to Zebra's internal data from Zoom (i.e. access to zebra::facet:*). Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: David Cook <dcook@prosentient.com.au> Seems to work with DOM and MARC21. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	cf2eb49448	Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolin Somers	95adc7a1f4	Bug 12453 - Do not use by default Host-Item-Number in UNIMARC Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber. But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks. If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted. This patch comments the 461$9 indexing in UNIMARC zebra config. Test plan : - Create a fresh UNIMARC install - Create a record with 461$9 containing a value - Index the record - Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches='' => Without the patch you get a result => With the patch you get no result Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Code is clean, commenting out all the indexing of 461$9. Trusting the author that this is the correct thing to do :) Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marcel de Rooy	fb2345a302	Bug 9612: (follow-up) restore elementSetName in Context.pm Restore elementSetName to marcxml for DOM indexing in Zconn (Context.pm). This prevents the need of rebuilding the index after restarting Zebra server. Removes the now incorrect reference to marcxml as 'superfluous' in four dom config files. Test plan: [1] Do not yet apply this patch. [2] Rebuild zebra index with the zebra config of commit `036f2a50e1`. [3] (Go back to master.) Restart your zebra server (no config change). You will have results without details. Apply this patch: you see details. Reset to master: no details again. [4] Install new zebra config from master. Search again: you still see no details. Restart zebra server. Search: you see details. Apply this patch. Search: still details. Restart zebra server. Search: still details. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested in a non-package environment (manual dev install). The package environment should work now too (results in step 4c might differ). Progress on bug 12012 would be appropriate to sync all changes. Tested the response of the SRU server too. Signed-off-by: Marc Veron <veron@veron.ch> I tested starting on a VM with Koha 3.15.00.019 installed. Did git pull -> Koha 3.15.00.051 Result: No details in search results. Applied patch. Result: Search results display fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Bernardo Gonzalez Kriegel	845af19915	Bug 8375: (follow-up) fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. Added a FIXME for the hardcoded forced oblique -chris_n Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Dobrica Pavlinusic	8e71489c33	Bug 8375: Use TrueType fonts in PDF::Reuse Since built-in PDF fonts suport just Latin-1 encoding, we have to switch to TrueType fonts to correctly encode all UTF-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to TrueType fonts which are included in koha-conf.xml under new <ttf> section. Without this directive in kona-conf.xml code will still use Latin-1 built-in pdf fonts. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Marcel de Rooy	67abcc6443	Bug 9612: fix SRU response for DOM indexing This patch makes changes to koha-conf.xml by removing the fallback section from biblioserver and authserver. The information is in a include file on the same server (no need to fall back) and moreover, some information is not up-to-date and should be moved elsewhere. The patch also simplifies the DOM retrieval-info files for auth and bib. And eliminates superfluous F and usmarc from the dom-config files. (I felt the urge to remove marcxml too, but left it for now; see also the second patch.) For reference, look at the marcxml example files of Zebra. NOTE: This patch does not deal with the Debian package installs. In the same way koha-conf-site.xml.in, and -retrieval-info- could be adjusted. Test plan: [1] Run at least a dev install in order to copy the new files to your Zebra folders. Choose for DOM indexing. Enable the SRU server on port 9998 (small edit in koha-conf.xml). [2] Restart Zebra and reindex -a -b -x. [3] Verify if a search from Koha still functions as expected. Check the SRU output on port 9998. NOTE: If you do not pass recordSchema, you should get back a marc response now (instead of index schema). Bonus: Add your server as a Z3950 target to another Koha install. And perform a Z3950 search from the other server to your new install. Bonus: Check response from the auth and biblio socket via yaz-client. [4] Reindex again with -a -b but without -x. [5] Repeat Koha search, SRU response (Z3950, yaz-client). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Colin Campbell	735381b371	Bug 10729: Add phrases configuration for ICU Add a separate phrases-icu.xml for phrase indexes The file is based on that distributed with zebra with a couple of additions to reflect Koha usage This patch adds a separate tokenizer variable for phrase indexes so that default.idx is correctly rewritten for sites using icu indexing Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Applied patch - perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log - make upgrade - Restarted Zebra server - Did a full reindex of bibliographic and authorities - Checked various searches - Links records to authorities - Checked created links work correctly I couldn't find a regression with this patch. Passes all tests and QA script. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Fridolin Somers	bd65c6e95b	Bug 11635: remove duplicate definition of 995$r in UNIMARC record.abs Test plan : - Create a fresh install UNIMARC flavor and GRS1 indexing for biblios - Re-indexe database - Perform a search with index "itemtype" (and then "itype") on an existing value of 995$r. For example : itemtype:BOOK => Check you get results Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Kyle Hall	7b295e9dd7	Bug 9865 (follow-up) give better usage examples in example SIPconfig.xml Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Adrien Saurat	4a72f6b237	Bug 9865: make SIP msg encoding configurable via SIPconfig.xml The accounts->login tag in SIPconfig.xml can now accept a new parameter, "encoding". It will be mostly used to encode to utf8. For this, simply add the parameter: encoding="utf8" Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised, does nothing if encoding is not set. Blows up all the machines that can't handled utf8 if it is set :) But that's not Koha's fault. :) Patch rebased by Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> But now I did it the right way! And I can confirm that this patch solves all issues with mangled characters in SIP messages. Confirmed that it looks good with Norwegian characters in patron name and in book titles. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	eb139e4a8b	Bug 9972: (follow-up) enable Lexile searches to work using QueryParser Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Galen Charlton	26e2224409	Bug 9972: (follow-up) add new indexes to the QueryParser config Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Mirko Tietgen	84bdb55549	Bug 9972: Add/change some zebra indexes (MARC21) This patch adds :w and :p versions to the index for »Lexile number« (it has only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also adds the »curriculum«-index to Search.pm. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Doug Kingston	88e7faf860	Bug 11078: Add locking to rebuild_zebra This patch adds locking to rebuild_zebra.pl to ensure that simultaneous changes are prevented (as one is likely to overwrite the other). Incremental updates in daemon mode will skipped if the lock is busy and they will be picked up on the next pass. Non-daemon mode invocations will also exit immediately if they cannot get the lock unless the new flag -wait-for-lock is specified, in which case they will wait until the get the lock and then proceed. Supporting changes made to Makefile.PL and templates for the new locking directory (paralleling the other zebra lock directories). We stash the zebra_lockdir in koha-conf.xml so rebuild_zebra.pl can find it. To address earlier QA concerns we: 1. added code to check if flock is available and ignore locking if it's missing (from M. de Rooy) 2. changed default for adhoc invocations to abort if they cannot obtain the lock. Added option -wait-for-lock if the user prefers to wait until the lock is free, and then continue processing. 3. added missing entry to t/db_dependent/zebra_config.pl 4. added a fallback locking directory of /tmp Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Doug merged the original patch with the QA changes. Just for the record, noting here that the original patch was tested extensively too by Martin Renvoize. I have added a followup for some exceptional cases. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Mathieu Saby	b6118db2f5	Bug 11202: Improve UNIMARC biblio indexing This patch makes the following changes to UNIMARC biblio indexing : A. Changes to UNIMARC conf files 1. add comments to biblio-koha-indexdefs.xml 2. make biblio-koha-indexdefs.xml more compact by grouping some declarations Ex : 200$f and 200$g => one declaration for 200$fg 3. suppress unneeded declarations (indexing of some 4XX fields and 6XX fields not in unimarc format) 4. unindex some (sub)fields unneeded by most users (318, 207,230,210a, 215, 4XXd) 5. change the way 308 field is indexed (no visible changes) 6. replace Title-host with Host-item -- see bug 11119 7. index 208 in Material-Type -- see bug 11119 8. index 100 pos 8-9 and 9-12 in pubdate:y and pubdate:n 9. index 100 pos 8-9 in pubdate:s instead of 210$d 10. Index all subfields of note 334 and 327 in note index 11. Index 304 and 327 in title index as well as note index 327 can contain a list of titles included in a work 304 can contain the title of the original work in case of a translation 12. Index 314 in author index as well as note index 314 can contain authors not mentionned in 200$f/g (the 4th, 5th etc. author) 13. Index 328 note in Dissertation-information as well as note 14. Index 328$t in Title B. Changes to ccl.properties : 1. add a new index Dissertation-information (1056) 2. fix EAN, pubdate and acqdate (they were not linked with bib1 attributes) C. Changes to Search.pm 1. add Dissertation-information and suppress Title-host and UPC D. Changes to QP config file queryparser.yaml 1. add Dissertation-information 2 fix EAN, pubdate and acqdate Test plan : If you cannot test in GRS1, test only in DOM, as GRS will be deprecated. 1. Apply the patch in a UNIMARC Koha running with DOM and ICU 2. copy src/etc/searchengine/queryparser.yaml into the main config directory of QP 3. copy src/etc/zebradb/ccl.properties into the main config directory of Zebra 4. copy src/etc/zebradb/marc_defs/unimarc/biblio/* into the main config directory of Zebra 5. reindex biblios (rebuild_zebra.pl -r -b -x -v) 6. test note index : make some searches on 334$b or 327$b 7. test author index : make some searches on 314 field 8. test title index : make some searches on 304 and 327 field, make a search on 328$t subfield 9. test dissertation-information index : make some searches on 328 field 10. In a record, put in the dates of 100 fields the values "1000" (1st date) and "1001" (2d date) ; try to search a book written in year 1000, you should find the record ; idem for year 1001 11. make some searches and sort by date. It should work better as before, especially if you have values like "c2009" or "impr. 2010" in 210 field 12. Regression test : make some searches on several indexes, like EAN, etc. It should work as before Test 10-12 with and without Queryparser activated. Be careful: with Queryparser activated, the index names (title, dissertation-information...) must be entered in lowercase only. Of course, to test search and sort by dates, you need to have full records, with dates in 100 field as well as 210 field. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	aaff735269	Bug 10544: (follow-up) update MARC21 DOM index definitions This patch updates the MARC21 DOM index definitions to index the 952$i as 'Number-local-acquisition' rather than 'stocknumber'. To test (for a MARC21/DOM setup): [1] Copy the MARC21 biblio-zebra-indexdefs.xsl over to the active Zebra configuration directory. [2] Reindex the bib records. [3] Verify that 'stocknumber', 'inv', and 'number-local-acquisition' searches work. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Fridolyn SOMERS	f62e45dc92	Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition into QueryParser configuration file. Like in ccl.properties, "Number-local-acquisition" is the main index name and "stocknumber" and "inv" are aliases. Test plan : Enable QueryParser : - Enable UseQueryParser syspref - Edit your koha-conf.xml - Add to "config" node : <queryparser_config>[your path]/etc/searchengine/queryparser.yaml</queryparser_config>, adapt [your patch] to your install configuration folder - If needed copy from sources "etc/searchengine/queryparser.yaml" into your install configuration folder Test search : - Add Number-local-acquisition on an existing subfield in records.abs. For example on item barcode field - Reindex Zebra database - Choose a value of this field that will match some results. For example : "0" will match all barcodes beginning with zero - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0&sort_by=relevance => You get some results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=inv&q=0&sort_by=relevance => You get the same results - In intranet, enter this URL : <your server>/cgi-bin/koha/catalogue/search.pl?idx=number-local-acquisition&q=0&sort_by=relevance => You get the same results Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Comments on case sensitivity of index names in QueryParser, see Bugzilla. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Fridolyn SOMERS	b0f39cee0d	Bug 10544: add Number-local-acquisition in known indexes Adding Number-local-acquisition in C4::Search known indexes allows to search without using "ccl=" prefix. Also corrects in ccl.properties : inv must be an alias of Number-local-acquisition. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Fridolyn SOMERS	10e1cbeb14	Bug 10544: ensure that stocknumber searches work for MARC21 Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. Test plan (for MARC21/GRS1): - drop zebra database (rebuild_zebra.pl -r ...) - reindex - test in simple search : ccl=Number-local-acquisition,alwaysmatches='' => you get all records with a stocknumber - test in simple search : ccl=stocknumber,alwaysmatches='' => you get the same results Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Marcel de Rooy	3424f0d84a	Bug 11619: remove duplicate key in QueryParser config Corrects a double entry for language in yaml file. Language should have been language-original. Test plan: Check that you have language-original in your zebra install. Specifically, this index should cover MARC21 041$h. Enable QueryParser and search for a record with this index. Note that this patch does not enable searching on this index without QueryParser. This is true for many more indexes in record.abs that are not included in the getIndexes routine. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described - make sure you are testing with a current indexing configuration. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Galen Charlton	5920ca6fa0	Bug 11389: reenable Pg as a DB scheme that Koha can connect to This patch restores the ability to request a DBI database handle or a DBIx::Class schema object connected to a PostgreSQL database. To address the concerns raised in bug 7188, only "mysql" and "Pg" are recognized as valid DB schemes. If anything else is passed to C4::Context::db_scheme2dbi or set as the db_scheme in the Koha configuration file, the DBD driver to load is assumed to be "mysql". Note that this patch drops any pretense of Oracle support. To test: [1] Apply patch, and verify that the database-dependent tests pass when run against a MySQL Koha database. [2] To test against PostgreSQL, create a Pg database and edit koha-conf.xml to set db_scheme to Pg (and adjust the other DB connection parameters appropriately). The following tests should pass, at minimum: t/Context.t t/db_dependent/Koha_Database.t Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, some additional notes: - Installed Postgres following http://wiki.ubuntuusers.de/PostgreSQL - Created a database user koha - Created a database koha - Changed the koha-conf.xml file <db_scheme>Pg</db_scheme> <database>koha</database> <hostname>localhost</hostname> <port>5432</port> <user>koha</user> <pass>xxxx</pass> - Installed libdbd-pg-perl - Ran the web installer until step 3 everything looked ok Step 3 complains: Password for user koha: psql: fe_sendauth: no password supplied - Both t/Context.t and t/db_dependent/Koha_Database.t pass Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Chris Cormack	211acdd30b	Bug 11192: (follow-up) fix a little typo Test plan the same as the original patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan. Searches tested were: fic=e fiction=e Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	a032b0a5cd	Bug 11192: Fix lf and ff07-02 definition in ccl.properties ff7-02 1=87020 (position 2 of field 007 in MARC21) should be ff7-02 1=8702 lf 1=8833 lf fiction fic fiction should be lf 1=8833 fiction lf fic lf To test : 1. apply the patch 2. copy the modified ccl.properties into your active Zebra config directory 3. reindex zebra (rebuild_zebra.pl -b -x -r -v) 4. make some searches using the fixed indexes Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	e4912a20f9	Bug 9940: (follow-up) add language-original to QP search field list This patch adds language-original to the list of search fields recognized by QueryParser. To test: [1] After doing the tests in the main patch, copy the configuration file etc/searchengine/queryparser.yaml into place, turn on the UseQueryParser system preference, and verify that searching on language-original still works. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	a573ac1fa8	Bug 9940: (follow-up) FIX comment: language-original is 101$c, not $h Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	451f67c055	Bug 9940: Add a new index for the original language of a document It could be useful to index the original language of a document (i.e. "fre" for the English translation of a French novel). This patch renames the Bib-1 use attribute 1095 from Code-language-original to language-original and uses it to index: - MARC21 041$h subfield - UNIMARC 101$c subfield It adds "language-original" in the list of index in Search.pm. Test plan : A. in a MARC21 GRS1 environment 1. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/marc21/biblios/record.abs) from your source etc/ directory to your main koha etc/ directory 2. Reindex zebra 3. Make some searches, like "language-original:fre" B. in a MARC21 DOM environment 4. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl) from your source etc/ directory to your main koha etc/ directory 5. Reindex zebra 6. Make some searches, like "language-original:fre" C. in a UNIMARC GRS1 environment 7. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/unimarc/biblios/record.abs) from your source etc/ directory to your main koha etc/ directory 8. Reindex zebra 9. Make some searches, like "language-original:fre" A. in a UNIMARC DOM environment 10. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl) from your source etc/ directory to your main koha etc/ directory 11. Reindex zebra 12. Make some searches, like "language-original:fre" Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	54937c5eb3	Bug 11255: allow "relevance ascending" as a sort option This patch fixes a problem where if a staff member sets the defaultSortField/defaultSortOrder system preferences to relevance ascending while QueryParser is enabled, default keyword search would break -- the query parser config did not declare relevance asc as a possible "modifier". Note that setting the sort order to relevance ascending does not actually make catalog search return results with the least relevant records showing up first; Zebra does not support such a mode. In other words, relevance ascending acts exactly the same as relevance descending. Test plan: 0/ Create some biblio with "history" in the title and ensure that the QueryParser system preference is enabled. 1/ Define prefs defaultSortField = relevance and defaultSortOrder = asc 2/ Search "history" on the staff interface 3/ Note that no result is returned. 4/ Apply the patch 5/ Verify the queryparser config file in use takes the modification into account (see the queryparser_config value in your $KOHA_CONF file). 6/ Relaunch the search and verify results are returned Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	c00131e0ff	Bug 9830: Fix some indexes in UNIMARC item indexing With this combination of sysprefs, and a UNIMARC configuration, it was impossible to search on location, barcode and ccode indexes : QueryWeightFields is activated QueryAutoTruncate only if * is added But in UNIMARC, location, barcode and ccode (995 $e,$f,h) were indexed only as "words". They need to be indexed also as "phrase". Additionnaly, in UNIMARC, information about damaged and withdrawn status of items is not indexed, while it is done in MARC21. This patch - add 2 new indexes for 995$1 (damaged) and 995$3 (withdrawn) - index location, barcode and ccode as "phrase" as well as "words" Indexing of items in UNIMARC could be improved later. So this patch also add comments explaining the origin of Koha 995, I think it could be useful for further changes. To test, on a UNIMARC configuration : A. indexed with GRS-1 1) Set sysprefs QueryWeightFields as "activated" and QueryAutoTruncate as "only if * is added" 2) Select location index in advanced search and search for a value existing in your records in 995$e => 0 results 3) Apply patch 4) Rebuild zebra 5) Select location index in advanced search and search for a value existing in your records in 995$e => x results 6) Mark an item as withdrawn; search "withdrawn:1" => x results, and among them the biblio to which the item is attached 7) Mark an item as damaged ; search "damaged:1" => x results, and among them the biblio to which the item is attached B. indexed with DOM Do the same operations Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors Test Apply the patch Begin with GRS-1 Full reindex Search by location, no results cp files biblio-*-indexdefs.xml and record.abs to destination on etc/zebra Full reindex Search by location, got results Switch to DOM reset files Full reindex Search by location, no results cp files Full reindex Search by location, results ! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	4d8b1ec786	Bug 7421: support indexing UNIMARC authority records using the DOM Filter I took as a base the patch of F. Demians, but made a lot of changes, so I think it is more logical to create a new patch as the behavior is not the same as previous patch. I tried to define DOM config files as a "miror" of record.abs, so the behavior be the same. If it is OK, we will be able to improve indexing later, for example suppressing warns, managing indicators or subdivisions, etc. I made some little changes to record.abs : - comments - 216 was indexed in Conference-name as well as Trademark. I suppose that "Conference-name" is an error, so I indexed only in Trademark - index 2 new notes : 340 / 356 The only difference between record.abs and DOM is that DOM config files does not index complete fields, but subfields. Ex : melm 200 ===> <kohaidx:index_subfields tag="200" subfields="abcdfgjxyz"> I took all the subfields from the UNIMARC Authorities manual. The only subfields not indexed are numeric subfields : $7, $8 for language of record, and $0,2,3,5,6 for 4XX/5XX/7XX To test : - index a set of bib and auth records with GRS-1 - make some searches on different kind of authorities - index the same records with DOM - make the same searches - You are not supposed to see differences Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> As I am not a UNIMARC user it's hard for me to test this, but while testing other authority related patches I noticed that I couldn't index the UNIMARC authorities of the sample base. The files are obviously missing and reindex_zebra.pl notes this. With this patch applied, indexing works and authorities are searchable in my installation. Signed-off-by: Vitor Fernandes <fvernandes@keep.pt> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	13 years ago
Mathieu Saby	5298140c67	Bug 10037: fix item index in UNIMARC DOM indexing In UNIMARC DOM indexing, "item" index was working only for subfields of 995 field mapped with specific indexes, and also in index (ex : $a, $b...). It was not working for the other subfields (ex : $g), because a comment from record.abs was integrated in DOM config files. This patch removes the comment. To test, in a DOM UNIMARC environment : 1) In a item, write some value "Test10037" in 995$g 2) Search for this value in simple search, this way : item=Test10037 => you should have no results 3) Apply the patch. if necessary, copy the modified etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl into the /etc/... directory in your main Koha directory 4) Reindex Zebra biblios 5) Do the same search as 2) => you should have one result Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Test NOTE: default UNIMARC framework don't have 995g, so I must add it first. 1) Added test string to 995b on some record 2) Reindex and search as indicated, no results 3) cp files to destination 4) reindex 5) search and result ok ! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	8ea3462517	Bug 8252: (follow-up) standardize name of Identifier-publisher-for-music index To test: [1] When running t/db_dependent/Search.t, veify that no warnings like this are shown: 15:52:07-10/10 zebraidx(2006) [warn] Index 'Number-music-publisher' not found in attset(s) Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	45d0365d12	Bug 8620: (follow-up) apply to NORMARC and MARC21 authorities This applies the fix for the Any index to NORMARC bib and MARC21 authority DOM Zebra indexes. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	5024e519ad	Bug 8252: (follow-up) tidy up long lines in bib1.att Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	475a9d19d1	Bug 8252: (follow-up) fix biblio-zebra-indexdefs.xsl This patch fixes biblio-zebra-indexdefs.xsl files. It was generated from biblio-koha-indexdefs.xsm with the new koha-indexdefs-to-zebra.xsl amended by F. Démians's patch. To test : - Take a DOM UNIMARC Koha - Apply all the patchs of 8252 bug, including this one - Copy src/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl to your etc/zebradb/marc_defs/unimarc/biblios/ located in your installation directory - Run rebuid_zebra -b -x -r -v - make advanced searches on staff interface and opac, on coded fields indexes (Audience, Literary genre, Biography, Illustration, Content, Video Types, Serial Type, Periodicity, Regularity, Picture) Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Ok for me. This patch put in sync indexes XSL definition with authoritative XML definition. Subsequently, it won't be difficult to amend DOM UNIMARC indexes defintion if necessary. And, as it is, I don't see any regression, whereas I can see huge improvements. Thanks Mathieu! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Frédéric Demians	f9addcc98b	Bug 8852: DOM XSL now handles subfield substring extraction This patch modify koha-indexdefs-to-zebra.xsl in order to add the ability to populate indexes with subfield substring. It's now possible to understand such construction as: <index_subfields xmlns="http://..." tag="100" subfields="a" offset="7" length="1"> <target_index>tpubdate:s</target_index> </index_subfields> Signed-off-by:Mathieu Saby <mathieu.saby@univ-rennes2.fr> I applied the patch and ran xsltproc koha-indexdefs-to-zebra.xsl ../marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml \ > ../marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl I looked at the generated file. It looks nice. Then I copied it file in my INSTALLDIR/etc/zebra.... and reindexed my records with rebuild_zebra.pl I made some searches on coded position index and non coded position indexes, everything works. http://bugs.koha-community.org/show_bug.cgi?id=8252 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	43809d2835	Bug 8252: Followup for Date/time-last-modified and Music number This followup restores the original wording of "Date/time-last-modified" index, and change the name of "Music-number" index to "Number-music-publisher" To test : 1. In a UNIMARC Koha instance 2. Apply patchs #1, #2 and this followup 3. Copy from src/etc/zebradb directory to the etc/zebradb/ in your main Koha directory the following files: -- zebradb/biblios/etc/bib1.att -- zebradb/ccl.properties -- zebradb/marc_defs/unimarc/biblios/record.abs -- zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml -- zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl 4. Rebuild zebra with -b -x -v -r options 5. Write a value like "test071a" in 071$a field in a record 6. Check if you can find this record with this search: "ccl=Number-music-publisher:test071a" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Test Copy files reindex full Modify a couple of record to add 071a with test message Reindex -v -z -b -x Search test message as described and found modified records. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	8034566027	Bug 8252: Fix indexing of UNIMARC 1xx for DOM This patch makes the same changes in UNIMARC DOM configuration as patch 1 made for GRS-1. positions of subfields are indexed that way : In biblio-koha-indexdefs.xml : tag="100" subfields="a" offset="17" length="1" In biblio-zebra-indexdefs.xsl : xslo:value-of select="substring(., 17, 1)" I had to edit biblio-zebra-indexdefs.xsl by hand, because etc/zebdradb/xml/koha-indexdefs-to-zebra.xsl does only support "subtring" in handle-one-index-control-field template. It is good for MARC21, but not for UNIMARC : in MARC21, indexing subtrings is needed for controled field (001-009, with no subfields) But in UNIMARC it is needed for subfields of 1XX fields. So if DOM indexing is working with these new files, we may need to change koha-indexdefs-to-zebra.xsl. Test plan (not possible in a sandbox) : 1) In a Koha instance using UNIMARC and DOM indexing 2) Apply Patch 1 and Patch 2 (this one) 3) Copy the following files from the etc/zebradb directory of your source into the etc/zebradb directory of your main Koha directory : -- etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml -- etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl -- etc/zebradb/ccl.properties -- etc/zebradb/biblios/etc/bib1.att 4) rebuild zebra with -x -b -r -v options 5) check if coded filters in advanced search are usable in OPAC and Staff interface Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works. No koha-qa errors. Test for DOM Apply patches Don't forget to copy files reindex Search by coded fields works, also Country-publication Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	041e3603a1	Bug 8252: Fix indexing of UNIMARC 1xx for GRS-1 Before fixing UNIMARC DOM indexing, we must fix GRS-1 indexing 1) In advanced search, some Coded fields index are not working: Print, Illustration, Content 2) Country-heading index is not working 3) Some subfields are indexed in wrong indexes : 102$a should be in Country-publication instead of Country-heading (non defined in bib1.att) 106$a, filled only for printed works, should be in ff88-23 (form of item) instead of itype. (ff88-23 is made for Marc21 008 pos 23, which contains the same data as 106a) 200$b should be in Material-type instead of (or in addition to) itype and itemtype: (Material-type :"free-form string, ... that describes the material type of the item, e.g., cassette, kit, computer database, computer file.") 100$a pos 22-24 should not be indexed as "ln" : it is the language of the record, not the language of the ressource 4) Index names are too long : if we index new positions of coded fields, with existing names it breaks Zebra indexing (there must be a limit in line lenghth in record.abs?) 5) There are a lot of warns when rebuiding zebra. This patch make some changes in bib1.att (could be used later to improve search) : - fixing wording for att 51 and 1012 - adding comments for attributes based on MARC21 008 field (8800-8841) - creating 8806 (tpubdate), 8838 (Modified-code), 8818 (ff8-18), 8840 (ff8-18-21), 8819 (ff8-19), 8821 (ff8-21), 8828 (ff8-28), 8830 (ff8-30), 8831 (ff8-31) - creating attributes specific to UNIMARC : 9701-9707 (Video-mt, Graphics-type, Graphics-support, Title-page-availability, Cumulative-index-availability, script-Title, char-encoding) - setting apart 3 blocks of attributes, so it could be easy to make further changes : -- common to Marc21 and UNIMARC : 8806, 8822, 8838 -- slightly different in Marc21 and UNIMARC (different meanings according to the type of the record => don't match a single UNIMARC field) -- specific to UNIMARC : 9701-9707 In ccl.properties : - creating a new index: Country-publication 1=1053 - suppressing some warns by mapping with bib1 att: Date-time-last-modified, Name, rtype, Music-number - defining indexes using the 3 blocks attributes defined in bib1 (common to Marc21 and UNIMARC, slightly different, specific to UNIMARC) In record.abs : - renaming some index for 100-105-110 fields - correcting indexing of 102$a (country of publication) 106$a (ff88-23) 100$a pos 22-24 (language of record, no more indexed) 105$a pos. 0-3 (illustration code) 200$b (for the moment, I keep it indexed in itype and itemtype, but also Material-Type) In C4/Search.pm : - adding "Country-publication" index In OPAC and staff interface template subtypes_unimarc.in : - renaming indexes to take into account the changes made to Zebra config files To test (this cannot be done with a sandbox) : 1) Apply the patch in a UNIMARC GRS-1 Koha instance 2) Copy the following files from the etc/zebradb of your source directory into the etc/zebradb of your main Koha directory: -- etc/zebradb/biblios/etc/bib1.att -- etc/zebradb/ccl.properties -- etc/zebradb/marc_defs/unimarc/biblios/record.abs 3) Reindex your data (rebuild_zebra -x -b -r -v) 4) Try to use those Coded fields indexes in Advanced search, in OPAC and Staff interface (available after clicking on "More options", then on "Coded information filters"): Audience, Print, Literary genre, Biography, Illustration, Content, Video Types, Serials, Serial Type, Periodicity, Regularity 5) Try to search "Country-publication=FR" in simple search Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Tests for GRS-1 Followed test plan Search by coded fields works, but only on OPAC, on staff there are few options Search by Country-publication works after patch Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	e1de36fbb9	Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1\|COterm1\|CPCPL\|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL\|AA23529000035676\|ACterm1\|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo\|AA23529000035676\|BLY\|CQN\|AFGreetings from Koha. \|AFMPL\|AO\|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Kyle Hall	90e2aafeb5	Bug 9531: Make SIP2 message terminator configurable via SIPconfig.xml Add a terminator option to SIPConfig.xml, choices for 'terminator' are 'CR' or 'CRLF'. The default continues to be 'CRLF' if 'terminator' is undefined. Test Plan: 1) Apply patch 2) Start SIP server 3) Run C4/SIP/t/04patron_status.t 4) Stop SIP server 5) Add terminator="CR" for account login 'term1' 6) Run 04patron_status.t again, you should see no change Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Adrien Saurat <adrien.saurat@biblibre.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	a9719215b4	Bug 10325: (follow-up) fix typos and whitespace in httpd.conf example Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago

1 2 3 4 5 ...

291 Commits (e0c1476123603e9cfe9486ad67c507ff5b1574c3)