Commit graph

220 commits

Author SHA1 Message Date
Sébastien Hinderer
f1f833c965 bug 3464: Takes columns country and B_country of table borrowers into account in related operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:19:20 -04:00
Liz Rea
ca591d092b Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:33:44 -04:00
Darrell Ulm
8a4195658d Bug 2652 - This patch is an extension of the slip printing feature
and will print a SHORT SLIP of today's checkouts only.
 I also enhanced the normal slip to print the overdues separately as well as today's
 checkouts. There is another button on the print CIRC menu. Easily another quick key
 can be added, one for the regular slip and one for the short slip, i.e. today's
 only.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:08:05 -04:00
Jane Wagner
bf38b1f7bb Bug 3532 show lost, damaged statuses on patron record
The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 21:56:48 -04:00
Kyle M Hall
f41971eadf Reverse Payment - Allows any payment to be 'undone' while retaining a record of said payment. Useful for accidental double-payments.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:23:33 -04:00
605be873e0 Correcting some selectors to conform with upgraded jQuery syntax (see Bug 3297).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 10:17:56 -04:00
5a93f0b806 More changes to implement jQuery upgrade.
- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:18 -04:00
Garry Collum
a9ecff3d98 Bug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.
Removed toggle variable from readingrec.pl and readingrec.tmpl.  Used __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:00:02 -04:00
471fe3927a Removing hard-coded $ symbols from the template, addressing Bug 2547
Pending a system for displaying the correct currency symbol based on the system's default currency all dollar-specific symbols should be removed in favor of no symbol.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:25 -05:00
18abc28d62 Misplaced </tbody> breaks table sorting. Fixes Bug 3365.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:49:24 -05:00
0d0fef6dc5 Another fix for Bug 3119 (Add date due to circ history)
Moving links (non-table data) out of table to correct persistent table border display issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:03:43 -05:00
Liz Rea
eac25405c4 bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 07:56:06 -05:00
Garry Collum
16a94b5210 Bug 2889: Removed toggle variable from member.pl and .tmpl
Removed toggle variable from member.pl and member.tmpl.  Replaced with template variable __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-15 12:43:42 -05:00
Joe Atzberger
6e19303ba0 Cleanup - moremember.pl and .tmpl
Removed last 3 EXPR statements.  Removed toggle code.
Fixed jquery for warning on image deletion.
Fixed permission check for image upload to be granular.
Lots of formatting/whitespace cleanup.
Removed useless form and unused template vars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 18:00:55 -05:00
Nicole Engard
53e16bc5b7 Fix Bug 3259 - change 'too many renewals' to 'not renewable'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 17:44:05 -05:00
Galen Charlton
ab44e2986a bug 2866: Overdues Reports - Upgrading to filter by patron extended attributes
Patch by Rick Welykochy <rick@praxis.com.au> with some squashing
by me.

Bug Report: 2866 Filtering and sorting the overdue report using patron attributes

1. Create a new system preference ?FilterBeforeOverdueReport?
2. Option to filter *before* the overdue report runs, avoiding report slowness
3. Add searchable patron attributes to the list of overdue report filters
4. Add searchable patron attributes to the sort fields on the overdue report
5. add item call number and replacement price
6. the CSV download link now returns the same
   data as the web report, rather than (inconsistently)
   trying to run the overdue_notices.pl batch job
7. always run report if requesting CSV
8. barcodes are now links
9. use item-level item type for overdue itemtype filter

Included is a new callback for searching patron attributes, similar
to circ/ysearch.pl.

The following additional bugs are fixed:

2748: Nothing is output to the .csv file for the "Overdues" circulation report

This is fixed by having circ/overdues.pl produce the CSV output directly instead
of trying to call the overdues cronjob.  The CSV output includes all of the fields
that are displayed on the web table plus the item replacement price and any extended
patron attributes.

2836: overdues.csv may contain HTML
2837: Descending sort doesn't descend on the overdues report plus other probs with report

This enhancement was sponsored by the Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:20:36 -05:00
Galen Charlton
20b2bbba5e bug 3222: fix display of message queue
If no messages have been sent to the patron, display
a notice that that effect in the staff patron messaging
tab rather than just a blank page.

[LL bug 452]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:21:02 -05:00
Galen Charlton
b6e62489d8 bug 3222: moved messaging preference editing
The display and editing of messaging preferences
for a patron have been moved as follows:

* the prefs for a patron are now displayed on the
  patron details tab, not the messaging tab.
* the prefs are now modified by editing the patron
  record, not on the messaging tab.

The messaging tab now contains only the list of
messages that have been or will be sent to the patron.

When creating a new patron record, changing the patron
category via the category dropdown now also changes
the default messaging preferences for that patron.  If
you start editing a new patron, change one of the messaging
preferences, then change the patron category, the form will
ask you if you want to keep the preferences or get
the defaults belonging to the new patron category.

Note that when you edit an existing patron record, changing
the patron category will *not* cause the messaging preferences
to be automatically changed.

Programmer's note: this commit introduces a new web service,
members/default_messagingprefs.pl, that uses Jesse Weaver's
C4::Service module.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:56 -05:00
Galen Charlton
ca7db466d6 bug 3222: changes to messaging preferences form
Moved the messaging preferences form to a new
include, messaging-preference-form.inc, so that
it can be used to set messaging prefs both for a
patron and for a patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:49 -05:00
Michael Hafen
5d30ed4ce8 followup to patch by Galen - add javascript to prevent premature submission of forms in Fines pages
Adds javascript to the manual invoice and manual credit pages to prevent
the premature submission of these forms when using a barcode scanner.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-21 15:20:50 -05:00
Liz Rea
99b84d69b6 Bug 1984 - added Javascript in the header to open, print, and close the slip window
This is for printing circulation slips.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 08:23:58 -05:00
Liz Rea
69620d9479 Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:26 -05:00
8f95ec3dbe Fix for Bug 3119: Add due date to the patron circulation history window
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:45:11 -05:00
Nicole Engard
40bd4a508a Partial fix for Bug #3139
Standardized all references to Address and Zip/Postal Code.

Also fixed bug #3138 by making the Alt address ready City, State.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 08:55:22 -05:00
ac8ff44432 Bug 3132: Reformatting guarantor entry based on C vs. P patron types
Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 14:58:52 -05:00
c2fdde125b Removing duplicate email form field. Fixes Bug 3010.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 11:40:29 -05:00
Galen Charlton
764136b463 bug 3100: increase width of alternate postal code
The alternative postal code input on the patron
editing form was only permitted 5 characters of
input.  Increase this to 10 to match the
primary zipcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 09:34:08 -05:00
67bba6319d Reformatting receipt template and CSS to be more readable.
A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:37 -05:00
90e995704c Fix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:15 -05:00
John Beppu
5279faf72e bug 356: removed redundant interface
The messaging tab already provided a way to configure these
notifications, so this isn't needed.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 13:48:47 -06:00
John Beppu
a8accfb4c5 Messaging Preferences for Intranet
- Added ability to modify per-user messaging preferences.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:09 -06:00
526a39b62d Showing totals for charges and replacement costs on patron detail screen and print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:41:18 -06:00
Danny Bouman
277049ada5 bug 2687 followup: Increase maxlength attribute to support 64 characters
Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:05:25 -06:00
ac196cddcc Hiding SMS messaging preferences if there is no SMSSendDriver defined in system preferences.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:53 -06:00
Galen Charlton
ca7ae0ab41 remove TMPL_IF EXPR in member.tmpl
Quells following error message in Apache log:

EXPR:at pos 8: non-initialized variable overdues,
referer: http://example.edu/cgi-bin/koha/members/members-home.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 15:53:07 -06:00
Nahuel ANGELINETTI
61ebf9160f (bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set
This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:46:11 -06:00
John Beppu
7b683cf583 bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:00 -06:00
36e384adc7 Adding javascript to let user click table cell to check containing checkbox.
This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:31:08 -06:00
f04792b3a4 Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:58 -05:00
Galen Charlton
2186eae294 followup 4 to renewal limit override
* use style="display: none" instead of content_hidden
* fix JavaScript so that actions that check/uncheck
  items for a renew or return do not affect
  the override renewal limit checkbox

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:04 -05:00
Michael Hafen
03d8521cbf Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:34:50 -05:00
Michael Hafen
0da84bb4fe Adding a few columns to members/readingrec.pl
Add barcode and issues.renewals to members/readingrec.pl
Had to change the query in C4/Members, items.renewals was squashing
issues.renewals.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 14:47:21 -05:00
Galen Charlton
3c4159bed4 followup on Owen's patron attributes patch
Hide the display of the patron attributes only if
no types are defined; the patron attributes section
(and more importantly, the edit link), should still
be displayed if an attribute type is defined, even
if the patron has no attributes currently set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 10:15:11 -05:00
cf3af15a47 Hiding patron attributes entry if not configured.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:50:55 -05:00
2cf0eeedb6 More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:23:33 -05:00
9ba1baec71 Hiding minimum password hint if there is no minimum password length set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:31 -05:00
378e06dacb Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:29 -05:00
df13aeee3b Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:05:07 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Galen Charlton
82f1cb2761 fix extra <td> introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:17:42 -05:00