Commit graph

141 commits

Author SHA1 Message Date
Kyle M Hall
f41971eadf Reverse Payment - Allows any payment to be 'undone' while retaining a record of said payment. Useful for accidental double-payments.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:23:33 -04:00
Michael Hafen
09e3308024 bug: chargelostitem() didn't unset onloan on the item record.
I don't think this is left set intentionally.

If an item is set lost and it's on loan it's marked returned, but it
wasn't set as not on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:01:24 -05:00
Ryan Higgins
49ffa55a2e Update longoverdue.pl cron job to manage setting lost values.
This patch deprecates the NoReturnSetLost system preference, which, as it
turns out, was not implemented anyway.  New longoverdue script allows one to
specify on the commandline system-wide delays for changing items to different
lost statuses, and optionally charge for the item.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-10 15:54:29 -05:00
Ryan Higgins
eeef609466 Remove 'Cash Refund' from manual invoice, as it calls a deprecated function. Change the code for 'forgiven' from 'F' to 'FOR', since 'F' is used for 'Fine' elsewhere in the code. Mark other subroutines as deprecated that utilize the accountoffsets table, since that functionality was lost somewhere in the 2.2 series, and half-using it breaks things.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:07 -05:00
ffbb7fb0d0 Fix for bug 2183, "Account tab needs spacing between description and stadard text" Please note that this is a band-aid for a larger issue, described in Bug 2188
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:52 -05:00
Joe Atzberger
f36b8fd59a Commented out fixaccounts (not used anywhere). Also improved getnextacctno.
You can test getnextacctno like:
	perl -e 'use C4::Accounts; print getnextacctno(33), "\n";'
where 33 is a borrowernumber out of the accountlines table.  Get that number like:
	mysql> select borrowernumber,accountno from accountlines LIMIT 100;

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:37 -05:00
Galen Charlton
90290c4551 bug 2006: do not crash when paying a lost item fine
Qualified call to MarkIssueReturned with 'C4::Circulation'.
It looks like there is still a subtle bug with exporting
subs between modules that use each other.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:52:55 -05:00
Galen Charlton
9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Chris Cormack
af585e3009 More work on the til reconciliation report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:49:19 -06:00
Chris Cormack
ca4b23e929 Work in progress, working on the til reconciliation report
More patches to come

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:49:16 -06:00
Joe Atzberger
534956bc31 Accounts.pm - BEGIN block VERSION and vars related to export.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:02:19 -06:00
Galen Charlton
35f8f65b41 item rework: replace direct SQL update of items
with ModItem calls

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:24:38 -06:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Joshua Ferraro
06d8e7d4cf chmod 644 on all modules
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 19:11:35 -05:00
Paul POULAIN
55ac115e61 fixes to fine management
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-14 21:32:45 -05:00
Joshua Ferraro
8ee881174f Merge branch 'master' of /usr/local/git/koha_base.git/ 2007-08-08 07:27:26 -05:00
Chris Cormack
852b7d5274 Perltidying
Signed-off-by: Chris Cormack <crc@arwen.metavore.com>
2007-08-03 16:39:30 -05:00
rangi
bf7eaca974 Fix for bug 1313, silent failure when entering manual invoice with invalid
itemnumber
2007-07-15 22:19:01 +00:00
rangi
e1353fb639 Fix for bug 1314 manual credits broken 2007-07-02 00:44:25 +00:00
tipaul
d6b7ca12b0 code convention for SQL 2007-04-23 14:06:18 +00:00
hdl
0b66bd800d Code Cleaning Members.
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
kados
0d7b552dec move Accounts2.pm to Accounts.pm 2007-03-09 23:30:17 +00:00
tipaul
61c133ca31 code cleaning : removing useless package (everything needed copied in Accounts2.pm) 2005-10-26 08:29:28 +00:00
tipaul
e82eca42c9 see mail on koha-devel : code cleaning on Search.pm + normalizing API + use of biblionumber everywhere (instead of bn, biblio, ...) 2005-09-22 10:01:45 +00:00
rangi
1e1929be43 Fixing a line that was throwing up warnings when running the script with -w 2005-05-14 22:20:17 +00:00
tipaul
b311b890d2 added param to checkaccount API 2004-05-03 09:04:49 +00:00
slef
928d76058a DBI call fix for bug 662 2003-12-15 16:18:45 +00:00
wolfpac444
c3c3f27ec7 *** empty log message *** 2003-02-19 01:33:52 +00:00
rangi
bc9b0aca44 Added a note that this module is slated to be removed 2002-12-07 04:38:56 +00:00
arensb
eff606ba56 Replaced expressions of the form "$x = $x <op> $y" with "$x <op>= $y".
Thus, $x = $x+2 becomes $x += 2, and so forth.
2002-10-13 11:32:14 +00:00
arensb
5c91d43a43 Added some FIXME comments. 2002-10-13 05:49:13 +00:00
arensb
fa873de1fd Added whitespace to make the POD work.
Simplified references.
2002-10-10 04:29:39 +00:00
arensb
2f9a3a5bec Removed trailing whitespace that was breaking the POD. 2002-10-09 15:25:03 +00:00
arensb
dbca39823f Merged with arensb-context branch: use C4::Context->dbh instead of
&C4Connect, and generally prefer C4::Context over C4::Database.
2002-10-05 09:44:27 +00:00
arensb
a26ac73061 Fixed missing bits in POD. 2002-09-23 13:49:46 +00:00
arensb
c09e821d8c Added POD. 2002-09-22 05:38:32 +00:00
tonnesen
1e67687742 Added copyright statement to all .pl and .pm files 2002-08-14 18:12:50 +00:00
tonnesen
6897cec04d Most of these merges are just removing unused parts of the perl modules. 2002-06-20 18:56:52 +00:00
rangi
d0374d0037 Initial revision 2000-12-19 23:45:51 +00:00