Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Kyle Hall	ebbee18822	Bug 25333: Change message transport type for Talking Tech from "phone" to "itiva" From its inception, phone notices via Talking Tech have not behaved like other notices. Instead of reading notices generated by Koha, the Talking Tech scripts largely generate their own notices. We would like to pave the way to having "generic" phone notices that can be processed by plugins to support arbitrary telephony vendors ( we will be targeting Twilio initially ). To that end, it seems sensible to begin by changing the messaage transport type for Talking Tech from 'phone' to 'itiva' to highlight its specificity and difference from standard message transports. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Test Talking Tech outbound script 5) Note no changes in functionality Signed-off-by: Christopher Zorn <Christofer.Zorn@ajaxlibrary.ca> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD amended patch: remove uneeded indentation change in sample_notices_message_transports.sql Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Martin Renvoize	692fb7e134	Bug 24159: (QA follow-up) Make terminology consistent This patch changes the new circulation rule that's introduced from useDaysMode to daysmode to improve consistency with other rule names. We also update the accessors and code using them to reflect the new term. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	71e235751f	Bug 24159: Set days_mode according to circ rules in 3 other places There are 3 other occurrences where the new circ rule can be used: * C4::Circulation::checkHighHolds * Koha::Hold->set_waiting * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl Test plan: * checkHighHolds Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration Setup things to hit a "high demand" alert with a shortened due date Check an item out => The due date must be recalculated depending on the circ rule useDaysMode. * set_waiting Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently a bug in the description of the syspref, see bug 22381 comment 19) Mark a hold waiting The expiration date should have been set depending on the value of the circ rule. * TalkingTech cronjob Cannot test this Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Andrew Isherwood	780f79ae1a	Bug 15260: Modify next/prev_open_day We require next_open_day & prev_open_day to be more flexible. We could create a separate sub, but that's not very DRY given that they'll do pretty much the same thing. So next_open_day becomes next_open_days and prev_open_day becomes prev_open_days and both functions accept an additional parameter which determines how many days they add or subtract. All calls of these two functions have been modified accordingly. Sponsored-by: Cheshire West and Chester Council Sponsored-by: Cheshire East Council Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martha Fuerst	3cb66af150	Bug 21180: Allow Talking Tech outbound script to limit based on patron home library branchcode A library system has requested the ability to limit which patrons are sent to Itivia for phone notices. Test Plan: 1) Enable phone notices for two patrons with overdues 2) Run the misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl with the new --patron-branchcode option 3) Note only the patron whose homebranch you specified is in the output file Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	6 years ago
Martin Renvoize	d2e189ca1c	Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Martin Renvoize	125de75517	Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Nick Clemens	12ed04eabb	Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Kyle M Hall	172f2e0e05	Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I did not test but changes make sense Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Kyle Hall	86678bbc26	Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	f7b11f38e8	Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	74e28c02f9	Bug 9004: Use Koha::Calendar instead of C4::Calendar This patch tries to make the code more readable using Koha::Calendar instead of deprecated C4::Calendar and Date::Calc Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Kyle Hall	dafbd180a0	Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Add holidays check Signed-off-by: Chris William <chrisw@pascolibraries.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	12 years ago
Kyle Hall	1cdc1ae3d6	Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Perltidy script. Signed-off-by: Chris William <chrisw@pascolibraries.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	12 years ago
Jonathan Druart	6c4415a873	Bug 9004: Use Koha::Calendar instead of C4::Calendar This patch tries to make the code more readable using Koha::Calendar instead of deprecated C4::Calendar and Date::Calc	8 years ago
Nick Clemens	fd4f2f88a6	Bug 9004: (QA followup) Fix pod	8 years ago
Kyle Hall	86015eefb4	Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Add holidays check Signed-off-by: Chris William <chrisw@pascolibraries.org>	12 years ago
Kyle Hall	af32e3a475	Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Perltidy script. Signed-off-by: Chris William <chrisw@pascolibraries.org>	12 years ago
Marc Véron	ef539cd035	Bug 14960: Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	6a06fc9b6c	Bug 11867: MTT: Manage _PHONE notices The _PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Jonathan Druart	abb3647d03	Bug 10845: (follow-up) fix message_transport_type parameter for Itiva cronjob The message_transport_type param should passed to GetPreparedLetter, not part of the "tables" parameter. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Jonathan Druart	777814a260	Bug 10845: Multi transport types for holds The HOLD_PRINT and HOLD_PHONE notices become useless. This patch modifies existing notices in order to group them into the main notice type 'HOLD', with any pre-existing print and phone templates in the appropriate places. Test plan: - Apply the patch and execute the update database entry. - Verify that your previous HOLD_PHONE and HOLD_PRINT are displayed when editing the HOLD notice (under phone and print). - Choose a patron and check SMS, email, phone for "Hold filled" (on the patron messaging preferences). - Place a hold. - Check the item in and confirm the hold. - If the patron has an email and a SMS number, 2 new messages are put into the message_queue table: 1 sms and 1 email. If the patron does not have 1 of them, there are 2 new messages: 1 sms/email and 1 print. If the user has neither of them, there is 1 new message: 1 print. - The generated messages should correspond with the notices defined, depending the message transport type. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Just noting that if email and SMS are disabled in the msg prefs, the user will not have a print message. And if the SMS driver fails, the record status in message_queue is 'failed', but staff may not be aware of that. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Koha user	025528a157	Bug 8606 - Talking Tech broken by Bug 7001 The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. This patch rectifies that situation. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>	12 years ago
Kyle Hall	1d53bd778b	Talking Tech Support - Phase I - Followup 3 - Follow PBP * Fixes violations of Perl Best Practices, where possible * perltidy both scripts http://bugs.koha-community.org/show_bug.cgi?id=4246 Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Ian Walls	d29efac4f3	Talking Tech Support - Phase I Implements support for Talking Tech I-tiva phone notification for OVERDUE, PREDUE and HOLD notifications. Overdues respect triggers as configured for the patron's branch. Predue and Holds notifications respect patron's messaging preference choices. A new column for phone notification is added if the TalkingTechItivaPhoneNotification system preference is turned on Record of phone messages being sent to patrons is added to the patron's Notices tab; notice of success or failure can be retrieved from I-tiva. See the TalkingTech.README for installation and set-up instructions. Aside from the control system preference, and the necessary changes to Messaging Preferences forms to make use of phone notifications, the bulk of the code resides in external cronjobs. TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. Actual transmission of the file must be handled by the system administrator. TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. Getting the file from I-tiva to Koha is the job of the system administrator, as well. Both scripts have a --help option with full documentation. The only necessary change to core Koha behavior is in C4::Letters::EnqueueLetter. The return value was changed from 0 or 1 (successful addition of letter to message_queue or not), to the actual insert ID of the letter. This was required by the outbound script to present a unique Transaction ID for the notice added to the patron's record (so a 'sent' or 'failed' status could be updated). Since the dbh and sth are not shared, and the last_insert_id() command is table-specific, this should be thread-safe. No changes are necessary to any parts of Koha, as all usage of EnqueueLetter currently ignores the return value. To Test: 1. Turn on TalkingTechItivaPhoneNotification system preference 2. Verify that 'phone' is now a valid notification option for patrons on both staff and OPAC side 3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt should succeed 4. Set up the patron for notices to triggers: a. include checked out items due in a range of days, including the value set up in their messaging preferences. b. place several holds, some in position, others waiting for pickup, others in transit. c. set the patron up to have overdues, overdue by a range of days that includes the delay values for the patrons branch and categorycode 5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE --type=OVERDUE --outfile=/tmp/talkingtechtest.csv The resulting talkingtechtest.csv file should include all the items due on X days (where X is the patrons' preference), and none of the ones due in other increments. Similarly, overdues messages should be added for each item due by a delay value as configured; overdues of other numbers of days should be ignore. Holds that are waiting pick up or in transit should have messages, those still pending should not. Messages should be added to the patron's notices tab for each issue sent. Verify these messages exist, and all Notices tokens are replaced with appropriate information. Repeat, this time with 4c making use of the default branch overdue triggers, instead of branch-specific triggers. To test the inbound script, create a CSV with rows in the format "<<Message_id>>","<<SUCCESS or FAIL>>" Message ID should correspond to the final column of the talkingtechtest.csv file (the transaction id) for the message. Primary Authorship: Ian Walls Additional modifications: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=4246 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested and in use in production by two public libraries : Middletown and Washoe. Both have given their sign off, but don't have git to actually sign off. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago

26 Commits (ebbee18822f73c8e8f2236b13a66ba653bebe03f)