Commit graph

8548 commits

Author SHA1 Message Date
922e8fc061 Fix for Bug 2120, "
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:56 -05:00
eb09aac059 Authorities detail page was missing toolbar, breadcrumbs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:53 -05:00
795d9d5605 Markup error caused layout problems.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:52 -05:00
dec7a7115d Structural changes to staff client main page to better handle layout changes with addition/subtraction of news and intranetmainuserblock markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:47 -05:00
bcca5c9584 Terminology correction: cancelled -> withdrawn. Also adding dateformat variable to new holds queue script to allow correct table sorting with metric dates.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:46 -05:00
5675b8d5e4 Adding breadcrumbs to advanced search screen to get us a Home link.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:45 -05:00
97becad914 Adding table sorter to holds queue report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:42 -05:00
bcc56e6827 Tweak to OPAC search bar to help prevent wrapping.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:10 -05:00
db2f86c61f Minor change to improve layout at lower resolutions.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:48 -05:00
bfcdfb7f45 Interface improvements to Holds Queue report and changes to the script provided by jmf
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:44 -05:00
ff96846978 Fix for Bug 2147, "Search Results aligned top on staff side."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:43 -05:00
62391ab1d7 Fix an encoding issue on circulation autocompletion
ysearch.pl returns a list of borrower details for circulation
autocomplete widget. Accented characters wasn't displayed
correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:08 -05:00
Paul POULAIN
b9ecd65610 fix for #1788 : Locations do not sort alphabetically by name in list on "Set" location
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:07 -05:00
Paul POULAIN
86e53a9f40 bugfixing batchupdateISBN.pl
pls, someone from MARC21 confirm.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:06 -05:00
Galen Charlton
171f7ed912 various bugfixes for MARC21 Z39.50 targets
[1] Added MARC-8 as an encoding choice on the target
    administration page.
[2] Fixed TMPL coding errors.
[3] Set the correct encoding (as it happens, 'MARC-8')
    for all of the English sample Z39.50 targets.

Documentation note: due to this patch and the ones from
Frederic, screenshots of the page for editing a Z39.50
target should be redone.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:05 -05:00
Galen Charlton
e3f473187e kohabug 2048 - improve zebraqueue_daemon performance
[1] Increase sleep interval between checks of zebraqueue
    from 0.01 seconds to 0.50.
[2] Batch up commits of changes to the zebraqueue table
[3] If the same record appears multiple times in the queue,
    handle only once.
[4] Properly postpone failures to process record deletes to
    avoid spinning.
[5] Correct how queue entries are marked done - avoid skipping
    an authority record update, e.g., if it has the same
    ID number as a bib that was updated.
[6] Added a FIXME about a possible later enhancement to
    batch up updates so that Zebra isn't told to commit
    after each record.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:04 -05:00
709619013d Allowing delete-biblio menu item to trigger javascript warning. Style now mimicsa disabled menu item. Addresses Bug 2135, "Cannot Delete MARC Records."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:52:04 -05:00
Joshua Ferraro
2ee27fb1cc Final update to holds queue work: adds link to holds queue
from circulation dashboard, creates new sysprefs, assigns
the sysprefs to the proper tab in sysprefs (Circulation),
updatedatabase changes to do the previous, and fixing one
redundent limit in the query for build_holds_queue.pl

Note: still need to address item-level holds
2008-05-20 12:36:40 -05:00
Joshua Ferraro
a9a4965277 Adds a cron script to be run periodically that populates
the tmp_holdsqueue table. This is an alternative holds
targeting workflow that is more suitable for multi-location
libraries than the default holds picklist report.

Note to documentation writers: this summary should be
added to any holds documentation as an overview of
the avaialable methods for holds fulfillment.

This alternative holds workflow assumes an
expectation that the system should target a specific
item for a given hold request, attempt to fulfill the
hold with that item, and if unable to fulfill, select
an available item at another location to fulfill the
hold.

This is quite different than the default Koha behavior
which uses a 'broadcast' method of hold fulfillment.

How it works:

This script weights available locations for holds based
on options specified in two system preferences:

StaticHoldsQueueWeight
	Allows the library to specify a list of library
	location codes -- if used alone, it will rank the
	list statically, selecting the top-ranking available
	location to be added to the picklist.

RandomizeHoldsQueueWeight
	If RandomizeHoldsQueueWeight and StaticHoldsQueueWeight
	are set, the list of library codes in the
	StaticHoldsQueueWeight syspref are randomized rather
	than statically ranked. If RandomizeHoldsQueueWeight
	alone is set, the list of all available library codes
	is used to randomize the weight.

If neither syspref is set, the list is statically
ranked according to how they are pulled out of the system
database.

NOTE: This has not yet been tested with item-level holds
2008-05-20 10:58:24 -05:00
Joshua Ferraro
725e822aed DB Update .086: adding new table tmp_holdsqueue,
used for reporting picklist for holds in multi-location
libraries. This is a temporary workaround to a longer-term
post-3.0 cleanup of the holds process.

Following this will be a cron job for managing the
holds picklist queue as well as a report for viewing
the list of items from circulation
2008-05-20 09:36:26 -05:00
Joshua Ferraro
bcd6262494 Fix for Bug 1955: Remove noOPACUserLogin system preference 2008-05-19 19:11:19 -05:00
Joshua Ferraro
c4287214c3 Fix for bug 1952: OPACUserCSS preference has incorrect description 2008-05-19 19:05:44 -05:00
Galen Charlton
0f8910e0f6 correct path to 404.pl in opac-details.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 16:07:10 -05:00
Galen Charlton
144378a198 kohabug 2141 - avoid carp on display of details of deleted bib
When displaying details of bib in staff interface, check
that bib actually exists and display 404 page if not.  Avoids
following fatal error:

Can't call method "field" on an undefined value at /home/gmc/koha/dev/C4/Biblio.pm line 944.

This situtation can arise when running Zebra; if a bib is deleted,
Zebra will not necessarily be reindexed instantly, allowing a link
from a search result list to point to a missing record.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 16:07:08 -05:00
Galen Charlton
35ff682f6f minor POD improvement
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 16:07:07 -05:00
Joe Atzberger
775c74f566 BUGFIX - pagination bar was not in template, so only the first 20 hits were
pagination bar was not in template, so only the first 20 hits were
 visible.  Probably it wasn't included because the script referenced a bogus base URL.
 Also debugified warn statement in script.  Note FIXME for bogus template reference.
 We probably don't need that template or the related selector lines for it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 16:00:39 -05:00
Joshua Ferraro
28731b7080 Adding RenewSerialAddsSuggestion syspref to Acquisitions tab 2008-05-19 15:27:21 -05:00
Galen Charlton
8645d38f41 test suite: allow skipping of expensive tests
Defined a function attribute for KohaTest and subclasses
called 'Expensive'.  When a test method has that attribute,
it is skipped unless the RUN_EXPENSIVE_TESTS environment
variable is true.

To mark a test method, expensive, do this:

sub test_foo : Tests(4) Expensive { ... }

To mark a whole class and its subclasses expensive,
define a SKIP_CLASS sub (with empty body) with the
Expensive attribute:

sub SKIP_CLASS : Expensive { }

Updated the t/Makefile so that 'make test' runs
nonexpensive tests, while 'make fulltest' runs both
cheap and expensive tests.

Marked KohaTest::Installer test class expensive.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:25:57 -05:00
a53aa294f7 CSS fix for Internet Explorer display problem caused by previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:12 -05:00
4662f0f3f9 Template restructuring to allow option of styling OPAC with fixed-width layout. This commit doesn't change the default OPAC appearance.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:11 -05:00
1ba0a05af6 Adding padding to <p> to improve some readability issues; Correcting terminology in the cart (shelf -> list); Minor punctuation change in results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:10 -05:00
ca9d876d79 A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:09 -05:00
c58f6e0077 Trying again to fix tab issues in Internet Explorer.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:08 -05:00
Joshua Ferraro
9758c7fc47 Minor updates to XSL display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:12:29 -05:00
Joshua Ferraro
50eec07c80 Enhancement Jacket Covers in Shelf Browser should link to bib record, not to source of image
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:12:24 -05:00
Joshua Ferraro
2a092b710b Fixing isbn regex to not match unless isbn is valid
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:12:18 -05:00
Joshua Ferraro
7c871821e1 Don't display Acquisitions and Serials links if the user
doesn't have permission to view them
2008-05-19 13:01:04 -05:00
Joshua Ferraro
d1ec348c9b Adding pipe (|) as delimitor option 2008-05-19 11:34:12 -05:00
Koha Production
5bc5fcbbbb Fix links for web resources to display a 'Click here to access online' when no label is specified (XSLT only). Note that on the results screen, the links now show up in place of the Availability: section
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 22:41:25 -05:00
Koha Production
a60c83d55d Fixing Literary Form: display for Sound records
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 22:41:12 -05:00
hcpl test
95c897bf55 Removing bib-level Call Number from display -- can be added to XSL based on library preferences if desired
Signed-off-by: Koha Production <koha-pro@koha-01.hclibrary.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 22:41:01 -05:00
Joshua Ferraro
13bddb5818 Fixing Amazon.com Similar Items and Editions features
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 20:37:18 -05:00
Joshua Ferraro
738cdbad89 Adding wrapping container around OpacMainUserBlock syspref 2008-05-17 18:49:26 -05:00
a3d111ae97 Fix bug in /admin/z3950servers.pl
Third attempt to correct a bug affecting this page.
Combo lists wasn't reflecting DB content in modification.
To Joshua: You have to apply patch 2 first (patch 1 isn't required)
since I applied this quick fix without rolling back to original state!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 18:45:38 -05:00
987c4e94b1 Fix bug in /admin/z3950servers.pl
Improve previous patch which was badly coded as pointed out by
Henri-Damien. <TMPL_IF> clauses were included in HTML tags:
it fails translator tool.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 18:45:37 -05:00
d2595211c8 Fix a bug in /admin/z3950servers.pl page
On /admin/z3950servers.pl page, modifying a z3950 host wasn't working
properly. Selected values in Syntax and Encoding combo boxes were hard
coded rather than selected based on record values.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 18:45:33 -05:00
Marc Chantreux
dd6344fa18 changing defaults for french system preferences.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:21:19 -05:00
Henri-Damien LAURENT
89fa713124 Bug Fixing : ModMember and memberentrygen.tmpl
Problem with ModMember : parameters were not passed safely
memberentrygen.tmpl deleted guarantorid for a children if step2 or step3 used fore edition.
Changeing TMPL_IF EXPR into TMPL_IF Name

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:21:09 -05:00
1740f374ee Altering CSS to make holding table on opac MARC view more compact. Adding "new" link to opac suggestions screen for display when there are no suggestions (Bug 2110 Can't place suggestion from my suggestions tab in OPAC)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:18:27 -05:00
d1fdb97122 Fix for problem introduced by previous attempt to fix Internet Explorer issues. Previous fix caused drop-down menu to appear behind circ search form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:18:27 -05:00