Commit graph

113 commits

Author SHA1 Message Date
Galen Charlton
ee4de2f652 various improvements to subscription editing
* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:57 -05:00
Henri-Damien LAURENT
af32ae0962 Adding and managing location in subscription
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:55 -05:00
Nahuel ANGELINETTI
3b1d91d04f (bug #3020) add a grace period to subscriptions
This patch modify the database to have a grace period which can be set. And is used to create automatically new waited issues with a
cronjob(which is in this patch), and set old issues to "late" status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:46:36 -05:00
Galen Charlton
70b7017eca fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:32:02 -05:00
Joe Atzberger
51a0e335d5 Bug 3157: IE compatibility for label display
Also fixed validation errors where label elements were "for" non-existant ids.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:53 -05:00
Joe Atzberger
b8d6ccf845 Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed.  Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected.  Go figure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 12:05:08 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Nahuel Angelinetti
4f2557e46e bug 2840: Delete a hidden tag that is not needed and create an error
The bug exists because for each table line, an hidden field was set, with subscriptionid, but it's not used by the script and
create a bug "Request-URI Too Large".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 11:16:36 -06:00
Nahuel ANGELINETTI
7fb039f6c0 (bug #2961) be xhtml valid
This little patch just fix the previous patch to be xhtml valid(onclick instead of onClick)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:25:53 -06:00
Nahuel ANGELINETTI
5397ab31dc (bug #2961) add a button to add manually the next issue
This patch add a button in "Serial Collection" to add manually the next issue. And improve the function GetNextExpected
to retrieve at least something.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:55 -06:00
Nahuel ANGELINETTI
a43c8408e4 (bug #2831) Add a variable, that create a js error, and make the script not working.
the variable added is numberpattern, and is get from the document.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:58:19 -06:00
Nahuel Angelinetti
e23ae31699 bug 2689: Fix the checked box "manual history" and fix the "null" value of serial next issue publication date
first part of this patch is the manual history must be checked if in database its checked.
Then, when you do not enter a value "Next issue publication date", a null value was set in the database, now, if empty, the  "first issue date" is set as "next issue".
And finally, We check that "manual history" is checked to show the "Subscription history" part. Actually its never shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:08:29 -06:00
Nahuel Angelinetti
7d327ff556 Missing ";" in javascript
This patch fix a missing ; in javascript, that open the renew popup. Instead it open it in the current window.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:55:56 -06:00
Ryan Higgins
f3f0e2576f Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:08:57 -06:00
0a33d4554b Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 13:34:36 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Ryan Higgins
efad22fd4d Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:13 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
d42a2a86a8 Spelling correction. Fixes Bug 2501.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:29:26 -05:00
Ryan Higgins
19781ab1b3 bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 16:56:25 -05:00
5794bde204 Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:49:06 -05:00
Paul POULAIN
80c8b5c149 bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.

This manage multiple errors on barcode and displays them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 08:15:29 -05:00
Ryan Higgins
0c66ac6702 Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously  was reporting nothing since the js was broken).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:31:24 -05:00
Ryan Higgins
8393fb0a3a Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )
Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction.  This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time).  Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:49 -05:00
Ryan Higgins
db87e7d738 Update serials planning javascript to properly deal with 3-level periodicity. ( Serials patch 2/3 )
Minor changes to dom object names and id's to allow for proper calculation of the
base planning table from the simplified table.
Prior to this patch, the base table was populated with the incorrect value, so patterns like
Vol{X} No{Y} Issue{Z} incremented the Vol value incorrectly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:39 -05:00
Ryan Higgins
44d1aa5eb0 Serials planning updates patch 1/3
This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible.  A 'show advanced pattern' button will display/hide the
base prediction table at any time.  A 'reset pattern' button is added.  The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 07:59:06 -05:00
30efc33dba Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:47 -05:00
85832f8524 A couple more corrections that should have been in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:40 -05:00
d73b577fa6 Fix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription-add.pl") and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:38 -05:00
Ryan Higgins
5353d35b7a Correct misspelling of 'recieve'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:26 -05:00
350b9dd3af Allowing people to search on all itemtypes when adding a serial subscription, workaround for the fact you cant limit by itemtype
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 20:02:13 -05:00
ac7c215be3 Markup corrections. You can't embed a <!-- TMPL_IF --> inside an HTML tag because it causes problems for the translation script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 14:05:53 -05:00
Joshua Ferraro
5f6af04ee1 nomenclature cleanup: s/Branch/Library/ s/Document Type/Item Type/ 2008-05-30 11:36:04 -05:00
5d980853b0 Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:24 -05:00
ca9d876d79 A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:09 -05:00
346d8d3679 Some fixes for bug Bug 2056, No Claim Letter Note Should Stand Out, and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:56:00 -05:00
Joshua Ferraro
d3675da9de Nomenclature cleanup for supplemental issues in serials 2008-04-22 20:06:37 -05:00
Joshua Ferraro
70c5aed218 Improving dialog for linking to a vendor, allow choice between
OK and Cancel for whether to link to a vendor rather than requiring
a vendor be added.
2008-04-22 19:53:14 -05:00
Joshua Ferraro
340dcb421e Nomenclature cleanup for subscription adding page 2008-04-22 19:43:34 -05:00
1c4e41939e Fix for Bug 2015 ("subscription-renew button is disabled"), other markup corrections; Removing unused popup css declaration from doc-head-close; removing unused popup include file.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:39:44 -05:00
Paul POULAIN
7ddb9c59d9 look change for 2 radio buttons
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:34:39 -05:00
paul
7be6d1f12b IMPROVEMENT : serialsadditems at subscription level (bump 071)
The patch update the DB by adding a row in the subscription table (serialsadditems), that is filled with the value of the syspref.
then, the syspref is deleted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:34:33 -05:00
Paul POULAIN
d5aa433155 /TMPL_ELSE is invalid, should be TMPL_ELSE
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-14 23:47:04 -05:00
Paul POULAIN
f5674f953a reintroducing the limit on itemtype when searching a biblio in subscription add
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:56 -05:00
Paul POULAIN
fa4cead909 reintroducing history manual modification feature
The history start date and enddate is also useful to modify manually for the same reason : your serial collection may be older than your Koha serial management.

This commit reintroduce the feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:52 -05:00
Galen Charlton
3675c7d987 typo fix: "recieve" => "receive"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:22 -05:00
bab8beb59a Updates to go along with jquery tabs plugin update
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-11 06:18:50 -05:00
Paul POULAIN
f5195492a5 (cosmetic) reducing subscription renew note textarea
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:27:37 -06:00
Ryan Higgins
dd3c971aaa Date format fix for serials irregularities.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 19:30:42 -06:00
Paul POULAIN
d92f4020dc replacing ' by " in javascript translatable strings
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:08:02 -06:00