Commit graph

108 commits

Author SHA1 Message Date
Henri-Damien LAURENT
e3a9d21d6e Improving and bug fixing admin/aqbudgets
Adding FormatData and FormatNumber in C4::Output
Using them
Adding duplication detection for budget periods
Factorizing some code
2009-09-30 11:30:30 +02:00
Henri-Damien LAURENT
efc8f69800 C4::Output adding getlanguagecookie + other enhancements
required for language stemming management
Adding also some filters for NSB NSE characters
Now, get_template can be used even when query->cookie not set

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:23 +02:00
Galen Charlton
a244ff6671 bug 2505: turn on warnings in seven modules
C4::XSLT
C4::VirtualShelves
C4::Review
C4::Output
C4::Boolean
C4::Charset
C4::Stats

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:16 -05:00
Galen Charlton
5375a71070 followup previous patch - remove disused $opacstylesheet
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 17:06:57 -05:00
Joe Atzberger
f35b144668 Pull the last OPAC-specific tmpl vars out of gettemplate.
These don't belong every template, only on OPAC:
~ opacstylesheet
~ opaccolorstylesheet
~ opacsmallimage

The latter 2 were already being populated in C4::Auth anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 17:03:13 -05:00
Joe Atzberger
70c6a9fdf3 Bug 3239 - Content-Script-Type and Content-Style-Type
This adds headers to define the default script and style languages.
Please note that this output isn't 100% canonical from CGI yet, but
that is due to a bug in CGI:
  http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3243

So either CGI will perfect it's output, or we can switch to using
HTTP::Headers.  The latter may be desirable anyway, since then we
would not need a CGI $query argument at all.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 08:05:48 -05:00
Pianohacker
b04f432857 New framework for AJAX services
This adds two new C4 modules, C4::Service and ::Output::JSONStream, and
makes important modifications to C4::Output. The first two are a basic
framework for JSON-based AJAX services and a simple JSON output wrapper,
respectively. C4::Output has been slightly refactored, with a new
function, output_with_http_headers, that supports different
content-types. output_html_with_http_headers still exists, and the three
pages affected by this change have been refactored to support it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-14 07:29:18 -05:00
8246a7dce8 Bugfix 3176 - Browser selected languages are not use by OPAC
This patch uses HTTP_ACCEPT_LANGUAGE web browser variable
to select OPAC available language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 09:13:24 -05:00
Galen Charlton
786a1aa36a bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:42 -05:00
Joe Atzberger
31ef440741 Bugfix pagination_bar to work with only one param/value pair.
A valid test of this patch is this command:
perl -MC4::Output -e 'print pagination_bar("my/script?query=foobar",5,2,"page"),"\n";'

The output before patch begins:
	&nbsp;<a href="my/script?query=foobar?page=1" rel="start">&lt;&lt;</a>
and AFTER patch:
	&nbsp;<a href="my/script?query=foobar&amp;page=1" rel="start">&lt;&lt;</a>

The double "?" in QUERY_STRING are now avoided.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 09:11:44 -05:00
Joshua Ferraro
81ecfe67ce Fix for 2308: On-line help editing doesn't work 2008-07-08 15:22:28 -05:00
Joshua Ferraro
cff92c0fd6 Fix for 2187: http_accept_language feature not working 2008-06-20 14:09:12 -05:00
Paul POULAIN
e1261ab7df BUGFIX: the language list was calculated on opaclanguage, whatever the interface
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:46:10 -05:00
Galen Charlton
8fc6b927df kohabug 2078 - send correct Content-type for search feeds
OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.

As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type.  If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:54 -05:00
Joe Atzberger
6d3a490c04 is_ajax function added. pagination_bar now intelligent: it has
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 08:52:02 -05:00
Joe Atzberger
ec5c3d0ee2 Add AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template::Pro.
The loop_context_vars will be very useful in display.  They are:
__first__, __last__, __inner__, __odd__, __counter__.
Note: apparently __even__ does not exist, so instead use something like:
<!-- TMPL_UNLESS NAME="__odd__" -->

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:41 -05:00
Henri-Damien LAURENT
f59c9706a4 change in yuipath management 1/2 Noupdatedatabase.pl
now yuipath is added in C4::Output and uses themelang
In my opinion, all the general variables that are used in output should get in C4::Output (since there is theme lang computed.)
rather than in C4::Auth

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 15:46:35 -05:00
Chris
dc72b21a3f Removing extra warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:37 -06:00
Chris
7c7dbf9a68 Bugfix for Bug 1790: Theme defaults to prog if other themes fail.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 07:51:04 -06:00
Chris Cormack
b47e7a9be4 Fix for bug 1790 Thanks to Chris Nighswonger
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:10 -06:00
Paul POULAIN
eee09f39da correctly caluclate default template path for OPAC
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-22 07:20:24 -06:00
Henri-Damien LAURENT
260ec03378 BugFixing : default language was always en. Not a problem for dev purpose but would be on installation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-17 21:01:03 -06:00
Joe Atzberger
c82636958d Output.pm - silence unconditional warn.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:45:25 -06:00
Joshua Ferraro
802b13e5f5 fix for 1754; fixing I18N BiDi, improvements to handling of language
TODO: clean up the OPAC similarly

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 08:32:48 -06:00
Galen Charlton
5290ec5596 test suite cleanup
Many of the tests were failing or putting warnings
because a valid systempreferences table is
usaully absent by the time 'make test' is run.

Fortunately, only a few modules try to invoke
C4::Context->preference during module initialization,
so added to the test suite override_context_prefs.pm,
which replaces preference() with a sub to return
testing values for three variables: 'dateformat',
'marcflavour', and 'LibraryName'.

Also fixed bug in t/Boolean.t

With this patch and the patch to move the DB-dependent
tests off to the side for the moment, 'make test'
now runs cleanly, at least on Debian.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 14:08:02 -06:00
Joe Atzberger
1e4c053076 Output.pm - integrity checks prevent warns, author should judge FIXME's
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 14:04:45 -06:00
Joe Atzberger
5b426c140c Output.pm - BEGIN block VERSION and vars related to export.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:02:37 -06:00
Joshua Ferraro
2baca29e58 WARNING: BIG I18N PATCH, you must import the subtag_registry.sql after this upgrade to benefit from the new features ... if you don't everything will work as before.
bugfixing I18N language selection from staff and OPAC, adding BiDi
support

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:51 -06:00
Joshua Ferraro
c7f22f84ad additional updates to language support
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:47 -06:00
Joshua Ferraro
678b52a2f2 refactoring changelanguage, better var names, etc.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:38 -06:00
Joshua Ferraro
11e3820094 removing warns from Output.pm
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:22 -06:00
Joshua Ferraro
922386c6a0 fix the 'current language' change language display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:16 -06:00
Joshua Ferraro
fe1b2e4882 template improvement: fall back on english if the template file doesn't exist
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:12 -06:00
Joshua Ferraro
6072ccc28e Improvements to handling language subtags
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:10 -06:00
Joshua Ferraro
17d42eba70 remove warn
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:58:56 -06:00
Joshua Ferraro
a929fc2dae adding bi-directional support to the OPAC based on the language
selected (Hebrew and Arabic currently set)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:58:46 -06:00
Joshua Ferraro
b0dc874d4b Switching Languages.pm to EXPORT_OK -- don't export
all functions by default. Adding languages_loop to all
templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:58:41 -06:00
Paul POULAIN
db7407c4a2 Deal with opac template reordering
the modules/ directory is now in opac as well as in intranet.
non english languages were unreachable without this patch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 17:07:00 -06:00
Joshua Ferraro
cff6c94106 fix for bug 1373 (add no-cache headers)
After experiencing this for myself I've decided to just
add them by default, if we want to wrap in a syspref at some
point we can.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:27:36 -06:00
79fe8faaee Change to allow scripts to find OPAC templates in their new location
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 21:35:44 -06:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Paul POULAIN
763f613b0c determining language for OPAC correctly, until new template structure has been ported to OPAC
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-04 05:44:15 -05:00
Paul POULAIN
c85892117e determining theme/language path
until the modules/structure has been ported to OPAC, this quick hack make the theme/language determination work for both OPAC & intranet

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-03 17:03:39 -05:00
Paul POULAIN
352093e0da BUGFIX : get available language and theme
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-03 03:37:36 -05:00
Joshua Ferraro
27d45375d0 moving calendar to lib
Output.pm: sanatizing variable names
ran  perl -pi~ -e 's/\/includes\/calendar\//\/lib\/calendar\//' * in every staff template dir

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-23 21:30:49 -05:00
toins
a3135df486 really minor change : POD fixing, indentation & some compilation warn removing. 2007-07-26 15:18:46 +00:00
toins
b41c3087b6 missing comma :-/ 2007-06-20 09:45:09 +00:00
toins
d4fbf8c49a writing charset explicitly. 2007-06-19 15:14:08 +00:00
tipaul
23427c51b9 some fixes (and only fixes) 2007-06-15 13:44:44 +00:00
tipaul
6f276facc8 removing guessencoding, hard-coding utf-8 2007-06-05 08:53:19 +00:00