Commit graph

1836 commits

Author SHA1 Message Date
ef612e5667 Providing options for adding to order when existing record search has failed.
I've duplicated the "Add to Order" block on the search results page to display after a user has searched for an existing record to add to an order. This block is displayed whether or not results were found on the assumption that a non-empty result set may not contain the desired result. Changes to neworderbiblio.pl allow supplier name to appear in breadcrumb nav.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:09:29 -06:00
f4fcd9e35a Fix for Bug 2700, Keeping Data When Adding Multiple Items
When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-05 16:37:07 -06:00
Galen Charlton
ca7ae0ab41 remove TMPL_IF EXPR in member.tmpl
Quells following error message in Apache log:

EXPR:at pos 8: non-initialized variable overdues,
referer: http://example.edu/cgi-bin/koha/members/members-home.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 15:53:07 -06:00
Galen Charlton
330edb157f followup to Mason's labels patch
* fix XHTML errors
* fix problems with paging through results list

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 15:35:08 -06:00
Mason James
990e315471 The current searching in labels is a bit minimal, and current only does keyword searching.
there is some old 2.2 code for more complete labels-searching, thats been commented out

ive logged a 'bug' for this - 2777

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2777

this fix...
  - enables the index-searching functionality
  - adds date-ranges
  - uses the numSearchResults syspref, not a hardcoded '20'
  - rewrote old 2.2 page-num code, (didnt work for 3.x)
  - some indent and whitepages tidys.
  - unused 2.2 search-code removed.

Mason

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 11:15:44 -06:00
96d0ea56df Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:44:02 -06:00
Joe Atzberger
5af1eb2061 Remove "toggle" from template, use loop_context_vars __odd__ instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:53:26 -06:00
Stan Brinkerhoff
7989a831db Removing ':' from table headers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:52:44 -06:00
Nahuel ANGELINETTI
61ebf9160f (bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set
This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:46:11 -06:00
John Beppu
7b683cf583 bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:00 -06:00
7a9658cddc Improvements to offline circ report (linking to title and patron records), and moving English strings from the script into the template to allow translation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-22 17:24:34 -06:00
Galen Charlton
a3136e22bf bug 2799: followup 2
* fix TMPL_IF embedded in HTML tag
* convert a remaining <TMPL_VAR> to a comment

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:26 -06:00
Galen Charlton
0f47a7db16 bug 2799: followup
Various fixes to meet coding standards, template
design, and basic functionality:

* (bug 2505) turned on warnings
* use correct loop names when populating
  $template
* put all TMPL_FOO in HTML comments
* assign UseBranchTransferLimits to circulation tab
* change template to use "library" instead of "branch"
* use standard YUI scripting for toolbar buttons
* add new script to admin menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:16 -06:00
Kyle Hall
9cf0472903 Added 'Branch Transfer Limits' Feature requested by Geauga County Library System.
Added syspref to updatedatabase.

Updated kohastructure.sql with the limits table.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:02 -06:00
Jesse Weaver
06d2a720ae bug 2867 [1/2]: Move basic editing to main system preferences screen
This allows the user to edit system preferences from the main system
preferences screen, rather than having to dig down into each
preference.

[This patch includes some modifications by Galen Charlton
 to fix XHTML validation errors and a couple errors that
 would crop up under warnings.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:47:00 -06:00
Nahuel Angelinetti
7238585c60 bug 2841: add an hidden field with booksellerid
The bug throw because the booksellerid is not in the request, and the newordersuggestion.pl need this one to import
it in a new order.
So I just added an hidden input in the search form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 10:15:31 -06:00
Nahuel ANGELINETTI
a43c8408e4 (bug #2831) Add a variable, that create a js error, and make the script not working.
the variable added is numberpattern, and is get from the document.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:58:19 -06:00
Nahuel Angelinetti
7588809b0d bug 2829: add a plugin for 010$a field and 210$c
This plugin use the 'ISBN' field(010$a) to search the "publishercode"(editor) and set it in as 210$c.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:52:46 -06:00
Nahuel Angelinetti
e23ae31699 bug 2689: Fix the checked box "manual history" and fix the "null" value of serial next issue publication date
first part of this patch is the manual history must be checked if in database its checked.
Then, when you do not enter a value "Next issue publication date", a null value was set in the database, now, if empty, the  "first issue date" is set as "next issue".
And finally, We check that "manual history" is checked to show the "Subscription history" part. Actually its never shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:08:29 -06:00
Nahuel Angelinetti
7d327ff556 Missing ";" in javascript
This patch fix a missing ; in javascript, that open the renew popup. Instead it open it in the current window.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:55:56 -06:00
Nahuel Angelinetti
3ad66441c8 (bug #2853) fix an error in returned string
this patch delete the last char of the returned string, that is not conform to unimarc, only one blankchar must be at the end of
the leader string.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:39:50 -06:00
Galen Charlton
ce8e70c6c6 bug 2505: turned on warnings for suggestion/acceptorreject.pl
Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:27:55 -06:00
Jesse Weaver
c9a50403e5 bug 2848 [1/2]: Send notifications to patrons when hold is received
This adds notification code to Reserves.pm to send notifications through email
or SMS to patrons when their hold is filled. It does not send the letter
directly, but instead uses EnqueueLetter. Also, it relies on
EnhancedPatronMessaging being on and the hold notification being turned on for
the specific patron through the 'Messaging' tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:51:12 -06:00
41db97255c Corrections and tweaks to recent lists fixes.
Corrected an instance where <!-- TMPL_IF --> was embedded inside an HTML tag (conflicts with translation script). Modified styling of confirm button to match existing interface convention.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:24:25 -06:00
Nahuel Angelinetti
e0bbb9d7e7 Delete all calls to thesaurus_popup.pl, and no more used plugins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:31:46 -06:00
Joe Atzberger
5532f6652b Bug 2801 and other cleanup.
In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.

Resend: typo fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:29:57 -06:00
Galen Charlton
b47e2b1544 bug 2531 followup
* & -> &amp; in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
  button-bg.png for confirm button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:13:08 -06:00
Allen Reinmeyer
25eb36f21f Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 08:33:59 -06:00
Ryan Higgins
53a0ed93db bug 2787 : Fix Global Due date
This patch also lightly refactors the conditional structure wrapping the
call to AddItem, renaming a couple variables to remove double-negatives and
abstruse logic.  If SpecifyDueDate is ON, then the input box is used to pass
GlobalDueDate, allowing modification by circ staff, resulting in a default
'sticky' due date of the global due date in that mode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 07:22:18 -06:00
Jesse Weaver
b883e6cd7f fix for bug 2447: yuipath variable not getting passed to help pages
This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:51 -06:00
Ryan Higgins
f3f0e2576f Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:08:57 -06:00
Galen Charlton
cfd2f829d3 bug 2802 followup: remove another reference to "branches"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:51:27 -06:00
ccad2f8cf0 Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:28 -06:00
Michael Hafen
db73b67f03 add isbn to cataloging search results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:16 -06:00
Nahuel Angelinetti
a41acfe435 Do not show the language chooser
This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 10:29:28 -06:00
9cb231a63e Removing some unused stuff from print stylesheet, hiding Koha logo from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 16:31:12 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
John Beppu
9f782076db bug 2563: could not input into marc 008, fields 7-10 and 11-14
You actually *could* input data into those fields, but it wasn't
immediately obvious, because the field size was "4" and the
value was "    ".  You couldn't type anything in until you
backspaced over the spaces that were there by default.

UPDATE 2008-11-05:  Make absolutely sure that those values
are 4 chars long (via JavaScript)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:24 -06:00
c9a00b8b47 Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:37:46 -06:00
36e384adc7 Adding javascript to let user click table cell to check containing checkbox.
This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:31:08 -06:00
Joe Atzberger
83dedaebc2 Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:14:49 -06:00
f04792b3a4 Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:58 -05:00
895b2052f2 Terminology and spelling corrections. Fixes Bug 2724.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:53 -05:00
f0fc788a28 Spelling correction: catalogue -> catalog. Fixes Bug 2730.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:28 -05:00
Michael Hafen
12b216c77d Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 16:29:56 -05:00
bc297e0b72 Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 16:01:09 -05:00
Jesse Weaver
b8d8a0ec5a fix for bug 2543: report output by tabulation a bit too literal
This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 11:44:28 -05:00
Galen Charlton
c0536b1ed6 followup 5 to renewal limit override
With removal of content_hidden CSS class from
the circ templates, undoing change to staff-global.css

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:11 -05:00
Galen Charlton
2186eae294 followup 4 to renewal limit override
* use style="display: none" instead of content_hidden
* fix JavaScript so that actions that check/uncheck
  items for a renew or return do not affect
  the override renewal limit checkbox

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:04 -05:00
Galen Charlton
7fa4fd7a55 followup 3 to to renewal limit override
style="display: none" suffices to have a span
be hidden initially; content_hidden is not necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:02 -05:00