Commit graph

262 commits

Author SHA1 Message Date
Chris Cormack
f0bf2fea25 Fix for bug 1400, some variables not being passed to the branch transfers
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:49:59 -06:00
Chris Cormack
b9b77bcb60 Still a work in progress, pendingreserves.pl is quite broken
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:49:24 -06:00
Joe Atzberger
ef902ea85f circ/stats.pl - debugify warnings
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:19:22 -06:00
Joe Atzberger
ee1a241479 pendingreserves.pl - debugify warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:19:09 -06:00
Galen Charlton
9d4d8897b2 item rework: various changes
* Move CheckItemPreSave to C4::Items (from C4::Biblio)
* Modified C4::Biblio::AddBiblioAndItems to use appropriate
   internal routines from C4::Items
* Moved GetItemnumberFromBarcode to C4::Items
* Removed duplicate C4::Biblio::_koha_new_items
* Removed disused C4::Biblio::MARCitemchange

Currently AddBiblioAndItems is a special routine that
uses private subs from both C4::Biblio and C4::Items.
This needs to be refactored.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:25:42 -06:00
Galen Charlton
c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Chris Cormack
052861306b Fix to redirect the user ot the select branch page if they try to use
circulation without a branch set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 20:03:08 -06:00
Chris Cormack
48b4d54408 Fix for bug 1515
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 20:51:22 -06:00
Chris Cormack
ddd0140ef1 Fix for bug 1626, whitespace stripped from barcodes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:30 -06:00
Chris Cormack
bcc60a1117 Fix for bug 1552, fix ordering of issued items
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:27 -06:00
Chris Cormack
39fad89745 Fix for bug 1253 borrowers names sorted case sensitivly in circulation.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 12:07:59 -06:00
Chris Cormack
358ec9c6c3 Fix for 1582, if independent branches is on, you cant return to
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:24:37 -06:00
Ryan Higgins
a9d03af6dc adding 'exempt fine on return' option.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:22:45 -06:00
Chris Cormack
7d6282e513 Fix for 1704, now if autoitemreturns is off you get a dialogue warning a
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:22:00 -06:00
Chris Cormack
55a525cb3a Fix for bug 1703
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 17:53:43 -06:00
Galen Charlton
26fa7bf58d use syspref date format for manual due date
NOTE: will fail if user manages to enter date
in wrong format.  This is not a change from before
this patch, but is pointed out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:14:41 -06:00
Galen Charlton
af0b208bdf use standard template var for DHTML date format
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:13:59 -06:00
Chris Cormack
6cfe88b7b2 Fix for bug 1427
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-19 18:55:20 -06:00
0e675ef820 - Changes to the way patron renewals are handled. Circulation page now offers 'renew' link alongside warning about patron expiration (as in dev_week), using the new setstatus script.
- Member pages now use member toolbar include instead of circ one
- setstatus.pl now uses 3.0's patron renewal function
- Adding missing item-bullet.gif (Bug 1659)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 19:24:49 -06:00
Chris Cormack
ea7cbfff43 Fix for bug 1648, specifying a due date resulted in a blank due date
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 08:19:55 -06:00
Chris Cormack
0bc686acf9 Fix so ysearch.pl uses utf-8
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-05 15:34:34 -06:00
Joshua Ferraro
5227d242fd cleanup of circ/ dir changes to Dates ... missing format_date 2007-12-04 18:47:03 -06:00
Joshua Ferraro
e428929bff adding format_date to 'use C4::Date' 2007-12-04 18:29:18 -06:00
Joe Atzberger
82b8c496fd circ subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:12 -06:00
266b59cf65 Moving "Check Out" from the action toolbar to the view menu
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:56:22 -06:00
f46ebf69a0 Passing "adultborrower" variable to the template so that "Add Child" button can be displayed in the toolbar when appropriate. Fixes Bug 1510.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 15:06:29 -06:00
c5e80b7b86 Attempting to pretty up confirmations and messages in returns; Adding some variables to the template output; Fixing layout in circulation.tmpl for patrons without messages; Minor correction to OPAC css.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:58:06 -06:00
Galen Charlton
958b5a097c new C4::Auth::get_session for single place to get CGI::Session object
Refactoring to provide single place to get CGI::Session ojbject;
fixes bug for DB storage method other than 'mysql'.

This refactoring is also part of the patch series for
handling large input files for staging and processing
MARC records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:43:26 -06:00
Ryan Higgins
cb1ec158c0 Adding calendar widget to circulation/stickyduedate
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:27:25 -06:00
Ryan Higgins
88e913046a fixing pending reserves to use dates specified
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-16 07:12:08 -06:00
Joshua Ferraro
687c83370e fixes to date handling 2007-11-13 20:41:46 -06:00
Chris Cormack
d8d27ab898 Missing AND in the SQL in pendingreserves.pl only if independentbranches was turned on
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 18:05:07 -06:00
Ryan Higgins
9c2d58a470 update item-at-wrong-branch error message to show homebranch.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:45 -06:00
Chris Cormack
5342904792 We were calling get biblioitemdata when we should have been calling get bibliodata
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 11:19:26 -06:00
Chris Cormack
5fa4703ee0 Fix for 404 error when clicking on a reserve in circulations
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-12 17:40:23 -06:00
Ryan Higgins
3967fa9c79 further mods to change from ccode to itype at item-level itypes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:40:20 -06:00
Chris Cormack
24af640015 Rest of the fix for 1402
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:05:20 -06:00
Joshua Ferraro
58d3b163d0 merge mason's fix to circulation 2007-11-06 06:19:17 -06:00
Mason James
275e3eb8b1 undeclared @issued_itemtypes_count_loop;
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-06 06:18:15 -06:00
Joshua Ferraro
9e8dc6b021 adding back my @issued_itemtypes_count_loop; 2007-11-05 08:41:11 -06:00
Ryan Higgins
371efb047b adding item-level itypes: based on systempref: item-level_itypes, we use items.ccode as the circ code rather than biblioitems.itemtype. This is initial commit -- still requiring interface changes basic loanlength, maxissues should be by ccode now.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:37:53 -06:00
Ryan Higgins
d6eea9c622 fixed redefined itemtype_count variable .
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:37:38 -06:00
b453d173ae Standardizing information shown in sidebar when patron-related pages are displayed (making sure address, phone, email variables are available to all templates). Adding tabs to account-related pages as means of section navigation.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:31:32 -06:00
4a9745dbb0 More interface changes for circulation: Further tweaking of circ warning dialog, formatting patron selection form, adding 'focus' class to patron selection select list.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:31:02 -06:00
Ryan Higgins
dac69bc799 Couple of minor changes to staff client view on patron.
item-level_itypes still need display changes in both opac and staff.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:27:59 -06:00
Chris Cormack
ff179bb1d4 Fix for bug 1518
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:21:46 -05:00
Paul POULAIN
8b7085a8ab removing useless code
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:38 -05:00
b6e604c80e patch
See attached file. Thanks.

>From 1c3021f31675193ad2e9b91a95191f9ae0caeff2 Mon Sep 17 00:00:00 2001
From: Frederic Demians <f.demians@tamil.fr>
Date: Wed, 24 Oct 2007 11:50:08 +0200
Subject: [PATCH] Borrower name autocompletion improvement
 Autocompletion is selected by syspref directly in circ-search.inc.
 This way it could be activated elsewhere just by adding CircAutocompl
 param into page using circ-search.inc.
 Done for example in circ/branchtransfers.pl. Must be done in all other
 circ/*.pl pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:01:41 -05:00
Chris Cormack
53be8065d1 Fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:58:14 -05:00
Chris Cormack
c3c520b385 Working on a fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 21:55:57 -05:00