Commit graph

70 commits

Author SHA1 Message Date
b5eab7c20b Bug 8018: (followup) make the default more explicit
This patch:
- Makes the new subfield tab show maxlength=9999 as default (instead of
  empty-then-zero).
- Updates the help to make exlpicit that 0 or empty defaults to 9999.
- Assumes all the subfields created with maxlength=0 inadvertedly are
  meant to mean "no limit" and hence update the database to reflect
  that.

To test (this patch and Pablo's):
- Edit a MARC framework, edit some field's subfields.
- Use the 'New' tab to create a new subfield (choose an unused letter).
- See in "More constrains" that the "Max length" field is empty. Leave
  it as-is.
- Save the changes (the new subfield).
- Edit the field again, verify that "Max length" is 0.
- Try tu use the framework and the the field/subfield just created
  > FAIL
- Apply the patches, upgrade
- Try to use the framework/field/subfield > SUCCESS (0 was converted to
  9999)
- Repeat from the begining, "Max length" should show 9999 on the new
  subfield tab.
- Leave it empty, it is saved as 9999.

Edit: small typo

Sponsored-by: Universidad Nacionald de Cordoba
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and tests in t and xt.
Tested:
- deleting an existing subfield
- adding a new subfield with new default 9999
- editing the new subfield, changing value to 8888
- deleting new subfield
- adding new subfield, using 8888 as length

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-12-27 00:34:50 +00:00
Pablo Bianchi
1ebbf40ecc Bug 8018: MARC framework max subfield length should default to 9999
The default value for the marc_subfield_structure.maxlenght is 9999
in the DB. Currently the template passes an empty value which is casted to
0 by the CGI.

This simple patch validates the input and converts to the default (9999)
if not defined or 0.

Another approach could be changing the 9999 default and/or treating 0 as
'no-limit'.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works by defaulting 0 or "" to 9999.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-12-27 00:34:02 +00:00
Paul Poulain
07a55421e2 Bug 8379 don't close dbh
don't close the DBH handler, because under plack this cause a lot of problem
and in CGI mode, closing the dbh handler is useless

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
2012-10-05 11:46:00 +02:00
Srdjan
c1e5462db1 bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2012-07-23 10:43:59 +02:00
Katrin Fischer
22b6705b4f Bug 3413: Checkboxes for new subfields not saving correctly
The bug was in the numbering of the fields and subfields in the form.
The form elements for the 'new subfield' got the same numbered names and ids as
the form elements for the second subfield. (example: repeatable1)
The patch fixes the numbering to continue to the new subfield.

To test:
- Create some new subfields and check all checkbox fields save correctly
  (mandatory, repeatable, is url)
- Check that other subfields' checkboxes are not changed
- Check existing subfields and newly created subfields can be edited

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-05-07 22:23:49 +02:00
Juan Romay Sieira
020c095377 Bug 7263 - Determine maximum length of some fields or subfields when cataloguing a biblio or an item.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-03-26 10:51:22 +02:00
Salvador Zaragoza Rubio
042f89e939 Bug 6475 - Edit it's not possible in subfield "0" in MARC framework
When trying to modify the subfield "0" on a field in the
MARC subfield structure admin -> Tag xxx Subfield Constraints,
the boolean condition on liblibrarian fails for the initial "0" value.
Modified condition to allow the value "0"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2011-11-18 22:32:35 +01:00
Christopher Hall
f03000f50f Bug 5462: modified intranet scripts to match templates
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2011-02-03 09:57:24 +00:00
88a15a71d5 Fix for Bug 5240 - next link hidden on edit subfields
This patch removes the pagination altogether, displaying
everything on one page. It also moves some HTML out of the
script and into the template.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-22 13:43:20 +13:00
Donovan Jones
bce3e2e619 Bug 2505 - Add commented use warnings where missing in the admin/ directory 2010-04-21 20:20:11 +12:00
Lars Wirzenius
2c67656108 Fix FSF address in directory admin/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:50 -04:00
Garry Collum
7d4a962a18 Bug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl
Removed toggle variable from marc_subfields_structure.pl and marc_subfields_structure.tmpl.  Used template __odd__ variable instead.

Corrected a typo in the highlight class definition in .tmpl.

Corrected a readability issue with the description when deleting a subfield in .tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:38 -05:00
Paul Poulain
0fdb397ec6 removing useless line (use Data::Dumper)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:02 -05:00
John Beppu
286c3c3a9e bug 1546 - replacing REPLACE statements
replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:00:02 -05:00
Nahuel ANGELINETTI
1bb9f76e66 (bug #3057) mandatory subfield edition
modify the "name" of mandatory input field.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:17:37 -05:00
05c5500e4f Fixing markup errors, tweaking show/hide javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:07 -05:00
Jesse Weaver
98406923bb fix for bug 2282: Biblio framework subfields...
This fixes the tabs plugin's view of the % subfield by adding another template var called urisubfieldcode that is "pct" when the subfieldcode is "%".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:25 -05:00
Ryan Higgins
c64f8f8bac Add cn_source to authorised values dropdown in marc structure editor.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:17:55 -05:00
Ryan Higgins
1aa00400c4 Fix pagination error on subfield structure editor
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:22 -05:00
Galen Charlton
16b4aa6382 bug 1717: (framework editor) don't display subfield $0 as "New"
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 01:57:48 -06:00
Joe Atzberger
acfd4dd20b admin subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:15 -06:00
Paul POULAIN
134f50e6d2 #1492 MARC subfields structure: can't switch to tab with label "@"
replacing the @ by _ in the template, wich is valid.

I also have changed a little the behaviour : the New button appears only
for >010 fields (<10 have only the data, no real subfield)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:41:08 -05:00
4662ba0958 Refining navigation in MARC Framework pages; Fixing unfinished YUI-based toolbar on catalogue detail page: functional now, with some tweaks yet to be done.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 19:12:33 -05:00
a453c16632 Finishing cleanup of Admin templates: - Corrected markup generated by scripts. - Added standard or custom resident search form on all pages. - Add breadcrumb navigation to all pages
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-14 17:47:17 -05:00
tipaul
8b29900d24 bugfix on adding a subfield 2007-06-26 09:17:56 +00:00
tipaul
577a7bf094 some (minor, functionnaly speaking) bugfixes 2007-06-05 08:54:17 +00:00
tipaul
e1d907c688 various bugfixes on parameters modules + adding default NoZebraIndexes systempreference if it's empty 2007-05-04 16:24:08 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
toins
3e764c663f - adding default value in marc_subfield_structure.
- now marc_subfields_structure displays subfields in tab view.
2007-03-19 18:35:12 +00:00
tipaul
f8e9fb6445 rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
tgarip1957
fe59c6c516 New framework handling. New koha_attr table for mapping MARC to koha 2006-09-01 22:03:00 +00:00
toins
cc9524a875 Head & rel_2_2 merged 2006-07-04 14:36:51 +00:00
hdl
b810e2d71e changing parameters template directory to admin 2006-02-24 11:15:01 +00:00
tipaul
93ff09d081 merging 2.2 branch with head. Sorry for not making it before, many many commits done here 2005-03-01 13:40:35 +00:00
oleonard
2f6a47427c Adding id attributes to script-generated form fields to allow more flexible interface (tying label for attribute to input's id allows label to be clicked to transfer focus to the form field) 2005-02-14 22:07:59 +00:00
oleonard
01a2fe5e79 Switching from building 'edit' link in the script to building it in the template itself by creating edit_tagfield and edit_frameworkcode variables to pass to the template.
A change to the template is also required.
2005-02-10 22:42:56 +00:00
oleonard
ae427924d7 Changing table row color toggle so that color values can be specified in the template instead of the script (requires update to template) 2005-01-20 18:48:12 +00:00
tipaul
b02dc10f6e * partial support of the "linkage" MARC feature : if you enter a "link" on a MARC subfield, the magnifying glass won't search on the field, but on the linked field. I agree it's a partial support. Will be improved, but I need to investigate MARC21 & UNIMARC diffs on this topic. 2005-01-03 12:56:30 +00:00
tipaul
a6ce64229e bugfix for CVS installations of Koha & modperl 2004-12-08 10:41:38 +00:00
tipaul
56ab39361e fixes from A. Tarallo, for mod_perl compliance 2004-12-03 16:50:39 +00:00
tipaul
726c0565e8 various bugfixes 2004-08-18 16:05:14 +00:00
doxulting
0c3e1dd11b Some minor debug changes 2004-07-30 13:55:58 +00:00
doxulting
b1136e8813 Authorities 2004-07-08 10:15:59 +00:00
doxulting
4a8ae6a31b New stuff for authorities 2004-07-06 13:15:11 +00:00
doxulting
cb6e87e420 debugged framework interface. Frameworks for ensmp are ready too 2004-06-25 09:17:49 +00:00
tipaul
5cf0a788a1 MARC authority management (continued) 2004-06-10 08:58:34 +00:00
tipaul
af996a21e8 * frameworks and itemtypes are independant
* bugfixes in authority types & framework management (mainly deletion)
2004-06-03 10:01:28 +00:00
tipaul
59ae3d902f hidding hidden & isurl constraints into MARC subfield structure 2004-05-28 08:24:14 +00:00
tipaul
88e67b8d3e framework management : 1 MARC framework for each itemtype 2004-05-18 15:22:10 +00:00