Commit graph

331 commits

Author SHA1 Message Date
Galen Charlton
ac08aef495 added another check to MARC framework test
Check verifies that all subfields for each tag
are assigned to the same editor tab (or are ignored).

This situation can lead to data corruption, because
if an incoming MARC record has a field whose subfields
are assigned to different tabs, the first time that
record is saved in the bib editor, the field
will be split into multiple versions, each containing
the subfields assigned to a given tab.

Errors identified by this test known
in the MARC21 frameworks - I'm working on a patch to
correct those.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-21 11:18:19 -05:00
Galen Charlton
579a227228 kohabug 2022 - fixed fine and issuing rules editors
Because of the way that the older fine and issuing
rule editors generate the HTML form, if a branch code,
patron category code, or item type code happened to have a
'-' or '.', the HTML form would not be parsed properly, thus
adding an implicit (rather than explicit) limit on the
characters allowed in one of those codes.

This fix removes this limitation by Base64-encoding the codes
when constructing the names for the <input> elements.

Two functions are added to C4::Koha:

  str_to_base64() - UTF-8 string to Base64
  base64_to_str() - reverse

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-21 11:17:52 -05:00
Galen Charlton
83f8e22aec renamed CheckSpecificUserPermissions to GranularPermissions
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:45 -05:00
Galen Charlton
cafaa26b45 granular permissions - created DB tables
First big commit in a project to add more granular
staff user permissions to Koha.

* Created two new database tables

permissions:
  stores a list of defined permissions; each
  permission is to be interpreted as a child
  of a top-level permission defined in the
  existing user flags.  For example, Tools (bit 13)
  now has a separate sub-permission for each
  individual tool.

  The columns are
    module_bit  = FK referencing userflags.bit
    code        = code, e.g., import_patrons
    description = e.g., "Import patron data"

user_permissions:
  stores a list of the specific permissions that
  a staff user actually has.   For example, if
  staff user 123 has only the 'import_patrons' subpermission
  of 'Tools' (module_bit = 13), that would be represented
  by having (123, 13, 'import_patrons' in user_permissions.

  user_permissions and borrowers.flags are now interpreted
  as follows (assuming the CheckSpecificUserPermissions syspref
  is ON):
    * If the appropriate bit (e.g., bit 13 for Tools) is set
      in borrowers.flags, the staff user can access all
      Tools functions.  There should be no rows in user_permissions
      for that staff user and userflag bit combination.
    * If the bit is not set in borrowers.flags, but one or
      more rows are present in user_permissions for that
      staff user and bit combination, the staff user can
      access the specified sub-functions.
    * If the bit is not set in borrower.flags and there are
      no rows in user_permissions for that staff user and
      bit combination, the user cannot access any of the functions.

  Note that this means that if a staff user can access all
  functions for a module (because the bit is set in borrowers.flags),
  the user will automatically be able access any new subfunctions
  added to permissions by a database update.

  The columns are:
    borrowernumber = FK referencing borrowers.borrowernumber
    module_bit, code = FK referencing permissions

* Added a new system preference, CheckSpecificUserPermissions

If this system preference is ON, staff users can be assigned
specific permissions which will be respected during
authorization checks.  If this system preference is OFF, the
current userflags semantics will continue to apply.

* Defined sub-permissions for Tools.  The list of specific
  tools permissions is now:

  edit_news          Write news for the OPAC and staff interfaces
  label_creator      Create printable labels and barcodes from catalog and patron data
  edit_calendar      Define days when the library is closed
  moderate_comments  Moderate patron comments
  edit_notices       Define notices
  edit_notice_status_triggers     Set notice/status triggers for overdue items
  view_system_logs   Browse the system logs
  inventory          Perform inventory (stocktaking) of your catalogue
  stage_marc_import  Stage MARC records into the reservoir
  manage_staged_marc Manage staged MARC records, including completing and reversing imports
  export_catalog     Export bibliographic and holdings data
  import_patrons     Import patron data
  delete_anonymize_patrons    Delete old borrowers and anonymize circulation history (deletes borrower reading history)
  batch_upload_patron_images  Upload patron images in batch or one at a time
  schedule_tasks     Schedule tasks to run

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:08 -05:00
Paul POULAIN
b2c04e7c20 bugfix for saving issuing rules
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:50 -05:00
Ryan Higgins
8d51042a29 Add Logging module 'SYSTEMPREFERENCE', log adds, mods & deletes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-07 15:59:51 -05:00
Chris Nighswonger
b179819d08 Correcting a small case-sensitive bug.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:45:47 -05:00
Joshua Ferraro
56a2dddc77 adding OPACShelfbrowse to OPAC tab
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:41:25 -05:00
Joshua Ferraro
4c92790fc0 IMPORTANT: Upgrading to Amazon.com Associates Web Service 4.0
As announced this past February, Amazon.com will no longer be
accepting web services requests to Amazon E-Commerce Service
(Amazon ECS) version 3.0 beginning on March 31, 2008.

This patch upgrades to Amazon.com's Associates Web Service 4.0
for the following components:

1. Amazon.com Locale support for: Canada, Germany, France, Japan,
   UK, and US (see the new syspref called AmazonLocale)
2. Jacket Covers
3. Editorial Reviews
4. Customer Reviews
5. Amazon.com Similar Items

The following changes MUST be made to continue using Amazon.com
content:

1. Delete the system preference: AmazonDevKey (AmazonDevKeys used
   with AmazonECS 3.0 are no longer valid)
2. Add the system preferences: AmazonLocale, AWSAccessKeyID
   NOTE: steps 1, 2 are done by the web installer
3. Verify your AWSAccessKeyID:
   You may already have an Access Key ID. You can access your Access
   Key ID by going to http://aws.amazon.com, pointing to Your Web
   Services Account, then clicking View Access Key Identifiers.
   Depending on when you signed up for ECS 3.0, you may need to
   re-register for an AWS account, which includes an Access Key ID.
4. Enter your AWSAccessKeyID in the Koha syspref called
AWSAccessKeyID

For complete details on the changes in Amazon.com Associates Web
Service 4.0, and the migration process, please see: http://tinyurl.com/ysorqy

Other changes with this patch:
 * added $tabsysprefs{PatronsPerPage}="Patrons";
 * Moved OPAC Features to OPAC in sysprefs
 * removed experimental OPACXISBNAmazonSimilarItems and XISBNAmazonSimilarItems features

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-16 12:27:55 -05:00
0f8c4b1bd8 Fix a bug preventing existing tag modification in MARC Framework
It wasn't possible to edit an existing tag. The program was idenfifying
tag modification as a tag creation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-08 11:19:04 -06:00
Chris Nighswonger
de04ff255d Fixing broken call to getitemtypeimagesrcfromurl
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-27 09:02:55 -06:00
Paul POULAIN
90b69c9e40 OAI-PMH second try
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-27 09:02:20 -06:00
Pianohacker
947add3ff8 Added combined, line-wise smart-rules script for defining issuingrules.
Also added template for "prog" set, and modified admin-home and -menu accordingly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-22 21:49:10 -06:00
Ryan Higgins
0f91ed3010 Prevent default framework from being inadvertently deleted.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 19:30:42 -06:00
Henri-Damien LAURENT
9bd7908cda INNER JOIN was too much restrictive for migrated libraries.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 15:31:16 -06:00
Joshua Ferraro
5bb6d117c5 handling multiple languages gracefully in sysprefs, allow the user to enable specific languages (and language groups)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:20:12 -06:00
Henri-Damien LAURENT
1391105a7c Bug Fixing : Could not add new undefined tag if searchfield>0
For instance, search for tag 290
cannot find.
Click on addTag
Save
Then wouldnot add tag 290 because used UPDATE.
Now, if tag is not found then Add tag is done.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:19 -06:00
39e12f17a0 Fix a bug in authorised values admin
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:31 -06:00
Chris Cormack
8252e698e9 Making the images show at admin/itemtype.spl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-29 07:58:48 -06:00
Henri-Damien LAURENT
f91a41970d Adding OpacHighlightedWords system preference
Disable or Enable the display of query terms in the biblio.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:15 -06:00
Chris Cormack
51d791514f Removing replace statement as per bug 1546
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:13 -06:00
b5aaa74011 Fix bug #1789 part 1
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:30:58 -06:00
Chris Cormack
6e239bf5a4 Shifting HomeOrHoldingBranch to the circulation tab
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:24:31 -06:00
Paul POULAIN
2f6a24640c Adding OpacRenewalAllowed systempref (bump to 047)
to let the library decide wheter their patrons can or can't renew checked-out items directly from their account.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:47:52 -06:00
Joe Atzberger
cc564d5c80 itemtypes.pl - partial revisions, incl. replacement of invalid META Refresh calls
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:45:40 -06:00
Joshua Ferraro
3d4147042a adding a few missing sysprefs
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 21:06:29 -06:00
Chris Cormack
ffd3a01119 More replace statements, this time admin/printers.pl
Bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 20:09:55 -06:00
Chris Cormack
904dbd04f6 Removing replace from stopwords.pl
More bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 20:09:54 -06:00
Chris Cormack
e0674c8309 Whoops fixing the update call, had params round the wrong way
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 20:09:54 -06:00
Chris Cormack
0f64d6ade7 Removing replace from admin/roadtype.pl
Bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 20:09:53 -06:00
Chris Cormack
26f83ae708 Killing more replace statements, bug 1546
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 20:09:52 -06:00
Chris Cormack
40851ea4cc Removing replace sql from admin/letter.pl as per bug 1546
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 19:23:48 -06:00
Henri-Damien LAURENT
b5a1060788 Improving encoding Support for z3950 clients.
Adding encoding for z3950 server information.
Uses Text::Iconv for conversion (ISO6937 and ISO_5428 and ISO5427)
For ISO 5426 (ANSEL or MARC-8) new char_decode5426 based on marc4j tool.

Not Tested on LOC or any USMARC z3950 source. But tested OK on BNF and SUDOC.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 19:23:30 -06:00
Galen Charlton
16b4aa6382 bug 1717: (framework editor) don't display subfield $0 as "New"
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 01:57:48 -06:00
Joshua Ferraro
6072ccc28e Improvements to handling language subtags
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:10 -06:00
Joe Atzberger
5e78bc9a07 currency expansion - symbol and timestamp. PLEASE VERIFY SQL edit. Should be equivalent to: ALTER TABLE currency ADD symbol varchar(5) default NULL, ADD timestamp timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP;
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:21:28 -06:00
Ryan Higgins
91c8797505 Allow Library select on new bookfund and term update.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:00 -06:00
Joe Atzberger
c7e0b196a2 systempreferences - remove dateformat from admin tab
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-31 16:26:00 -06:00
Chris Cormack
bcc60a1117 Fix for bug 1552, fix ordering of issued items
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:27 -06:00
Joshua Ferraro
1299d6b60c Bugfixing Systempreferences:
* fix to bug in version 3.00.00.038 update (bad SQL)
    * putting finesCalendar and CircControl in Circulation tab in
systempreferences
    * changing default for IndependantBranches to 0
    * removing ' from integers
    * fix canreservefromotherbranches nomenclature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-29 08:24:03 -06:00
Joshua Ferraro
4426fb52fc improving visual display of sysprefs, re-organizing
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 22:13:08 -06:00
5b2f5dd3f4 Minor correction to template markup and change to script to allow for more clickable <label>s.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 14:26:40 -06:00
9d23361f24 Even more applying standard dialog styles to confirmation messages. Also fixing alternating table row colors in stopwords.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 07:34:00 -06:00
905c5de9c8 Fixing some markup issues and alternating table row colors.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-18 16:40:05 -06:00
Ryan Higgins
f4811762d0 cleanup in memberentry,categories.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 08:19:07 -06:00
Henri-Damien LAURENT
111044b7a1 Bug Fixing : Authorised values could not be edited
If id provided and authorised value exists,
then change it and get back to authorised_value page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 10:51:16 -06:00
Paul POULAIN
066bb793f0 Adding default hardcoded authorised values list + some comment on them
Even on an empty setup, the user will know which auth values he can filled

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:10:08 -06:00
Joshua Ferraro
1ff189e59b cleanup of admin/ after Dates integration 2007-12-04 19:10:59 -06:00
Joe Atzberger
acfd4dd20b admin subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:15 -06:00
Galen Charlton
1077ff6b08 bug 1570: return to same tab if cancelling preference edit
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:20 -06:00