Commit graph

161 commits

Author SHA1 Message Date
Galen Charlton
49bccd5308 XHTML correction - readonly attribute can contain only "readonly"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-21 11:17:32 -05:00
Henri-Damien LAURENT
79d6243333 Bug Fix : Blocker 2017
disabled values are not passed to CGI.
So that if you disable entry, values and subfield codes are mixed up.
I changed disabled=tru to readonly and it fixes the bug.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:55 -05:00
Chris Nighswonger
9b47b82a77 Porting SimpleSearch return changes to all code calling it.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:45 -05:00
Paul POULAIN
91fca4a9ab BiblioAddsAuthorities improvement/fix
this commit restore a better behaviour :
- if ON : the librarian can enter manually an authority-linked marc field. and if it does not exist in the authorities file, it will be created automatically
- if OFF : the authority must exist in the authority file, and the librarian can't enter if manually in the MARC editor

This patch just deals with the OFF case (the ON was already here). With OFF the behaviour is now the same as in 2.2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:55:08 -05:00
Andrew Moore
5c51edc653 bug 1890: fixing calls to C4::Search::SimpleSearch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:23 -05:00
Ryan Higgins
d878a92b3d Add MARC preview to Z39.50 search.
Also, add title string to MARC editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 19:25:51 -05:00
Ryan Higgins
d032a81cb7 Add z39.50 search form distinct from MARC editor
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 19:25:48 -05:00
Galen Charlton
9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Galen Charlton
86e4cdf54b use 'F' or 'W', not 'f' or 'w' when using reserves.found
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:24 -05:00
Galen Charlton
eec7b58efa bug 1893: add jump link to reservoir search results
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-27 09:02:52 -06:00
Chris Nighswonger
ff026f1076 Adding another barcode autogeneration sequence to barcode.pl - bumped ver to 054
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-16 11:29:13 -06:00
Galen Charlton
6412604238 fix XHTML validation errors in addbiblio.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 16:35:23 -06:00
Chris Nighswonger
cd45f7b4c0 Changed behavior of barcode.pl plugin to generate barcode onClick of the ... button
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 06:02:40 -06:00
Galen Charlton
60a98d258a IMPORTANT - refactor MARC character set handling
* IsStringUTF8ish - determine if scalar contains a string in UTF8
* MarcToUTF8Record - convert MARC blob or MARC::Record to UTF8
* SetMarcUnicodeFlag - set appropriate MARC21 or UNIMARC field to
  indicate that record is in UTF-8.

Design points of this module include:

* No dependencies on other C4 modules, making it easier to add
  more test cases
* All character conversion code in one place
* Single entry point for doing a character conversion on a
  MARC record
* Capture of errors and warnings produced by Text::Iconv
  and MARC::Charset
* Start of support for guessing the source character set of
  a MARC record.

Several functions were moved from other scripts
or modules to C4::Charset:

* C4::Koha->FixEncoding (expanded and renamed
  MarcToUTF8Record)
* C4::Koha->char_decode5426
* fMARC8ToUTF8 from bulkmarcimport.pl (renamed
  _marc_marc8_to_utf8)

Several batch jobs were adjusted to use MarcToUTF8Record instead of
FixEncoding.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:56 -06:00
Henri-Damien LAURENT
1978babc9f Bug Fixing : Encoding in Z3950 searches
encoding is now defaulted to MARC8
encoding is now supported for USMARC and UNIMARC flavours.
Adding Encoding field to updatedatabase.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:07 -06:00
Chris Cormack
513990edd1 Fix for bug 1560
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:30:59 -06:00
Henri-Damien LAURENT
0001764f34 Displaying AuthorisedValues for items linked with authorised_value lists.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-15 15:33:05 -06:00
Henri-Damien LAURENT
80683fad47 adding encoding management to z3950
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 19:23:00 -06:00
Chris Cormack
97034354ce Switching debug back off ... whoops
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 16:13:22 -06:00
Chris Cormack
7da7c2f63c Changing z3950 search in cataloguing to use the name rather than the host
when listing z3950 servers to search

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 16:13:00 -06:00
Galen Charlton
8c60e82605 fixed variable masking warnings found by perl -w
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:23:59 -06:00
Galen Charlton
7ed543b8a7 item rework: moved GetMarcItem
Moved this function from an exported function in
C4::Biblio to a public but unexported function
in C4::Items.  Added comment noting that this
is used only by additem.pl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:56 -06:00
Galen Charlton
c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Chris Cormack
e02347ec23 Fix for bug 1319, can no longer delete an item with a waiting reserve on it
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:59:05 -06:00
Joshua Ferraro
dd50153f00 moving some files and deleting cataloguing/updateitem.pl, the _real_ updateitem.pl is in catalogue/
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 12:09:52 -06:00
Galen Charlton
02f7b83406 MARC21 authorities: fixed 008 value builder
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-29 06:53:50 -06:00
Galen Charlton
b733a5baa8 MARC21 authorities: fixed leader value builder
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-29 06:53:46 -06:00
Galen Charlton
2175ab7b7e cataloging plugins: enable access from authorities
Allow plugins to be be launched from authorities
editor as well as bib editor, without duplicating
plugin_launcher.pl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-29 06:53:44 -06:00
Ryan Higgins
74a76e539d Fix fatal error on authority search when biblioaddauthority syspref is set.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-28 12:42:01 -06:00
Joshua Ferraro
da8a4ca991 BIG COMMIT: minimal fix to authorities search
This is a minimal fix -- pname authorities work propertly, but nothing
else has been tested yet

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 20:23:16 -06:00
Paul POULAIN
713940d920 BiblioAddAuthorities : adding "" in search term, in case there is a ()
+ improving some tests
+ removing some comments

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-13 18:25:50 -06:00
Chris Nighswonger
f64dbb239f Adding LCCN to z2950 searches: Part 2
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-13 17:27:00 -06:00
Chris Nighswonger
0c558d1c97 Adding LCCN to z2950 searches
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-13 17:23:50 -06:00
5d640ddbb2 Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-12 08:05:38 -06:00
Joe Atzberger
fe00a94164 cataloge subdir (and cataloguing) - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:11 -06:00
7732454bf7 Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl).
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:56:24 -06:00
Joshua Ferraro
60f37d1aff adding back CDATA for validation 2007-12-04 17:25:47 -06:00
Joshua Ferraro
75a2023bd6 fixing dateaccessioned plugin 2007-12-04 13:44:31 -06:00
Galen Charlton
1dd1934221 fix minor XHTML validation issues
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 09:50:03 -06:00
Paul POULAIN
2c64e7e099 bugfix : don't show previously entered values again after saving an item
it's confusing and useless

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-17 15:03:57 -06:00
Galen Charlton
fa480ea4f3 various authorities fixes
* improve generation of summaries for MARC21 authorities
* fix search syntax for link to display bibs linked to a given authority
* in addbiblio.pl's BiblioAddAuthorities, check all headings, not just the first of each tag

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-12 18:32:22 -06:00
394d67e506 Fixing zebra-striping of z3950 search results, YUI-ing z3950 search button, tweaking layout of z3950 search popup
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:21:49 -06:00
Henri-Damien LAURENT
7e1862a2e2 BiblioAddsAuthority : First version.
This links to existing heading exactly matched.
Result search must be unique.
Do nothing if multiple result.
Automaticaly Adds authority if heading donot match.
(there should be a special status for that kind of authority)
(We should look into Rejected forms before adding).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:20:53 -06:00
Paul POULAIN
778c61adec oups, too many parenthesis
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:20:22 -06:00
Paul POULAIN
7da4fd00b9 patenthesis at wrong place in javascript
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:36:05 -06:00
Henri-Damien LAURENT
2835ee1bf2 call to plugins didnot work.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:25:42 -06:00
Paul POULAIN
289e8f445e DO NOT return if SimpleSearch give no result, we need to check reservoir too
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:32:03 -05:00
Paul POULAIN
317736360b fix related #1340 (z3950 search for quick cataloguing)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-30 17:44:21 -05:00
Galen Charlton
d37919eab9 improved import batches part 2 -- replace use of marc_breeding
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:05:25 -05:00
Galen Charlton
b5ba60e726 fix another parentheses problem
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:58:10 -05:00