Commit graph

3931 commits

Author SHA1 Message Date
2cf0eeedb6 More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:23:33 -05:00
0d3410d072 Another correction to eliminate left column from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:44:05 -05:00
Michael Hafen
5e963f0fc3 More Consistant terminoligy in stage-marc-import.tmpl
Changes 'Notes about this file' to 'Comments about this file'.  It's
'Comments' in the manage-marc-import.tmpl file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:33:52 -05:00
9ba1baec71 Hiding minimum password hint if there is no minimum password length set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:31 -05:00
378e06dacb Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:29 -05:00
96c29c707f Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:18:17 -05:00
df13aeee3b Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:05:07 -05:00
Michael Hafen
6de2f89e97 bug: sticky due date isn't stick if there is a question about an issue
the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 20:57:35 -05:00
5c8d22924d Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:55:15 -05:00
paul
bd23670eaf BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:51:42 -05:00
Michael Hafen
5170e31ea3 bugfix: Add a message to circulation.pl if item is restricted
Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:29:20 -05:00
cf56684c68 Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:08:20 -05:00
13fca44836 Adding progress bar and some other visual enhancements to file upload interactions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 11:58:21 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Galen Charlton
c7a3b4ede9 bug 2608: let offline circ processing work in background
If an offline circulation file is large, process_koc.pl
could time out before processing all of the transactions.

To prevent this, the processing can now be run in the
background, with an AJAX loop to check the job's
status.

As a consequence of the patch, the UI for uploading offline circ files has
changed slightly.  One must select a file, click the "upload file" button, then
click the "process offline circulation file" button.

Also removed the now-superfluous upload_koc.pl, added the warnings pragma,
and fixed a typo in the template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:22 -05:00
Ryan Higgins
efad22fd4d Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:13 -05:00
Jesse Weaver
852f75bba6 fix for bug 2556: Overlaying records sometimes creates new record
This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:35:44 -05:00
db7daf7586 Corrections to fix javascript error in Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:31:59 -05:00
1d54a98aa8 Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:25:38 -05:00
e3fe31b50b Change missing from previous commit re:Bug 2600.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:12:37 -05:00
e71028b354 Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:11:55 -05:00
4ed113b230 Refining keyboard shortcuts javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:08:06 -05:00
62b550a0be Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:03:39 -05:00
Galen Charlton
6133a06e96 bug 2596: remove URL escaping added by previous patch
If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:59:08 -05:00
ebc305bddf Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:50:19 -05:00
Danny Bouman
738ac4b492 bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:42:28 -05:00
58deb4ed0c Can't escape title variable as HTML because of search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:36:16 -05:00
0dcd876e6a Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:23:54 -05:00
Galen Charlton
82f1cb2761 fix extra <td> introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:17:42 -05:00
5e64df73f0 Correction to previous commit, removing debugging.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:01:28 -05:00
093a7b424a Formatting itemtype icon section with tabs to match authorized value interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:01:21 -05:00
Joe Atzberger
c70165ca6c Remove double conditional, fix one FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:08 -05:00
7b2e4ebce2 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:02 -05:00
Galen Charlton
f05a732195 bug 2585: fix search links for names (XSLT OPAC display)
Fix malformed OPAC search syntax that caused this bug:

When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work.  When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:52:55 -05:00
Jesse Weaver
5d8a285b81 fix for bug 2577: Cannot delete patron in IE
Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:45 -05:00
Joe Atzberger
37a33c5041 Remove unnecessary EXPR.
There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:42 -05:00
Galen Charlton
13f858bdc2 HTML fixes for matching-rules.tmpl
* maxnorms, maxoffset => maxlength
* no escape attribute in <input> elements

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:39 -05:00
Joe Atzberger
691b400bc9 HTML validation adjustments to about.pl
Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:34 -05:00
Joe Atzberger
3a2f776875 Validation fix, include required "type" in link tag.
This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 18:19:06 -05:00
05c5500e4f Fixing markup errors, tweaking show/hide javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:07 -05:00
b43c829027 More markup corrections for better validation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:05 -05:00
5714dc3fb5 Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:21:03 -05:00
Danny Bouman
83b8cfb1ad bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:48:22 -05:00
Galen Charlton
85a883ef28 fixing permission 2008-09-02 16:34:41 -05:00
Michael Hafen
cc2cffdee9 change link to moredetail.pl. In other places it's called with itemnumber=
Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:34:14 -05:00
Michael Hafen
9891a955e0 Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:53 -05:00
Michael Hafen
0e3302e78b Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:51 -05:00
Henri-Damien LAURENT
365520159f modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:24:29 -05:00
8a6125532c Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:00:30 -05:00
ba4c13a559 Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:55:54 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
Michael Hafen
0543a9633c If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:38:16 -05:00
79819e0b24 Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:35:35 -05:00
fe04cf015e Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:39:03 -05:00
61e8d4f1c8 Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:30:48 -05:00
d42a2a86a8 Spelling correction. Fixes Bug 2501.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:29:26 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Jesse Weaver
a4ee974e04 fix for bug 1101: Renew All for the OPAC
This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:50:04 -05:00
Joe Atzberger
225e115a85 issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:43 -05:00
Jesse Weaver
e957b3d3c7 fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
This patch changes the template slighly so that these two system preferences do not conflict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:23 -05:00
Jesse Weaver
c77969022b fix for bug 2477: Improve Speed of the Shelf Browser
This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:49:49 -05:00
Vincent Danjean
5879ead901 Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:54 -05:00
Galen Charlton
98dc396b9b bug 2503: fix minor XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 19:27:48 -05:00
Kyle Hall
38cf1fd318 Integrated version of the Koha Offline Circulation file uploader. It needs some testing and cleanup, but it works.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 17:05:24 -05:00
Ryan Higgins
19781ab1b3 bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 16:56:25 -05:00
Joe Atzberger
6e53a31357 Bug #2429, bad HTML from unclosed <head>.
Also some cleanup of opac-showmarc script including removing bogus
dependencies (DBI, CGI methods).  Should consider using C4::XSLT if
applicable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-19 13:40:18 -05:00
092e474389 Fixing a couple of minor markup issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-19 13:40:11 -05:00
Galen Charlton
dee5f4945b bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title

As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.

This patch includes the final component of the fix
for bug 2331.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:58 -05:00
Jesse Weaver
c6e2bcf67d Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:43 -05:00
Galen Charlton
26469d87a2 bug 2520: don't change item-level requests to bib-level
Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.

As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.

Documentation note: new screenshot of list of requests for
a bib in the staff interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:28 -05:00
Chris Nighswonger
6eac5c7b1b kohabug 2507 Fixing labels search to indicate keyword rather than title search
Documentation may require an updated screen shot

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-13 16:35:21 -05:00
Joe Atzberger
18ced6629d masthead - realign terminology for Tag Cloud
Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...".  AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-13 16:09:37 -05:00
Joshua Ferraro
cee096edba Adding some missing folks to the About page 2008-08-10 15:52:49 -05:00
Joshua Ferraro
e219c6c4cf Reverting an earlier change to overdue.pl (still broken) and
fixing a translation problem with borrowers_stats.ptmpl:

xgettext.pl: Warning: borrowers_stats.tmpl: line 28: SGML "closed start tag" notation: <p<!-- TMPL_IF NAME="debug"--> class="debug"<
2008-08-10 06:45:50 -05:00
Ryan Higgins
29d0c646f7 Final cleanup of labels for 3.0
This patch adds the callnum_split and text_justify options to the templates,
fixes bad javascript to switch between 'formatstring' and fixed-field means of specifying labels content,
fixes csv output when fixed-fields specifiers are used, and adds some help text for the formatstring case.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-10 06:19:00 -05:00
Ryan Higgins
e3fa9f2d5f Prevent borrower import from overwriting data that it shouldn't, and polish off a couple error conditions.
When an imported patron matches an existing one, keep data in the original record unless our import file
includes that column.  Also, check for branch & categorycodes, and produce error if invalid.  Finally,
auto-calculate expiry date if not given.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-09 19:07:07 -05:00
Joshua Ferraro
8f4f59a5bb 2433: Cannot apply manual credits with an item number
This patch changes the behavior so that you can enter in
a barcode instead of an itemnumber for the manual credit
and invoice screens. Also, the borrower's account page now
displays a link back to the item record if an item was
linked to the charge
2008-08-09 12:56:04 -05:00
Joshua Ferraro
13789969b0 2482: Default Letter on Notice Triggers Causes Error
Changing 'Default' to 'No notice' as per solution
suggested in bug report
2008-08-09 08:08:11 -05:00
Chris Nighswonger
386aefb44c kohabug 2463 & 2464 Removing unlinked fields from label-edit-layout.pl
This patch removes unlinked fields from the 'Choose Order Of Text Fields to Print'
option on label-edit-layout.pl

It also adds code to make the 'Itemtype' field respect the item-level_itypes syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-09 08:04:57 -05:00
Joshua Ferraro
4673e1cc9b Resolves problem where duplicate blank barcodes threw errors
form now only checks for duplication when the barcode is non-empty
2008-08-08 15:15:23 -05:00
Galen Charlton
bddafff54a bug 2496: add 'edit' link to authority search results
When search for an authority record from the bib
record editor, a new link is added to each
authority result to edit the authority record.  This
allows a cataloger to do the following:

1. Start editing a bib record
2. Click on the '...' to select an authorized heading
   for an authority-controlled field.
3. Look at the results in the pop-up window and
   see that an authority record needs correction.
4. Click on the 'edit authority' link.  This allows
   the authority to be revised.  Note that this
   takes place in the popup window, not the originally
   bib editing window.
5. Save the authority record, then close the popup
   window and redo the heading search.

For various reasons, this not a perfect workflow; this
patch is designed to satisfy an immediate requirement
but needs to be reworked in 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:35:09 -05:00
72622336a3 Link correction (affected only non-js users).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:11:53 -05:00
Ryan Higgins
133fcbd1c1 Add help text indicating that one should not use stopwords with Zebra.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:11:52 -05:00
d4ca58e80a Adding "New Item" menu option. Jumps to anchor for Add Item form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 11:56:51 -05:00
8a7a709fb3 Changing tabindex="-1" to tabindex="0". Fixes 2493.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:37 -05:00
476137841e Minor markup correction.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:36 -05:00
Chris Nighswonger
860f1f70e5 kohabug 2458 Disallowing non-SELECT SQL in reports module
This patch enforces SELECT-only SQL in the reports module.
It introduces code to check SQL in two places. The first is
when a save is attempted on a user constructed SQL statement.
If a non-SELECT SQL statement is entered, the user will be
presented with an error message and a button giving the
option of editing the SQL. The second is when any SQL is
executed. If execution of a non-SELECT SQL statement is
attempted, the user is presented with an error message and
instructed to delete that report as the SQL is invalid.

The second check is intended as a safety net as no non-SELECT
SQL should ever be saved.

It may be well to document the proper usage of the direct SQL
entry type report.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:34 -05:00
Joe Atzberger
ecb43a165c addbiblio - HTML validation fix, add type to link
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:30 -05:00
Joe Atzberger
adbb25b52b auth_finder - HTML validation fixes
Missing </tr> and extra </select>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:28 -05:00
Chris Nighswonger
885b2337a1 kohabug 2448 Correcting Alignment of Column Headers
This patch corrects the alignment of the column headers in the overdues list
on the 'Overdue' tab on opac-user.pl It also corrects the template to display
the item type rather than the Koha collection type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 17:01:43 -05:00
Joe Atzberger
428faf41d6 Add missing </td> to opac-user.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:59:00 -05:00
3f39392413 Minor change to correct offset problem for Cart popup. Libraries with opacheader markup specified were finding their Cart popup appearing out of place.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:58 -05:00
Andrew Moore
b77f9da08b Bug 2084 [1/2]: adding warning to overdues report
This patch adds a warning to the staff interface on the circulation page
to indicate that the overdues report is resource intensive on large installations.

This is considered a stopgap solution. Ideally, this report should be changed in order
to make it usable even for large installations.

Documentation note: Although no functionality has changed, any screenshots of the
circulation page on the staff interface should be updated.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:55 -05:00
5794bde204 Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:49:06 -05:00
Galen Charlton
b8fe6d7a1b bug 1433: use same bib when adding new subscription from details page
When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.

Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:15:16 -05:00
Joe Atzberger
49e4e7020d Patron import reform - bug 2287 - expanded error catching and feedback
This incorporates and extends the patch from MJ Ray attached to bug 2287.
Added feedback of up to 25 lines, including for errors at the Text::CSV
parsing level.  This allows feedback for problems than involve encoding.
Added link to download "starter" CSV file (with all the columns).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 09:37:03 -05:00
Paul POULAIN
80c8b5c149 bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.

This manage multiple errors on barcode and displays them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 08:15:29 -05:00
Galen Charlton
3ddf6172b8 bug 2411: fix adding new tag to authority framework
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:34:42 -05:00
Ryan Higgins
0c66ac6702 Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously  was reporting nothing since the js was broken).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:31:24 -05:00
4b115bac26 Correcting markup for validity.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 15:27:23 -05:00