Commit graph

699 commits

Author SHA1 Message Date
29ab92d261 Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:54 -05:00
Galen Charlton
f5e93e0099 fix XHTML validation errors in LTFL output
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 16:13:29 -05:00
Christopher Hyde
a5d6494c62 Fixed minor error in comment code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:37:15 -05:00
Christopher Hyde
4b56532d0a Changes made: Fixed typo/bug which had wrong order for if statement checking to see whether
Committer: Christopher Hyde <chyde@ebpl.org>

	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:35:02 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00
Jane Wagner
a966c51f1a Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:39:25 -05:00
8c6d7c9996 Adding link back to OPAC for emailed cart and lists.
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 14:29:11 -05:00
Nicole Engard
520d40614e Fix Bug #2925
This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.

In addition I have made it so that the Date Received
only shows if the item is 'Available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 13:08:38 -05:00
204f8dc187 Fix for Bug 3136, Show hold/send/tag links for lists even for non-logged-in users
The patch adds link to "send list" and the text "Log in to place holds or add tags" (with link, similar to the log in message users see in the global lists menu).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 08:34:33 -05:00
475fcc1f51 Setting focus on form fields
This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:36:11 -05:00
Galen Charlton
a0fd9d2cb0 followup to 3004 - fix typo
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 12:14:48 -05:00
Nahuel ANGELINETTI
96543dcf5f (bug #3004) fix the opac authority search
This patch modify the way to transfer the different args, don't use the form arrays.
And use a GET form instead of POST(we are getting datas, sending nothing).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 12:01:58 -05:00
520c160542 Corrected: fix for Bug 3112, Emailed list contains too much whitespace
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 08:19:42 -05:00
60761e44ae Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 13:01:21 -05:00
fe75457c5d Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:20 -05:00
e183ac099a More fixes for Bug 3044
Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:17 -05:00
502a8cb7e2 Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:36:26 -05:00
c705832fa9 New styles for bulk hold and bulk tag inputs on search results page.
This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 12:00:39 -05:00
02b5091c1a Internationalize Amazon support
With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:38:37 -05:00
J. David Bavousett
5e99f59fa6 Added ISBN to RSS results.
Added ISBN tag to RSS results, right after the title.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:04:38 -05:00
2b14727449 Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:31:16 -05:00
462dead372 Adding details to OPAC search results RSS, described in Bug 2973.
This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:22:04 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Galen Charlton
130ca7fb63 fix syntax error in tags JavaScript
FF will tolerate a trailing comma in an
array literal, but Internet Explorer does not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:08:43 -05:00
Stephen Edwards
6d54aa97f0 bug 3034: Tag multiple items at once.
Added a "Tag" button in the toolbar area of the results
page.  This activates an inline form that allows the user
to enter a tag that can then be applied to all currently
selected items.

In addition, a "Tag" link has been added to both the List and
Cart pages that provides the same functionality in those contexts.
In these two cases, the a per-item states appears below the
bibliographic information for each item.

Status that applies to the overall operation, such as failing to
provide a tag, will be shown in an alert dialog box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 12:30:01 -05:00
6542fc4216 Add Babeltheque OPAC enhanced content
www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:42 -05:00
Joe Atzberger
92051e44dd Convert opac-reserve to use GetBranchesLoop.
Removed irrelevant and unused variables dealing with branches.
Also pulled default branch from userenv when not specified as a param.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:54 -05:00
7f3cac43d3 Changing "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be pulled" falsely implies that items are available'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:00 -05:00
3d2e952983 Hiding labels for add to list options when user isn't logged in or options don't exist. Fixes Bug 3043.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:55 -05:00
3c3e20526e Fix for Bug 3062, "place hold on lists different font"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:26 -05:00
Galen Charlton
30dae108e6 convert '&' to '&amp;' in Syndetics URLs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:17:46 -05:00
Daniel Sweeney
0e76b374eb Changed syndetics base URI from syndetics.com to www.syndetics.com
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:52 -05:00
Daniel Sweeney
1dd8e5996c Added content_identifier_exists test to opac-detail.tmpl to prevent broken images in Syndetics content for some titles.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
bd5272f074 Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images
Adds new template variable to test for enhanced content identifiers

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
3d65e44d5c Syndetics and Amazon bugfix enhancements
This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
2eb8d90fc4 Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9abcd844f5 Add Syndetics AuthorNotes, Awards, Series
This patch also includes a new function to retrieve the index
page from Syndetics and parse it for available content prior to
retrieving content; this is done to speed up syndetics content
by not retrieving content that doesn't exist for an item. However,
Syndetics continues to be a very slow service compared to Amazon.com
and other enhanced content services

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
91a998a2ec Fix for LL bug 367 Titles without ISBNs display "no cover image available"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
11bd4a7660 Adds Syndetics Reviews
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9806abf865 Adds support for Syndetics Excerpts and Editions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
de6227bd0a Add Syndetics Summaries and TOC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
2cc793f7aa Adding Syndetics Cover Images to OPAC Detail Page, including shelf browser
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
e99fd37c69 Adds Syndetics Cover Images to Results Page on OPAC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
b9352f18b6 Fix for Bug 3031, Standardize OPAC login form labels.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-12 08:52:38 -05:00
90e995704c Fix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:15 -05:00
4a962af1f4 UI tweaks to OPAC holds screen following addition of multiple holds functionality. Addition of subtitle and copy number to output.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:11 -05:00
Stephen Edwards
15c0ac756e bug 2991: Request hold on multiple items at one time.
Updated the results, cart, and shelf pages to include a button
or link to initiate a hold request based on checked items.

Updated the request CGI scripts to handle multiple biblio items.

Updated the reserve confirmation page to display multiple items,
with an optional list of copies for each one.

Turned on warnings in opac/opac-reserve.pl and fixed resulting
warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:52:39 -06:00
ffa3c9a4a1 Markup and style corrections.
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:36:54 -06:00
Nahuel Angelinetti
e080066db4 bug 2772: bad image location
This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:07:46 -06:00
Mason James
edacb17ba6 bug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:23 -06:00
Mason James
41cb983c3b fix for bug-2923, corrects renew status in SCO
- removes unneeded  HTML::Template::Pro
 - some indent/newline tidies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:17 -06:00
Nahuel ANGELINETTI
b48df4e32f (bug #2962) escape searchbox, and change the search from tag clouds
This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:50 -06:00
66b96f079a Adding Copy Number column to table of item information on holds pages.
Fixes Bug 2753, Hold screen needs to show copy number.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:27:49 -06:00
Galen Charlton
d5faa7f114 bug 2992: don't display MARC codes in search results
Two fields (type of continuing resource and literary
form for sound recordings) in the MARC21 XSLT search
results stylesheet display the code from the 008
position (/21 and /31, respectively) in addition to a
descriptive label.  As a MARC code is meaningless to
patrons, this patch removes the code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:27 -06:00
Galen Charlton
8f9618833e changes to OPAC results and detail XSLT
Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-27 15:21:45 -06:00
7dd4724670 Upgrade jquery dimensions plugin. Correction to Cart js to match.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:37:06 -06:00
7d2875ae4d Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:21:52 -06:00
392f869b44 Removing check for non-existent OPACDisplayItypes sytem pref which prevented itemtype icons from appearing on opac-detail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-25 16:32:27 -06:00
Michael Hafen
330ddf4857 add some search indexes to opac advanced search that are on quick search
This adds ISBN and Call Number, which are in the quick search index
list, but are not in the advanced search index lists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:46:10 -06:00
Daniel Sweeney
871f0f27e3 Added empty item call number test to copies for reserve; added ending punctuation to availability statuses.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:58 -06:00
Joshua Ferraro
d2cb0a20de Fixes to two issues with status display on OPAC:
1. rather than testing for notforloan == -1, test for any negative values to set the On order status
2. in cases where itemcallnumber is blank or null, don't display the itemcallnumber brackets []

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:56 -06:00
Joshua Ferraro
344912cd41 Displays the itemcallnumber in brackets next to location in XSL Results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:53 -06:00
Joshua Ferraro
04270d01b2 Distinguish between items marked 'not for loan' and 'Available'
This patch works with XSL* sysprefs == ON, a future patch will address XSL sysprefs==OFF

Items with notforloan set to a negative number still designate an 'ordered' status

Some items are marked 'not for loan' by setting that value at the item level, others by assigning
that value to that item's itemtype. This patch works for both scenarios.

Specific changes this patch introduces to the OPAC:

* Adds a new OPAC results page key 'Copies available for reference:'
* Changes 'Copies available at:' to 'Copies available for loan:'
* Changes the availability limit label in opac-advsearch from:
    'Only items currently available' to 'Only items currently
	available for loan or reference
* Displays the authorised value for the specific notforloan value in the OPAC detail page in
	parentheses next to 'Not for Loan'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:51 -06:00
John Beppu
12045fd099 Removed RSS Option from UI
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:57:41 -06:00
John Beppu
65b0ca3923 Messaging Preferences for OPAC
- Added ability to request a messaging config change.
  (Apparently, users aren't allowed to directly change these settings.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:54:45 -06:00
Jesse Weaver
1301705150 Add holds policies
This adds holds policy creation support to smart rules and read support to
C4/Circulation.pm, and the two reservation pages. It also adds a system
preference, AllowHoldPolicyOverride, to control whether the staff can override
these policies.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:21:07 -06:00
Nahuel ANGELINETTI
0209a96db7 Unescape some double quotes, that make a validation error.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:29:34 -06:00
011fa47b9d Related to earlier patch: adding body id to add flexibility to CSS customizations.
This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:21:20 -06:00
Galen Charlton
b99e65ca76 bug 2908 followup - use "list", not "shelf"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:18:03 -06:00
Nahuel ANGELINETTI
bfebda4ad9 (bug #2908) adding send shelf by e-mail feature
This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:51:59 -06:00
Allen Reinmeyer
7ca82ab5d2 Bug 2902 Public shelves do not display when user not logged in.
An ending </div> was not placed correctly and encompassed both
privateshelves and publicshelves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 12:28:45 -06:00
3686361d3e Hiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove SMS column from patron messaging preferences if SMSSendDriver is not defined
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:43 -06:00
20a609b587 A few more tweaks to the OPAC detail view menu
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:12:30 -06:00
96d0ea56df Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:44:02 -06:00
Nahuel ANGELINETTI
92afb0dd56 (bug #2887) Change the "Cart" box from js to tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:33:59 -06:00
Allen Reinmeyer
3b1817f685 Bug #2754 Show hold request priority in OPAC
Code changes to display the priority level on holds in OPAC. Turned on/off based on System Preference.  Database changes to systempreferences for both English and French

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:50:56 -06:00
Galen Charlton
d5b98d3bb0 bug 2613: allow web self-check to accept patron ID
Use 'patronid' instead of 'userid' as the query parameter
for passing the patron userid or barcode around; 'userid'
is claimed by C4::Auth and should be used only for
authentication pages.

Fixes the problem where entering a patron's card
number would cause a redirect to the OPAC login
page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:46:36 -06:00
e8d14a6cde Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.
Patch also removes a hard-coded English string from the script and some unused functions from sco.js.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:28:25 -06:00
8350c0ba77 Tweaks to display of "views" tabs (MARC, ISBD, etc).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:24:22 -06:00
Henri-Damien LAURENT
f09e5a71d2 Bug Fix : 2686
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:18:25 -06:00
Allen Reinmeyer
25eb36f21f Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 08:33:59 -06:00
5d72025226 Get back boolean button on OPAC Advanced Search page
With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:45 -06:00
105df865ca Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:14 -06:00
Galen Charlton
a74d196f35 bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:22:06 -06:00
Ryan Higgins
761a589fc0 bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:01 -06:00
Galen Charlton
1e248dbc58 bug 2779: fix template syntax error in OPAC home page
Fixes cause of following message in Apache log:

[Wed Nov 12 14:33:36 2008] [error] [client xxxxx] HTML::Template::Pro:in
TMPL_IF at pos 2860:end tag:found e instead of > at pos 2886

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:04:58 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
Allen Reinmeyer
af9945088c UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.  Javascript wasn't including basket.js on virtualshelves option.  Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.

UPDATED:  Removed EXPR in TMPL_IF conditions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:12:29 -06:00
Nahuel Angelinetti
36fe3b8c6f Some tab cleaning
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:04:26 -06:00
Nahuel Angelinetti
a79a977ee2 fix the private shelf deletion in opac
this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:48:14 -06:00
f58319d4e2 This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:48 -06:00
7045b67a50 Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:42 -06:00
Joe Atzberger
143b757cfe Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 15:41:18 -05:00
9325b1e68f Adding some body IDs to OPAC pages to enable finer per-page control via CSS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 16:23:08 -05:00
8e8f1a04cd Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:52:34 -05:00
Galen Charlton
b47bdb43ae bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:25:13 -05:00
becbbf300d Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 14:48:57 -05:00
f73da33bbe Some minor markup corrections to opac authorities pages. Some fixes to address Bug 2620.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 15:37:52 -05:00
60e9fc3b47 Some changes to improve display on Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 10:39:27 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Danny Bouman
738ac4b492 bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:42:28 -05:00
58deb4ed0c Can't escape title variable as HTML because of search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:36:16 -05:00
0dcd876e6a Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:23:54 -05:00
Joe Atzberger
c70165ca6c Remove double conditional, fix one FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:08 -05:00
7b2e4ebce2 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:02 -05:00
Galen Charlton
f05a732195 bug 2585: fix search links for names (XSLT OPAC display)
Fix malformed OPAC search syntax that caused this bug:

When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work.  When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:52:55 -05:00
Joe Atzberger
37a33c5041 Remove unnecessary EXPR.
There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:42 -05:00
Henri-Damien LAURENT
365520159f modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:24:29 -05:00
ba4c13a559 Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:55:54 -05:00
fe04cf015e Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:39:03 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Jesse Weaver
a4ee974e04 fix for bug 1101: Renew All for the OPAC
This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:50:04 -05:00
Jesse Weaver
e957b3d3c7 fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
This patch changes the template slighly so that these two system preferences do not conflict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:23 -05:00
Jesse Weaver
c77969022b fix for bug 2477: Improve Speed of the Shelf Browser
This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:49:49 -05:00
Joe Atzberger
6e53a31357 Bug #2429, bad HTML from unclosed <head>.
Also some cleanup of opac-showmarc script including removing bogus
dependencies (DBI, CGI methods).  Should consider using C4::XSLT if
applicable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-19 13:40:18 -05:00
Joe Atzberger
18ced6629d masthead - realign terminology for Tag Cloud
Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...".  AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-13 16:09:37 -05:00
Chris Nighswonger
885b2337a1 kohabug 2448 Correcting Alignment of Column Headers
This patch corrects the alignment of the column headers in the overdues list
on the 'Overdue' tab on opac-user.pl It also corrects the template to display
the item type rather than the Koha collection type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 17:01:43 -05:00
Joe Atzberger
428faf41d6 Add missing </td> to opac-user.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:59:00 -05:00
3f39392413 Minor change to correct offset problem for Cart popup. Libraries with opacheader markup specified were finding their Cart popup appearing out of place.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:58 -05:00
212e433920 Cleaning up tags display a little bit, adding tablesorter to user tags table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:57 -05:00
70bf88542d Minor markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:54 -05:00
cee7483d52 Partial fix for Bug 2420 ("OPAC shows broken image for some Google Jackets"). This fix only corrects for undefined img src, not for well-formed but broken img src.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:31 -05:00
Joe Atzberger
4b47782b6e Tag cloud implementation in jquery.
Initial implementation of "cloud" display on opac-tags.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:45:25 -05:00
Joshua Ferraro
5c2ba65541 This patch fixes the OPAC view and holdability of items:
1. restores a check to itemtype.notforloan to set the norequests flag
2. changes improper boolean OR with AND for checking conditions of setting norequests
3. displays 'Not for loan' for item-level itypes when the itemtype is set to notforloan
4. restores items.notforloan values < 0 allowing holds (ordered items for instance)

We still need a notforhold flag set at the itemtype, and items level
2008-07-25 11:32:06 -05:00
909a548e15 Adding a couple of IDs to the markup to enable more flexibility in custom styling.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:06 -05:00
b71cab54cf Minor tweak to tags display.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:22 -05:00
e348a70e45 Adding js table sorter for holdings.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:19 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
f2779f6dd7 Removing duplicate column (Bug 2364, "Library column repeated")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:37 -05:00
Joshua Ferraro
71e436504b Removes the Libraries facet if singleBranchMode is ON 2008-07-18 17:54:11 -05:00
Joshua Ferraro
dd70b27305 Hide location selection when singleBranchMode is ON 2008-07-18 17:46:58 -05:00
Joshua Ferraro
e427bf860a Fixing bug with the way authority ID query was being generated
in XSL stylesheet
2008-07-12 09:33:17 -05:00
Joshua Ferraro
085f329d7a Fix for bug 2342: Searching on more than 1 itemtype breaks
The problem was that the 'mc-' was removed from the checkboxes a while back and
that's what triggers the automatic application of OR boolean searching. I've
added it back to the templates and modified the ccl.properties file to include
mapping for itype,itemtype and ccode
2008-07-12 09:09:14 -05:00
841a8f8b24 Extra comma caused js error in IE6; _() function allows translation script to pick up strings in Javascript.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-12 08:59:40 -05:00
60d585aed6 Hide User Tags link when TagsEnabled preference is turned off. Change to Auth.pm allows TagsEnabled preference to work on login screens.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-12 08:59:39 -05:00
3bde990685 Adding javascript to deselect appropriate input fields when 'next available copy' is checked or unchecked. Changing checkboxes to radio buttons to prevent multiple selections. Note: with javascript off, an item-level hold will be placed for the selected item even if the 'next available copy' box is checked.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 15:03:39 -05:00
Joshua Ferraro
1fe23a6f03 Partial fix for bug 2319: OPAC Shelf Browse results in a 404 error
This patch fixes instances where thereis no Next or Previous item on the shelf
that were previous resulting in 404 errors
2008-07-08 17:52:52 -05:00
Joshua Ferraro
08ba790e3e Fix for bug 2312: Advanced search - search limit appearing twice of limit not the item type 2008-07-08 15:57:58 -05:00
Joshua Ferraro
22684e9ec7 Fix for 2160: My Lists Tab on OPAC Profile 2008-07-08 00:18:40 -05:00
Andrew Moore
1316aa2f69 spelling correction in comment in javascript file
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-02 12:25:35 -05:00
Andrew Moore
6546a1506a bug 2176: spelling correction
correcting spelling in opac messaging tab.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-02 12:25:30 -05:00
Joe Atzberger
2ba17314ab Fix alternating "highlight" to use __odd__ and combine consequetive
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-26 05:51:34 -05:00
Chris Nighswonger
299e74b334 Bugfix Correcting opac-shelves template to allow patron to set list category to public or private
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-26 05:51:31 -05:00
Joshua Ferraro
ac2daa1cf2 workaround for translation update script 2008-06-20 19:59:54 -05:00
Ryan Higgins
98371d473a Adding Public note to default Normal view in opac-detail page.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 18:40:44 -05:00
Chris Nighswonger
e6fb2bc77b Tidying up the Lists button menu
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 18:00:23 -05:00
Galen Charlton
378e919059 bug 2002: show item's in transit status in OPAC holds list
If item is in transit, show that status in the OPAC
user's hold list rather than "waiting to be pulled".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 17:55:55 -05:00
Chris Nighswonger
18fa43a735 Correcting "Your Lists" to display properly when no lists exist.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 17:55:52 -05:00
Galen Charlton
556538e101 bug 2248 [2/2]: import item status display in search results
The in transit status now displays as such in the
OPAC search results.  In the non-XSLT version, the status
is checked only for bibs having 20 or fewer items to avoid
extra hits on the database during result set presentation.
In the XSLT version, all items are checked.

Note that because an item's transfer status is not
stored in the MARC record, the transfer status
has no effect when limiting a search by item
availability.  For a future version, the transit status
should be added to the Zebra index.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 17:47:04 -05:00
Galen Charlton
6a8ca7fbd1 bug 2248 [1/2]: improve item status display in OPAC detail
The following statuses are now displayed correctly in the
bib details page in the OPAC:

* In transit
* Damaged
* Not for loan

Prior to this patch, items of these statuses displayed
as available.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 17:47:03 -05:00