Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Owen Leonard	f87435c933	Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. Behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Fix indentation	7 years ago
Julian Maurice	a000d95a4d	Bug 18633: Remove useless use of CGI TT plugin The form is sent using AJAX so there is never a query string in the URL (no POST parameters either) Tested both patches together, item search behaves as before, log entries are gone Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	ab29b5efdc	Bug 18762: Remove warnings from xt/author/valid-templates.t Test plan: Read the changes and make sure they make sense Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com>	7 years ago
Julian Maurice	6727a61578	Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Julian Maurice	8d25174117	Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Nick Clemens	da3ccdc143	Bug 18047 - JavaScript error on item search form unless LOC defined If LOC is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' This patch fixes it by handling this specific case. Note that the "Status" column is still displayed. Test plan: Remove your LOC authorised values Go on the item search form => You will not get the JS error and the "Shelving location" bloc is no longer displayed. There is no need to display it if empty. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Jonathan Druart	27a4149625	Bug 16115: Remove JS error on item search if NOT_LOAN values do not exist If NOT_LOAN is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' This patch fixes it by handling this specific case. Note that the "Status" column is still displayed. Test plan: Remove your NOT_LOAN authorised values Go on the item search form => You will not get the JS error and the "Status" bloc is no longer displayed. There is no need to display it if empty. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Josef Moravec	804677265e	Bug 16239: Update templates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	c86a9e4d30	Bug 17743: Item search - Fix indexes build on MARC Searching items by custom search fields does not work because these fields are not correctly processed in JS. In case of custom search field, the parent of the option is not the select but the optgroup element. Test plan: Create a custom search field on 245$c for instance On the items search form, select this field and launch a search => Without this patch, the results will not be filtered and you will get all your items => With this patch applied, the results should be correctly filtered Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Nick Clemens	7705a195a7	Bug 17516 - Add CSV export option to item search after displaying output to screen To test: 1 - Perform an item search 2 - Note you now have a link to output to csv 3 - Click that link 4 - Page should not change and you should recieve a csv 5 - Ensure nothing breaks 6 - Sign off High five! Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Owen Leonard	d356e71ecb	Bug 13949 - Item search should have holding library This patch adds holding library ("current location") to the list of fields available in the item search form. To test, apply the patch and go to Search -> Item search. - Perform a search using the "current location" option and verify that it returns the correct results. - Try other searches to confirm that they work as before. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Aleisha	2afff4e850	Bug 16524: Use floating toolbar on item search To test: 1) Go to item search 2) Confirm toolbar at top of page with Search button, goes down page as you scroll 3) Confirm search button has been removed from final output fieldset 4) Confirm everything works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Julian Maurice	ba49225e25	Bug 16238: Use .prop() instead of .attr() for 'disabled' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Owen Leonard	6381d1853d	Bug 16241 - Move staff client CSS out of language directory The staff client CSS is not language-specific, so it can be moved out of the en/ directory and thus not be duplicated for every translation. In order to be able to have a generic path to the YUI CSS files, the YUI directory is moved by this patch to the staff client's lib/ directory. To test, apply the patch and visit various pages in the staff client. Look in particular at pages which include more than the standard CSS. For example: - The staff client login page. - The staff client home page. - Patron -> Set permissions. - The advanced cataloging editor. - Acquisitions -> Vendor -> Basket groups. - Tools -> News -> Edit news. - Administration -> System preferences. Revised: I intended for this to be built on top of Bug 15883. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 Works as described, all pages on test plan No Errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Aleisha	b64df89601	Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested together with follow up patch, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Julian Maurice	9aa8bf46f6	Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma Signed-off-by: Owen Leonard <oleonard@myacpl.org> I could not reproduce the bug when selecting multiple home libraries, but I could by selecting multiple item types or collection codes. The patch allowed those queries to complete correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>	9 years ago
Owen Leonard	870104ce11	Bug 13464 - Standardize the pagination class There are a few template which use a different wrapper class for the pagination links. These should be made consistent for a consistent style. To test, apply the patch and go to Administration -> Budgets. - On this page the pagination markup has been removed in favor of DataTables pagination. The budget tables were already sorted using DataTables, so having server-side pagination on top of that doesn't make sense. In Administration -> Class sources: - This page had pagination markup which was unused. In Authorities -> Authority search results: - Perform an authority search which will return more than one page of results. Confirm that the pagination links are correctly styled. In Search -> Item search: - Perform a search which will return more than one page of results. Confirm that the pagination links are correctly styled. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Since the funds are all displayed (and nobody complained), it makes sense to display all budgets. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>	8 years ago
Kyle Hall	a8942c2884	Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues Revert "DBRev to make notes of the XSS patches and the new important dependency." This reverts commit `e140603a59`. Revert "Bug 13618: Specific for branches.opac_info" This reverts commit `06e4a50f00`. Revert "Bug 13618: (follow-up) Specific for other prefs" This reverts commit `d6475a111f`. Revert "Bug 13618: Fix for debarredcomment and patron messages" This reverts commit `dd98c9df92`. Revert "Bug 13618: Do not display html tags in patron's notices" This reverts commit `a065b243fe`. Revert "Bug 13618: Do not display   and html tags in item fields content" This reverts commit `baeeaffbf8`. Revert "Bug 13618: Fix for system preference description" This reverts commit `a967a09261`. Revert "Bug 13618: Remove html filters for newly pushed code" This reverts commit `0e98662b10`. Revert "Bug 13618: (follow-up) add missing lines for opac-shelves" This reverts commit `fc2fb605e5`. Revert "Bug 13618: (follow-up) Specific for ColumnsSettings" This reverts commit `bc308fdd9c`. Revert "Bug 13618: Fix for edit biblios and items" This reverts commit `811c4e8402`. Revert "Bug 13618: followup to remove tabs" This reverts commit `ca8e8c397c`. Revert "Bug 13618: Fix last occurrences recently introduced to master" This reverts commit `bb417b256b`. Revert "Bug 13618: Fix for news" This reverts commit `ae5b98020a`. Revert "Bug 13618: Fix escape on sending baskets or shelves by email" This reverts commit `a7731ffe25`. Revert "Bug 13618: Specific for XSLTBloc" This reverts commit `11fa38dc29`. Revert "Bug 13618: Specific for Salutation on editing a patron" This reverts commit `36c07ad6d3`. Revert "Bug 13618: Specific for other prefs" This reverts commit `e6ea281a3b`. Revert "Bug 13618 - memberentrygen.tt errors Not a GLOB reference" This reverts commit `7824874557`. Revert "Bug 13618: Specific for ColumnsSettings" This reverts commit `1834da3da3`. Revert "Bug 13618: Specific for IntranetUser* and OPACUser* prefs" This reverts commit `21ae62b253`. Revert "Bug 13618: Fix error 'Not a GLOB reference'" This reverts commit `602bdbab4c`. Revert "Bug 13618: Specific for the ISBD view" This reverts commit `d254362435`. Revert "Bug 13618: Specific for pagination_bar" This reverts commit `8837a8ae68`. Revert "Bug 13618: Specific places where we don't need to escape variables - intra" This reverts commit `00eff140b3`. Revert "Bug 13618: Remove html filters at the intranet" This reverts commit `7db851ff03`. Revert "Bug 13618: Specific places where we don't need to escape variables" This reverts commit `49a3738b8d`. Revert "Bug 13618: Remove html filters at the OPAC" This reverts commit `cedaa0e23e`. Revert "Bug 13618: Use Template::Stash::AutoEscaping to use the html filter" This reverts commit `01b38d3b13`. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Jonathan Druart	8837a8ae68	Bug 13618: Specific for pagination_bar Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	9 years ago
Fridolin Somers	2d0d717301	Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Thx for the follow-up! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
Rochelle	62b8f1a830	Bug 13564: Items search: rename Stock number to Inventory number To test: - Go to Advanced search - Click on link 'go to item search' - Check the search options in the second section for "Stock number" - Do a search and note the column name appears as "Stock number" - Apply patch - Try the search again and check that "Inventory number" shows Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, thx! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	e91c39d448	Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	1eb85ad757	Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	6114c5fd6f	Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit `954c2874d0`). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The paging seems still a bit buggy, but this makes the feature usable again! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Héctor Eduardo Castro Avalos	433d9d3d9f	Bug 13256 - Typographical error on item search template Typo error found in the new template itemsearch.tt line 363 "_ matches only a single charcter" Test plan: 1) Go to url 'intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt' line 363 and check the typo "_ matches only a single charcter" and change for _ matches only a single character 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	dc85139da2	Bug 11425 [Template follow-up] Search form for items This template followup makes several changes to markup and text: - Replace "Bibliographic reference" with "Title" - Replace "Callnumber" with "Call number" - Replace "Home branch" with "Home library" - Replace "Holding branch" with "Current location" - Replace "Location" with "Shelving location" - Replace "Issues" with "Checkouts" - Replace "Indifferent" with "Ignore" - Replace "&" with "&" where necessary - Correct page title and breadcrumbs - Remove label "for" attribute from labels which do not directly target a form field - Correct label "for" attribute on labels which should target a form field - Correct date format hint This patch also makes one change to the way the page display works: The search results section is now in a separate div which uses a different grid rule, allowing it to take up the full width of the screen. To keep the page headers from looking weird I've changed the markup so that each section has its own header. To test, perform a variety of searches and confirm that the output in both Screen and CSV views looks correct. Confirm that search results which are output to the screen are formatted nicely and that the "edit search" links work correctly to show the search form. Submitting a new search after editing a search should hide the form and redisplay the search results table. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, improves display.	10 years ago
Julian Maurice	2f2ff6729d	Bug 11425: QA fixes - Reword 'joker' to 'wildcard' - Explain what wildcards do - Reword 'Modify' to 'Edit' Also fix jQuery plugin columnFilter path Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	10 years ago
Julian Maurice	5a5682bd59	Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Nice box Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	10 years ago
Julian Maurice	7c2ff7940e	Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Good new option. No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	11 years ago

29 Commits (f87435c933616c648c50ab609d1fea2ac51785a7)