Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	655f11fd60	Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Amy King	d05547dcb6	Bug 27458: Set focus for cursor to Credit type code field Test Plan: Before applying patch 1. Click on Administration 2. Scroll down to Accounting and click on Credit types 3. Click New credit type 4. Note how the cursor does not focus on Credit type code field 5. Apply patch 6. Repeat steps 1-3 7. Note how the cursor now focuses on Credity type code field Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD amended patch: Edit commit title Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Julian Maurice	58edcef03d	Bug 19036: Add ability to enable credit number for only some credit types This feature is disabled by default for all credit types. To enable it you have to set the syspref AutoCreditNumber to the value of your choice and then enable the feature for each credit type you want. System credit types can be modified too (but only this particular field can be modified) Also, throw an exception when the feature is enabled and a value for credit_number has already been set Updated test plan: Test plan: 0. Apply patch, run updatedatabase and update_dbix_class_files 1. Go to Admin » Column settings, and uncheck the 'hidden' box for column credit_number in table account-fines. It will be easier for testing 2. Create a manual credit for a borrower. Verify in Transactions tab that this credit has no number generated 3. In Admin » Credit types: a. edit the FORGIVEN type and enable credit number generation b. create a new type A, check "can be manually added" and "enable credit number" c. create a new type B, check "can be manually added". Do NOT enable credit number 4. Change syspref 'AutoCreditNumber' to 'incremental' 5. Create more manual credits with types CREDIT and B, and verify that the numbers are not generated 6. Create more manual credits with types FORGIVEN and A, and verify that the numbers generated are 1, 2, 3, ... 7. Change syspref 'AutoCreditNumber' to 'annual' 8. Create more manual credits with types CREDIT and B, and verify that the numbers are not generated 9. Create more manual credits with types FORGIVEN and A, and verify that the numbers generated are '2020-0001', '2020-0002', ... 10. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr' 11. Create more manual credits with types CREDIT and B, and verify that the numbers are not generated 12. Create more manual credits with types FORGIVEN and A, and verify that the numbers generated are 'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are connected to library BRANCHA, and it's February 2020) 13. Set library to another one, say BRANCHB 14. Create more manual credits with types FORGIVEN and A, and verify that the numbers generated are 'BRANCHB2020020001', 'BRANCHB2020020002', ... 15. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %] somewhere. Go back to Transactions tab and click on 'Print' for one line that has a credit number. Make sure the number is there. 16. prove t/db_dependent/Koha/Account.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Martin Renvoize	adc59c434d	Bug 17702: (RM follow-up) Remove use of I18N tt This patch removes the use of the I18N TT plugin in introduced for all strings in the new template. We're not yet ready to use this plugin for all strings as we need to further investigate performance for such a move and perhaps add template compilation. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Julian Maurice	50a733f09c	Bug 17702: Add UI to manage account credit types It is the same as for debit types. It adds a new column `archived` in table `account_credit_types` that has the same purpose than `account_debit_types.archived` Test plan: 0. Apply patch && run updatedatabase && update_dbix_class_files 1. Go to Admin » Credit types 2. Add a new credit type, give it a code and a description and check 'Can be manually added' 3. Go to a patron's accounting section, 'Create manual credit' tab 4. Verify that the new credit type appears 5. Return to Admin » Credit types and archive the credit type 6. Verify that the new credit type is not available anymore in 'Create manual credit' 7. Restore the credit type and verify that it is available again 8. Create a manual credit with the new credit type 9. Go to Reports » Cash register and make sure you can find the transaction by filtering on transaction type 10. Edit the new credit type and set some library limitations, make sure that the credit type doesn't appear if you're connected to a library you didn't selected, and that it appears if you're connected to a library you selected. Note to QA team: The change in Koha/Account.pm, I added it because otherwise Koha died when adding a manual credit with a custom type. In that case, offset type will default to 'Manual Credit'. I'm not sure if that is the best thing to do. I'm open to suggestions :) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Martin Renvoize	454d4745b7	Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martin Renvoize	b2b651d13d	Bug 23049: (follow-up) Types should not be deletable This patch rmeoves the 'delete' option from the debit_types system and replaces it with an 'archive/restore' workflow. This will help maintained referential integrity. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martin Renvoize	9641b3c8c7	Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martin Renvoize	86ece7d2e5	Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago