Commit graph

5045 commits

Author SHA1 Message Date
Garry Collum
fad17c9da3 Bug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:42:44 -05:00
Garry Collum
3cdbce6919 Bug 3090: Adds the report ID field to the saved reports page in the guided reports.
Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:41 -05:00
12370281e6 tweak description of OpacBrowser syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:08:25 -05:00
9b99f3f660 Add OpacBrowser preference to opac.pref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:05:58 -05:00
2b125a6f93 bug 2885: attempting to add library with existing code now gives error message
If one attempts to add a new library with a code already in use,
an error message is shown.  The main library data input by the user
is preserved, allowing the user to try a new code.

This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 21:13:50 -05:00
c097736084 Fix for bug 2885, now an error message is thrown instead of a silent fail
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 20:29:44 -05:00
Will Stokes
7fc8025978 Bug #2162: Step 2, add pagination. Splits results into blocks of 250 results and adds Previous and Next buttons. Achieved using forms, hidden search variables and submit buttons.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:26:31 -05:00
Will Stokes
7de9a2128a Bug #2162: Step 1, prevent running of report upon entry to page. Add name run_report to submit button and checks in template.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:26:15 -05:00
Garry Collum
679548c302 Bug 4181: Fixes XHTML in viewlog.tmpl.
Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:11:52 -05:00
8a116ac314 fixed errors in previous patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:07:45 -05:00
Chris Cormack
20997939b7 Fixing some small XSS vulnerabilities
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:03:03 -05:00
Chris Cormack
8f902d3248 Bug 1542, followup patch to tidy up some messy dropdown behaviour
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 18:14:19 -05:00
e476adcb9c remove extra /TMPL_IF
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 18:09:26 -05:00
625021ada7 Changes to further work on Bug 3550, Use GetRecordValue to get the subtitle
- Adding subtitle display to OPAC Cart, lists, and reading record
- Minor tweaks to some displays

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 14:39:42 -05:00
ba80729eaa bug 4104: remove stray disused template (intranet tags.tmpl)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 14:34:41 -05:00
Nicole Engard
5298ada3ec bug 4174 add AWSPrivateKey sys pref to new interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 14:27:44 -05:00
Garry Collum
5fc0c4968d Bug 4180: Fixes unclose TMPL_IF in supplier.tmpl
Also fixes a minor XHTML error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 14:27:41 -05:00
9b98fc778d bug 4169: fix item batch modification for MARC21
The MARC21 framework uses $0 for the item withdrawn status.  Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.

Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.

Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
2010-02-12 15:03:00 -05:00
Nicole Engard
9c286deb27 bug 4168 add keyword to marc mapping to menu
Also fixed misnamed budgets & funds links

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-11 19:39:50 -05:00
Nicole Engard
94769fc831 add koha to marc mapping help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-11 19:39:49 -05:00
Colin Campbell
fc2120c6df Bug 4163 Preserve budget value unless changed by user
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-11 19:39:48 -05:00
Chris Nighswonger
8d4d96f309 Bugfix: Make smart-rules.tmpl display zero values in fields.
Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.

This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-11 06:27:36 -05:00
Nicole Engard
02fd7edf85 bug 4150 require title in new list on staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-11 06:15:30 -05:00
7fc63299db Reformat Keyword to MARC mapping interface according to existing patterns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 22:50:12 -05:00
Nicole Engard
4016173b2c bug 4153 move messages on inventory tool to top
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 22:46:58 -05:00
5a61015c84 bug 3920 follow-up: tweak wording of staff XSLT* sysprefs
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 22:40:11 -05:00
Nicole Engard
508df9946c add patron card help files
there are still more to add, but these are what I have written so far

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 22:13:22 -05:00
Nicole Engard
0f56aca4ef updated help files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 22:13:21 -05:00
88681d9862 bug 4152: fixed template so that barcode file uploads work
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 13:33:51 -05:00
Henri-Damien LAURENT
209637695d bug 3893 : No way to see late orders
When no lateorders were found, there was no way to change the limit in order to check for older orders

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 08:41:48 -05:00
3d19eb7fef bugs 3912, 4144: can now add contracts if dataformat is not metric
Fixed bug in date validation that prevented adding new contracts
if the dateformat syspref was set to something other than 'metric'.

In process, also removed three hand-written date validation routines
in favor of using JavaScript Date objects and the Date_from_syspref
function provided in calendar.inc.

This fixes bug 3912, and partially addresses bug 4144.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 08:41:47 -05:00
Zeno Tajoli
1d0bd7fc59 Bug 3162 Fix only for [forward port of tempoary fix 3.0.x]
Note that this patch causes the authority subfield visibility
to match 3.0.x, but at a cost - only two options are available now,
hide all and show all, and much flexibility is lost.  This will
need to be improved.

(cherry picked from commit 56831089ed)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 06:23:08 -05:00
Garry Collum
f02e460671 Bug 3860: Can't expand authorities.
Adds a link to the Authority tag to expand the fields if advancedMARCeditor is in "Don't display" mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 05:59:50 -05:00
Colin Campbell
e66929f052 Bug 4147 Correct name of external javascript file
An earlier patch inadvertantly reverted a name change in the template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 05:53:33 -05:00
Colin Campbell
284329e625 add PTFS-Europe as a contributing company
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 21:32:43 -05:00
65540255d8 Fix for Bug 4138, Adding or deleting suggestions in the OPAC does not properly refresh the page
- Using redirect() and adding URL parameter to enable the display of
  messages on the screen confirming the action.
- Also correcting for JavaScript error in form validation routine.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 21:05:02 -05:00
Chris Nighswonger
d91ebf445f Bugfix: Enabling guide box configuration parameter
This patch enables turning the guide boxes on/off in the patron
cards layout editor.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 20:54:44 -05:00
Garry Collum
63bb60702f Bug 4142: Fixes XHTML errors in aqbudgetperiod.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 20:54:26 -05:00
Colin Campbell
b5dafcf198 Bug 4140 label edit template links to non-existent script
changed link to point at labels script

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 13:46:15 -05:00
Nicole Engard
7c397b8d3b bug 3738 add preferences to new sys pref interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 13:46:13 -05:00
dd4f7a87d5 Fix for Bug 2869, 'do not delete' marc framework tag - reverts to 'default' framework
- "Do not delete" form was missing hidden framework code input.
- Also added details to breadcrumb navigation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:50:21 -05:00
dae8244a03 Fix for Bug 4136, Invalid XHTML in spinelabel-print view
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:39:08 -05:00
b6b6be8e23 Markup error, closing tag missing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:17:03 -05:00
Colin Campbell
e2e7f0d050 Correct misleading text
Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:54:59 -05:00
d4678b363a bug 2576 - fix XHTML validation errors generated by previous commit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:14:59 -05:00
Jane Wagner
0e7fa3edbd Bug 2576 reopened -- turn off fines elsewhere in OPAC account
The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record.  However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc.  This patch turns off the other instances of
fine columns/displays if the syspref is off.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:12:33 -05:00
ff4d456072 Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet
- Add two syspref:
  - OPACXSLTResultsDisplay
  - OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
  tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 08:08:44 -05:00
Matthias Meusburger
88e99d1c29 BZ4104: Removes tagging in staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:59:46 -05:00
Garry Collum
fd2bf6043b Bug 3752: Fixed XHTML errors in opac-MARCdetail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:48:44 -05:00
Garry Collum
c6805cea9d Bugs 3646 and 2651: Changes the output of compact.xsl from html to xhtml.
Changes the output of compact.xsl to XHTML for catalogue/showmarc.pl?viewas=card.

Adds <title> element in <head>.
Removes link to nonexistent css file (bug 2651).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:48:39 -05:00