Commit graph

10658 commits

Author SHA1 Message Date
Garry Collum
311a4b7967 Bug 3602: Fixes a log error for opac-search.pl if expanded_options is not defined.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:00:14 -04:00
Garry Collum
68bfc64972 Bug 3603: Fixes XHMTL errors in catalogue/showmarc.tmpl
Missing <title> tags, missing </head> and <body>, extra </div>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:00:12 -04:00
Garry Collum
1a587e661f Bug 3604: Fixes invalid XHTML in manage-marc-import.tmpl.
Also adds zebra striping to <table>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:00:09 -04:00
Garry Collum
8a91a93bd1 Bug 3605: Fixes XHTML error in z3950_search.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:00:07 -04:00
Garry Collum
5056cd1f53 Bug 3606: fixes 'last 50 items only' link in members/readingrec.tmpl.
If a staff member clicked on 'Show all items' in a patron's reading record, and
then clicked on 'show last 50 items only,' all of the records would still be
shown.  The link for the 'last 50' items contains a switch for 'limit=full'
instead of 'limit=50'.

Also fixes some XHTML errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:00:03 -04:00
Michael Hafen
5de6ec3c15 Avoid potentially unnecessary database call in Auth
Auth, after verifying the session/logging in the user, calls to the database
to get the users borrowernumber.  This call is probably unnecessary because
borrowernumber is part of userenv.  Check userenv before going to the database.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 20:29:39 -04:00
Katrin Fischer
5934b8d8ae BUG 3625: untranslatable strings in opac-shelves.tmpl
select all, clear all, tag, place hold

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 20:26:02 -04:00
6970d3c1ae Follow-up for Bug 3524, adding itemtype text description
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 09:12:24 -04:00
Nicole Engard
448ad31007 Bugs: 1172 3579 3596 fixes to patron detail in opac
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.

It also removed the messaging options from the patron
details and leaves them on the messaging tab.

Finally it adds in address fields that were missing
previously on the update patron form.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:56:58 -04:00
J. David Bavousett
88ba183305 Handle null-or-empty to Charset::StripNonXmlChars
When rebuild_zebra.pl is run from cron, there is an occasional error
of the form:

Use of uninitialized value $str in substitution (s///) at /home/ebpl/kohaclone/C4/Charset.pm line 304.

This error is occuring when the string that is fed to Charset::StripNonXmlChars
is null or undefined, for some reason.

This fix will handle the null-or-empty condition, and thus suppress the error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:42:11 -04:00
Garry Collum
5707371eda Bug 2505: Enabled warnings in tools-home.pl, holidays.pl, exceptionHolidays.pl, and newHolidays.pl
Tested for warnings after addition of 'use warnings.' No warnings were generated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:38:35 -04:00
Garry Collum
481ae9861b Bug 3601: Cleanup of holiday.tmpl
Changes the word 'location' to 'library.'
Expands the description of 'exception.'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:38:25 -04:00
937d9f214c Remove js debugging which caused failure of "uncheck all."
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:32:06 -04:00
2f99d99991 Merge commit 'origin/master' into sopac 2009-09-08 17:16:22 -04:00
Chris Cormack
fa2e9e4958 Fix for typo in previous history patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-07 07:31:19 -04:00
Chris Cormack
c643d0e083 2 new committers for the history doc
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-07 07:31:17 -04:00
Wolfgang Heymans
53040ea9e8 Bug 3567: Display Alternate Graphic Representation (MARC21 880) in OPAC
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:51:43 -04:00
e50bc421c4 Changes to make checkouts/holds display the same on circulation and patron detail screens (Bug 3106)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:37:10 -04:00
8b0ba909c0 Display description, avoid broken itemtype image on holds page (Bug 3524)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:37:07 -04:00
Henri-Damien LAURENT
2687817576 Adding strings to translate in tags.js
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:25:37 -04:00
Henri-Damien LAURENT
2c1cdc5dc3 Bug Fixing 3568 : Untranslated strings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:20:19 -04:00
cc12f07357 DB rev 054->058
055: changed OPACSearchForTitleIn per requests in bug 1934
056: Bug 1172 : Add OPACPatronDetails syspref
057: Bug 2576 : Add OPACFinesTab syspref
058: Added primary keys to language tables

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 14:04:38 -04:00
Nicole Engard
f0406c7d04 Bug 1934: Final Patch - Fixed Default Values
The default values had classes they didn't need assigned
to them.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:37 -04:00
Nicole Engard
2ce2e973c9 Bug 2559 Added primary keys to tables per comments
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:36 -04:00
Nicole Engard
6dd6af59c2 Bug 2576: Added OPACFinesTab Syspref
This preference allows library staff to decide whether to show
the fines tab in the OPAC for logged in patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:35 -04:00
Nicole Engard
e71c8a4343 Bug 1172: Added OPACPatronDetails system preference
This patch allows library staff to disable the patron details
tab on the OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:34 -04:00
Nicole Engard
8678154392 Bug 1934: Changed variables per request in bug report
System preference now looking for brackets around variables.
ex. {TITLE} instead of TITLE

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:33 -04:00
f7f783226a ran ILS-DI code through perltidy
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:26 -04:00
ccdc20496f bug 2505: enable strict and warnings in ILS-DI code
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
e7450455c8 added missing module import to C4::ILSDI::Utility
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Jean-André Santoni
a9dacab04a Changed the way to get borrower's branchcode in HoldItem and HoldTitle
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Jean-André Santoni
e35abadbbf I forgot to export functions from Utility.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Jean-André Santoni
d86515a358 This fixes the encoding of ampersand entities in GetRecords
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Jean-André Santoni
ed92b52b26 Added comments to ILS-DI code
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Jean-André Santoni
070aacf4a8 Added ILS-DI module
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
6b90ec566c bug 1003: tweak GetBibliosShelves
* correct POD - returns *public* lists that bib
  belongs to
* use fetchall_arrayref to return results in
  one fell swoop
* corrected indentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:06:42 -04:00
Nicole Engard
b9f4fa6260 Bug 1003 Added lists to bib details pages
This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page.  The same goes if virtualshelves
is turned OFF.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 12:58:36 -04:00
Ricardo Dias Marques
f8ff5879a5 Bug 3582: Missing usage information for -h / --help switch for rebuild_nozebra.pl
Fix for Bug 3582:  Missing usage information for -h / --help switch for rebuild_nozebra.pl

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3582

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 12:48:35 -04:00
b1197477d4 comment out styles in gb_styles.css
These were added in the labels rework, but do not belong here, since
gb_styles.css should references only CSS classes responsible for
displaying the greybox itself, not the content inside it.  In particular,
the generic table styles were causing the icons added by tablesorter
to be tiled in the opac-detail template.

To finish this work, the styles should be taken out entirely and
moved to whichever lables template they were supposed to affect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 12:42:16 -04:00
Nicole Engard
c000e0a28c Bug 2713 Make Marc & ISBD View match Normal template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 11:24:48 -04:00
c2c4f3e737 DB rev 053->054: add altcontactcountry and B_address2 to borrowers and deletedborrowers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 10:23:01 -04:00
Katrin Fischer
c36098e316 Bug 3464: Added altcontactcountry and B_address2 to borrowers and deletedborrowers
- added altcontactcountry and B_address2 to tables borrowers and deletedborrowers so that all addresses offer the same fields
- changed B_country and country to work with syspref BorrowerMandatoryField
- changed display of Alternate Address on borrower detail page, added labels, lines and edit button to match the other sections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 10:01:51 -04:00
Sébastien Hinderer
2a8df0bc2f Get rid of a few warnings in the bulkmarcimport script: C4/Biblio.pm, hunks #1, #2: a warning occurring in NoZebra configurations. C4/Biblio.pm hunk #3: warning occurring in Unimarc MARC flavour. misc/migration_tools/bulkmarcimport.pl hunk #1: warning occurring when no default format is specified on command-line with -m switch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:54:11 -04:00
ec6aaaebb0 bug 3581: fix staff permission for item circ alerts
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:46:39 -04:00
73dd78ce1c Revamp interface of branch transfer limits to give finer conrol of bulk selections.
Adds selection by row and by column, all/none/toggle for individual ccode/itype sets, and a tabbed interface for a more compact display.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:31:30 -04:00
ddfe9f8ac0 Tighten up layout of item circulation alerts interface, putting checkout and checkin table in tabs.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:31:27 -04:00
390a270b1e Modules for caching - C4::Cache is the base class, C4::Cache::Memcached and C4::Cache::FastMemcached are subclasses
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:23:32 -04:00
b66904201a Starting on OO module for memoizing our functions
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:23:08 -04:00
Michael Hafen
a5d298ad45 bugfix breeding results of cataloging search has wrong id
The breeding id, rather than coming from the database, was set by a counter.
Not so good links in the search results that way.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:13:20 -04:00
Michael Hafen
ee83c4ae80 smart-rules load users library instead of default
If the user isn't a super librarian load their library by default instead of
the default settings.

This would eliminate some confusion amoung my librarians.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:13:16 -04:00