Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Tomás Cohen Arazi	946cbf71a7	Bug 15150: Make t/ tests skip if Test::DBIx::Class absent Tests in t/ should always pass for building the Debian packages for Koha. But we've started using Test::DBIx::Class for writing mocked tests, and that lib is not (yet) packaged fro Debian 7+. This means build is failing. Devs and jenkins use the lib from CPAN. This patch makes the tests skip if the lib is absent. To test: - Install Test::DBIx::Class $ sudo cpanm Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests pass - Uninstall Test::DBIx::Class $ sudo cpan -U Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests still pass (those needing the lib are skipped) - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. All test pass successful Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	dffaf369f4	Bug 14778: Install fixtures for t/Biblio.t Note that it already passed before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Tomás Cohen Arazi	46419b797b	Bug 14346: t/Biblio.t fails because of new warning Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not "supported" by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. This patch makes GetMarcBiblio return undef if no biblionumber is passed, and also raises a conveniently carped warning. This change is tested in t/Biblio.t with new tests. To test: - In current master, run $ prove t/Biblio.t => FAIL: a test detects a wrong warning count and fails. - Apply the patch and run $ prove t/Biblio.t => SUCCESS: Tests now pass, and there are 2 new ones. - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Tomás Cohen Arazi	561b474bc9	Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Sponsored-by: Wanting the darn packages to build Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sponsored-by: Not wanting to read in my maths book Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Admin User Koha	de8d5f3ae9	Bug 12995 - script update_totalissues.pl stops on corrupted record - UT This patch adds an unit test on C4::Biblio::UpdateTotalIssues method call on non existing record Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't comment on the correctness of the test other than to say it ran successfully. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves CLI script, works as described. Note: A small improvement would be to output the problematic biblionumber.	10 years ago
Tomás Cohen Arazi	22b1113b6b	Bug 12570: test for carped warnings in t/Biblio.t To test: - Run $ prove t/Biblio.t => Warnings printed to STDOUT - Apply patch - Run $ prove t/Biblio.t => No warnings Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more warnings. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Colin Campbell	2e0e15485e	Bug 11032: Check a valid MARC::Record passed to Biblio Intermittently problems in the calling environment cause a C4::Biblio routine to be called with an undefined MARC::Record object. This results in the process dying and returning to the end user a low level message such as 'cannot call method x on an undefined object'. For exported subroutines taking a MARC::Record object, check that object is defined otherwise return a logical return value and log a stack trace to the error log. A couple of cases were checking but dying, this may have unwelcome results in a persistent environment so croak has been downgraded to carp Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Adds lots of checks for $record in various places, should not affect behaviour. Passed all tests and QA script, including new unit tests. Tested adding and saving a new record. Also tested detail and result pages without XSLT. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Zach Sim	65e2cda8d2	Added unit tests for Biblio and moved it to db_dependent as it requires the database. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Katrin Fischer	cc9a34c274	Bug 5327: Add basic unit tests to some C4 modules Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Joe Atzberger	a1fe32d2f8	Total Test Overhaul! Most of these were stubs, and still are. Input.t was replaced because it tested a now obsolete function. Input.pm has that function commented out. Several files were renamed to match their counterparts or correct misspellingz. Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
rangi	77618f43cf	Finishing up the last of the tests	17 years ago
rangi	ccc8db346d	More test files	17 years ago
rangi	07b3e3c952	Continuing to add tests	17 years ago
rangi	07902f96e8	Working on unit tests	17 years ago

13 Commits (fc66eedcc429e1eb8175d6e95bc5e921d8b94664)