Commit graph

12839 commits

Author SHA1 Message Date
fb5412c529 Fix for Bug 4849 - Cannot delete records from Labeled MARC view
The template checks for a "count" variable (item count) to see
whether it should allow deletion of the biblio record. For some
reason labeledMARCdetail.pl hard-coded this as 1, which meant
the template always thought was 1 item.

This patch also adds an item count check on the display of
"Delete all items," disabling it if there are no items.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:16:48 -04:00
Robin Sheat
7d44072156 Bug 5054 - allow the resulting .deb location to be specified
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:12:31 -04:00
Robin Sheat
18a1c3db11 Bug 5139 - packages now do email and other cron jobs
By default the packages now set up the cron jobs to handle things like
overdues and email etc. By default, email is off, 'koha-email-enable'
and 'koha-email-disable' can manage this.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:12:14 -04:00
Ricardo Dias Marques
95cb1c3a7f Fix for Bug 5116 – Duplicate and missing entries in "apt-get-debian-lenny.sh"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5116

In the Debian installer shell script for Debian Lenny -
"apt-get-debian-lenny.sh"  - there were 2 missing lines for packages
that exist for Debian Lenny and that have versions that satisfy the
requirements of the Koha Installer, listed in the "PerlDependencies.pm"
file - located at "C4/Installer/PerlDependencies.pm".

The two missing lines are for "libnet-server-perl" (for the
"Net::Server" module) and "libpdf-table-perl" (for the "PDF::Table"
module).

I also noticed, in that same "apt-get-debian-lenny.sh" script, that
there were some duplicate (repeated) entries / lines for other modules,
namely: libdate-calc-perl, libdbd-mysql-perl, libemail-date-perl,
libgd-barcode-perl, libhtml-scrubber-perl, liblingua-stem-perl,
libmail-sendmail-perl, libmime-lite-perl, libnet-ldap-perl
and libpoe-perl.

So I'm adding, in this patch, the 2 missing lines
and removing the duplicate lines / entries.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:12:13 -04:00
Ian Walls
a897931313 Update VOKAL icon set
The Green Mountain Library Consortium has updated the 'vokal' item type
image set to include new and updated icons, including:
Puzzles and Games
BLURAY
Hardware
Educational Media
Fiction, Nonfiction, New and Holiday books
ILL materials

Smaller versions of all the icons (32 px) are included as well.

Sorting of the icons has been included in this patch to group
large and small versions of these icons together, as well as make large
icon sets easier to visually scan (the 'bridge' set benefits from this,
as well) .

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:09:22 -04:00
f8cec7ba13 Fix for Bug 4922 - Item display tries to show serial info for titles with series tags
Removing check for "is this a serial record" when displaying enumchron
information. This check evaluates as true for all biblio records which
have a series title, so it's an inaccurate determiner of whether
enumchron information should be displayed. The script already
checks for the presence of enumchron data, so that will display
anyway if it exists.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:06:42 -04:00
Nicole Engard
1b9e92261d Update VOKAL icon set
follow up patch to Ian's August 20th patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:05:41 -04:00
Eric Olsen
858f67f01a Bug 5217 : package/CPAN updates for Ubuntu Lucid install
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:04:38 -04:00
Eric Olsen
968bd3bfde Bug 5207 - Details on editing SAX Parser ini file.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:04:37 -04:00
Eric Olsen
a0dc63b460 Bug 5200 - ubuntu.packages file installs CVS Removed 'install cvs' line from ubuntu.packages
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:03:56 -04:00
Chris Cormack
c8729d9afd Removing outdated note about z3950search in the help file, no longer applicable
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:01:21 -04:00
Robin Sheat
57d11aee2c Bug 5077 - ensure rebuild_zebra will run somewhere it can read
This prevents it leaving files lying around in /tmp

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:00:17 -04:00
Chris Cormack
d82c1cf05f Shifting the tests that need user input to their own directory, they cant be used by the automated tester
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:58:35 -04:00
Chris Cormack
9b0bd43f10 Fixing the VirtualShelves test
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:58:34 -04:00
Chris Cormack
6d581f9f6b Fixing C4::Boolean tests, in August 2009 we changed the die to a warn, tests didn't reflect this. Now we should have 100% of C4::Boolean
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:58:33 -04:00
Colin Campbell
48a10d3183 Bug 5032 Remove duplicate code
Two duplicate calls to GetSerials appear to have been merged in
to no purpose other than to generate warnings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:56:53 -04:00
Colin Campbell
a5bdd61c73 Bug 5047 html option not in -help output
Add -html option to list in pod so that it shows up
in output of help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:54:28 -04:00
Colin Campbell
1519497ea7 Bug 5160 Stop words should be stop words not strings
Stop words in the default zebra config were being defined as
initial strings not as words causing then to truncate legitimate
headings.

This patch corrects that behaviour. It does not address the
question of what should be in the default file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:49:35 -04:00
27bb768cad bug 5086: fix setting claim date
Also removed a locus for SQL injection.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:45:41 -04:00
40d9995822 Fix for Bug 5101, Creators tab isn't highlighted when selected
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:14:26 -04:00
e1952c8ad7 Merge remote branch 'koha-fbc/k_bug_5215' into master
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:12:30 -04:00
a85bd68b8e Merge remote branch 'koha-fbc/k_bug_5247' into to-push
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:11:05 -04:00
07ae6c6cd6 Merge remote branch 'koha-fbc/k_bug_5249' into to-push
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:10:36 -04:00
Colin Campbell
c19a56f9cd bug_5245 Fix SQL syntax in GetItems
Routine never executed query due to syntax error
and returned undef
made the call to fetchrow_array explicit as the old fetchrow alias
is no longer documented in perldoc DBI

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:05:33 -04:00
1705820ed4 Merge remote branch 'koha-fbc/k_bug_5203' into master
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:04:22 -04:00
Ian Walls
7f40eb3f6b Fixes bug 5231: bad call to GetAuthType in BiblioAddAuthorities()
If systempreference BiblioAddsAuthorities is on, this could lead to error messages when trying to add records
to a basket from an external source.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:02:25 -04:00
Colin Campbell
171802b174 Fix compile time warning in member.pl
variable to declared twice

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:58:40 -04:00
Chris Cormack
b27cf9b55a Missed adding the beta release
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:56:57 -04:00
Chris Cormack
efa47d99e6 Updating history doc
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:56:53 -04:00
Katrin Fischer
53a11dbea9 Bug 5090: New order from empty record does not save publication year and ISBN
- make publication year save for MARC21
- make ISBN save
- fix small template issue with label for vendor note

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:49:48 -04:00
f2573b6d0f Revert "Bug 5081 - let the ISBN be saved on new manual orders"
Reverting in favor of a more comprehensive patch.

This reverts commit 4bd7492518.
2010-10-06 06:49:13 -04:00
bd8a04e308 Merge branch 'translation' of git://git.workbuffer.org/git/koha into master
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:32:07 -04:00
c4601faf13 Bug: 4904: Problem with printing fines in overdue notices
my $formatted_fine = currency_format("$1", "$fine", FMT_SYMBOL);
is already utf-8.

Resend with additional change, removing 2 lines (no strict, use strict) from the code.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:21:34 -04:00
Colin Campbell
c0e773c6e6 Bug 2664: Add item should preselect logged in branch
An earlier fix to stop branch values being overwritten in
edit items was causing the branch value to be unset when adding items

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:58 -04:00
3a3b6ba5d8 Fix for Bug 5265, error message on lists is misleading
The check to see if an item exists always evaluates as true.
Correcting this lets the script handle the error as it
was designed to.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:56 -04:00
Robin Sheat
4bd7492518 Bug 5081 - let the ISBN be saved on new manual orders
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:53 -04:00
03ff10ba02 Bug 5201 Patron surname dropped
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:52 -04:00
b357e728bc Fix for Bug 5222 - 600 t not showing with xslt on
Original commit message was for 650 field, but fix works for 600.  See bug report.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:50 -04:00
e4f37fde48 Bug 4305 Get Amazon book covers for ISBN13
The way Koha get book cover from Amazon doesn't work from biblio records
having ISBN13 because Amazon expect an ISBN10. This patch transforms
ISBN13 into ISBN10 before sending it to Amazon.

Warning! On some devel installations, you will have to install by hand a
new CPAN depency:

  Business::ISBN

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:48 -04:00
0c6250f754 Bug 5187: Show place of publication (MARC21, 260$c), XSLT
Show place of puplication in
- OPAC result list
- OPAC detail
- staff detail

The normal display does already show the place of publication, but it's missing from the XSLT controlled displays.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:46 -04:00
Jared Camins-Esakov
9f7f61be4a Fix Bug 5261 broken link in Local Use sysprefs
This patch eliminates the sysprefs-menu.inc include file and changes the
systempreferences.pl and systempreferences.tmpl files to work with the
prefs-menu.inc instead. This will centralize the syspref tabs and make it
easier to modify tabs in the future if necessary.

This commit also changes the default tab to Acquisitions, since the Local Use
tab does not work with preferences.pl at present.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:44 -04:00
Katrin Fischer
0594a2f17d Add 3 more links to Ohloh to about page
- Markus Enger (asked for permission)
- Jared Camins-Esakov (asked for permission)
- Katrin Fischer

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:42 -04:00
08fb9eadc3 Bug 5194 - Patron notification on new issues not working
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:13:50 -04:00
a26440bafa Fix for syntax error in the spanish opac file 2010-10-06 23:11:50 +13:00
Chris Nighswonger
d8f16da180 Bug 4867 - cannot clone subfields in marc editor, other clone/unclone weirdness
When the clone/unclone plus/minus were replaced with images the <span> tags were inadvertantly deleted
causing the js to loose its ability to identify the clone/unclone links and properly udpate the indexes.
The resulting incorrect indexes caused various weirdnesses to result when one attempted to clone/unclone
subfields.

This patch simply adds classes to the two links and updates the js to identify the links based on class.

Thanks to owen for his help in chasing this down.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:11:36 -04:00
34165af5ac Language updates 2010-10-06 23:03:21 +13:00
Colin Campbell
dfaa0e9d35 Bug 5191 Patron notification was being reset to none
The value of the letter variable was not being correctly passed
to the edit template instead it was reset to none
Also compressed some verbage from letter_loop generation
(if you want a scalar use one)
removed an unused $count variable (?!)
and put a couple of lone )s back on the line they came from

Resend to remove wrong utf-9 header.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:03:08 -04:00
35eaad3dcd More language updates 2010-10-06 23:02:10 +13:00
Colin Campbell
acb672c027 Bug 4310 Map orders to new budget structure
Map orders to newly created budgets
creates a temporary file fundmapping
which is not dropped so that conversion can be
checked subsequently

As acquisitions historically let you do some odd things
with dates and funds. This probably needs close checking
if you are converting active data

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 05:59:13 -04:00
Colin Campbell
c02cd2cabf Bug 5205 Fix compile time warnings in tools/batchMod.pl
$dbh was declared twice
prototypes used in a subroutine that was not declared before use

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 05:59:10 -04:00