Commit graph

552 commits

Author SHA1 Message Date
ffa3c9a4a1 Markup and style corrections.
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:36:54 -06:00
Nahuel Angelinetti
e080066db4 bug 2772: bad image location
This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:07:46 -06:00
Mason James
edacb17ba6 bug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:23 -06:00
Mason James
41cb983c3b fix for bug-2923, corrects renew status in SCO
- removes unneeded  HTML::Template::Pro
 - some indent/newline tidies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:17 -06:00
Nahuel ANGELINETTI
b48df4e32f (bug #2962) escape searchbox, and change the search from tag clouds
This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:50 -06:00
66b96f079a Adding Copy Number column to table of item information on holds pages.
Fixes Bug 2753, Hold screen needs to show copy number.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:27:49 -06:00
Galen Charlton
d5faa7f114 bug 2992: don't display MARC codes in search results
Two fields (type of continuing resource and literary
form for sound recordings) in the MARC21 XSLT search
results stylesheet display the code from the 008
position (/21 and /31, respectively) in addition to a
descriptive label.  As a MARC code is meaningless to
patrons, this patch removes the code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:27 -06:00
Galen Charlton
8f9618833e changes to OPAC results and detail XSLT
Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-27 15:21:45 -06:00
7dd4724670 Upgrade jquery dimensions plugin. Correction to Cart js to match.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:37:06 -06:00
7d2875ae4d Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:21:52 -06:00
392f869b44 Removing check for non-existent OPACDisplayItypes sytem pref which prevented itemtype icons from appearing on opac-detail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-25 16:32:27 -06:00
Michael Hafen
330ddf4857 add some search indexes to opac advanced search that are on quick search
This adds ISBN and Call Number, which are in the quick search index
list, but are not in the advanced search index lists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:46:10 -06:00
Daniel Sweeney
871f0f27e3 Added empty item call number test to copies for reserve; added ending punctuation to availability statuses.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:58 -06:00
Joshua Ferraro
d2cb0a20de Fixes to two issues with status display on OPAC:
1. rather than testing for notforloan == -1, test for any negative values to set the On order status
2. in cases where itemcallnumber is blank or null, don't display the itemcallnumber brackets []

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:56 -06:00
Joshua Ferraro
344912cd41 Displays the itemcallnumber in brackets next to location in XSL Results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:53 -06:00
Joshua Ferraro
04270d01b2 Distinguish between items marked 'not for loan' and 'Available'
This patch works with XSL* sysprefs == ON, a future patch will address XSL sysprefs==OFF

Items with notforloan set to a negative number still designate an 'ordered' status

Some items are marked 'not for loan' by setting that value at the item level, others by assigning
that value to that item's itemtype. This patch works for both scenarios.

Specific changes this patch introduces to the OPAC:

* Adds a new OPAC results page key 'Copies available for reference:'
* Changes 'Copies available at:' to 'Copies available for loan:'
* Changes the availability limit label in opac-advsearch from:
    'Only items currently available' to 'Only items currently
	available for loan or reference
* Displays the authorised value for the specific notforloan value in the OPAC detail page in
	parentheses next to 'Not for Loan'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-09 14:36:51 -06:00
John Beppu
12045fd099 Removed RSS Option from UI
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:57:41 -06:00
John Beppu
65b0ca3923 Messaging Preferences for OPAC
- Added ability to request a messaging config change.
  (Apparently, users aren't allowed to directly change these settings.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:54:45 -06:00
Jesse Weaver
1301705150 Add holds policies
This adds holds policy creation support to smart rules and read support to
C4/Circulation.pm, and the two reservation pages. It also adds a system
preference, AllowHoldPolicyOverride, to control whether the staff can override
these policies.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:21:07 -06:00
Nahuel ANGELINETTI
0209a96db7 Unescape some double quotes, that make a validation error.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:29:34 -06:00
011fa47b9d Related to earlier patch: adding body id to add flexibility to CSS customizations.
This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:21:20 -06:00
Galen Charlton
b99e65ca76 bug 2908 followup - use "list", not "shelf"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:18:03 -06:00
Nahuel ANGELINETTI
bfebda4ad9 (bug #2908) adding send shelf by e-mail feature
This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:51:59 -06:00
Allen Reinmeyer
7ca82ab5d2 Bug 2902 Public shelves do not display when user not logged in.
An ending </div> was not placed correctly and encompassed both
privateshelves and publicshelves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 12:28:45 -06:00
3686361d3e Hiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove SMS column from patron messaging preferences if SMSSendDriver is not defined
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:43 -06:00
20a609b587 A few more tweaks to the OPAC detail view menu
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:12:30 -06:00
96d0ea56df Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:44:02 -06:00
Nahuel ANGELINETTI
92afb0dd56 (bug #2887) Change the "Cart" box from js to tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:33:59 -06:00
Allen Reinmeyer
3b1817f685 Bug #2754 Show hold request priority in OPAC
Code changes to display the priority level on holds in OPAC. Turned on/off based on System Preference.  Database changes to systempreferences for both English and French

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:50:56 -06:00
Galen Charlton
d5b98d3bb0 bug 2613: allow web self-check to accept patron ID
Use 'patronid' instead of 'userid' as the query parameter
for passing the patron userid or barcode around; 'userid'
is claimed by C4::Auth and should be used only for
authentication pages.

Fixes the problem where entering a patron's card
number would cause a redirect to the OPAC login
page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:46:36 -06:00
e8d14a6cde Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.
Patch also removes a hard-coded English string from the script and some unused functions from sco.js.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:28:25 -06:00
8350c0ba77 Tweaks to display of "views" tabs (MARC, ISBD, etc).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:24:22 -06:00
Henri-Damien LAURENT
f09e5a71d2 Bug Fix : 2686
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:18:25 -06:00
Allen Reinmeyer
25eb36f21f Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 08:33:59 -06:00
5d72025226 Get back boolean button on OPAC Advanced Search page
With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:45 -06:00
105df865ca Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:14 -06:00
Galen Charlton
a74d196f35 bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:22:06 -06:00
Ryan Higgins
761a589fc0 bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:01 -06:00
Galen Charlton
1e248dbc58 bug 2779: fix template syntax error in OPAC home page
Fixes cause of following message in Apache log:

[Wed Nov 12 14:33:36 2008] [error] [client xxxxx] HTML::Template::Pro:in
TMPL_IF at pos 2860:end tag:found e instead of > at pos 2886

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:04:58 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
Allen Reinmeyer
af9945088c UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.  Javascript wasn't including basket.js on virtualshelves option.  Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.

UPDATED:  Removed EXPR in TMPL_IF conditions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:12:29 -06:00
Nahuel Angelinetti
36fe3b8c6f Some tab cleaning
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:04:26 -06:00
Nahuel Angelinetti
a79a977ee2 fix the private shelf deletion in opac
this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:48:14 -06:00
f58319d4e2 This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:48 -06:00
7045b67a50 Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:42 -06:00
Joe Atzberger
143b757cfe Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 15:41:18 -05:00
9325b1e68f Adding some body IDs to OPAC pages to enable finer per-page control via CSS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 16:23:08 -05:00
8e8f1a04cd Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:52:34 -05:00
Galen Charlton
b47bdb43ae bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:25:13 -05:00
becbbf300d Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 14:48:57 -05:00