Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Nick Clemens	97b8bd5ebc	Bug 20275: Add comment to let user know they can define multiple plugindirs Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Kyle Hall	dbc24783ee	Bug 17826: Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Mauchley <dmauchley@duchesne.utah.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: added parentheses on line 488 when assigning hashref to array. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	8 years ago
Marcel de Rooy	818f1c2f83	Bug 20187: (QA follow-up) Replace N,L flag by L flag The flags [N,L] make no sense: next and last combined. Choosing here for L to stop the rewriting process. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Kyle Hall	8cd0a76d10	Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Olli-Antti Kivilahti	f89a2bbdbe	Bug 12904: Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>	7 years ago
Kyle Hall	43c67312a0	Bug 12904: Apache configuration Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>	8 years ago
Tomás Cohen Arazi	a523f09e04	Bug 17951: (follow-up) Make Makefile.PL handle template_cache_dir config This patch adds Makefile.PL the capability of handling the template_cache_dir configuration entry. To do so, it: - Adds the --template-cache-dir option switch (consistency with koha-create) - Sets a default value for template_cache_dir to '/tmp/koha' - Adds a dialog requesting the path for the template cache dir to Makefile.PL - It tweaks etc/koha-conf.xml so it is correctly changed by rewrite-config.PL To test: - Apply this patch - Run: $ perl Makefile.PL --template-cache-dir your/favourite/dir => SUCCESS: The dialogs don't ask for template cache dir => SUCCESS: The resulting Makefile contains an entry for TEMPLATE_CACHE_DIR which value matches what we passed to --template-cache-dir - Run: $ perl Makefile.PL - When prompted for a template cache dir, introduce whatever you want => SUCCESS: The default you are offered is /tmp/koha => SUCCESS: At the end of the process, Makefile contains what we put in there - Run: $ sudo make install => SUCCESS: The resulting koha-conf.xml contains a <template_cache_dir> entry containing whatever you picked for that purpose. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Alex Sassmannshausen	8e86b5e093	Bug 7317: Interlibrary loans framework for Koha. This Commit is at the heart of adding an interlibrary loans framework for Koha. The framework does not prescribe a particular workflow. Instead it provides a general framework that can be extended & implemented by individual backends whose responsibility it is to implement a specific workflow. The module is largely self-sufficient: it adds new tables to the Koha database and touches only a few files in the Koha source tree. Primarily, we add our files to the Makefile and the koha-conf.xml, define ill paths for the REST API, and introduce links from the main intranet, opac pages & user permissions. Outside of this we simply add new files & functionality. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Kyle Hall	22249e4ced	Bug 16899: Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	8 years ago
Kyle Hall	df4a87d4a6	Bug 18104 - allow SIP2 field AE (personal name ) to be customized Koha's SIP2 server sends the patron's name in the format "Firstname Surname" which is not very good for machine reading. We need to allow the format of the patron name to be customized in a manner similar to what is done with the DA field on bug 16755. Test Plan: 1) Apply this patch, start or restart your SIP server 2) Find a patron with a first and last name 3) Send a patron information request via the sip2 cli tool 4) Note the AE field has the format "<firstname> <surname>" ( i.e. the current behavior ) 5) Add this parameter to the login stanza you are using: ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 6) Restart your SIP server 7) Repeat step 3 8) Note the AE field now has the format "<surname>, <firstname>" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Benjamin Daeuber <BDaeuber@cityoffargo.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Kyle Hall	a78bb5ba1c	Bug 16755 - allow SIP2 field DA ( hold patron name ) to be customized The SIP2 DA field that Koha transmits is an odd and arbitrary format that some SIP2 clients cannot handle. It would be best if this format were customizable on a per-login basis in the same manner as the AV field. Test Plan: 1) Find an item that is checked out with holds 2) Return the item via SIP2 ( using the SIP2 cli emulator ) 3) Note the value of the DA field 4) Apply this patch, restart your SIP2 server 5) Repeat step 2 6) Note the DA field value has not changed 7) Add this parameter to the login stanza you are using: da_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 8) Restart the SIP2 server again 9) Repeat step 2 10) Note the DA field returned is now in the format "$surname, $firstname" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Benjamin Daeuber <BDaeuber@cityoffargo.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	8 years ago
David Cook	9026169a23	Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf One of the RewriteCond directives in koha-httpd.conf was affecting the wrong RewriteRule after its original RewriteRule was commented out years ago. _TEST PLAN_ 0) Before applying patch, build Koha from source ) make ) make install (or make upgrade) ) Copy or symlink etc/koha-httpd.conf to your Apache vhost directory (and enable if you're on a Debian based system) ) Restart Apache 1) Make sure that you have at least 1 bibliographic record in Koha (URL like this http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1) 2) Go to http://server:port/bib/1 3) Note that you get a 404 error 4) Apply the patch 5) Rebuild Koha from source as per step 0 6) Go to http://server:port/bib/1 7) Note that you now see the same page as you would if you went to http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Tomás Cohen Arazi	5ef1b6710e	Bug 18098: Add an index with the count of not onloan items This patch adds a numeric index 'not-onloan-count' containing the value of 999$x. This subfield is filled by 'rebuild_zebra.pl' by making use of (bug's 18208) 'EmbedItemsAvailability' filter. bib1.att and indexes definitions are updated accordingly. To test: - Apply the patch - Pick the right biblio-zebra-indexdefs.xsl file for your setup and replace the one your Zebra uses [1] - Replace your bib1.att - Replace your ccl.properties - Have at least one record with more than one item, checkout some item(s) from that record(s). - Rebuild zebra's indexes: $ sudo koha-shell kohadev k$ cd kohaclone k$ misc/migration_tools/rebuild_zebra.pl -r -b -v -k (notice the dump directory is kept, you can try the XSLT yourself running: $ xsltproc \ etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /tmp/the_dump_dir/biblios/exported_records \| less => SUCCESS: There are records with the not-onloan-count index, and the value is correct! - Check Zebra yourself: $ yaz-client unix:/var/run/koha/kohadev/bibliosocket Z> base biblios Z> find @attr 1=9013 @attr 2=5 @attr 4=109 0 => SUCCESS: The search matches the amount of records with not-onloan items. Z> s 1+1 => SUCCESS: Records with 999$x having a value higher than 0 are rendered - Sign off :-D Note: While this work is complete on its purpose, it is part of an attempt to create a better way of filtering by availability. Sponsored-by: ByWater Solutions [1] In kohadevbox this would be /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl Edit: Added the missing XSLT changes for UNIMARC and NORMARC Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Kyle Hall	7e62964107	Bug 16895 - Allow writeoffs via SIP2 Many SIP2 services such as those by Comprise Technologies are able to or require that an ILS be able to accept writeoffs via SIP2. The SIP2 protocol specifies that payment type be a two digit number, but does not specify a code for writeoffs. To this end we should allow the write-off code to be specified in the SIP2 config on a per-account basis so that if different vendors use different fixed codes for write-offs we can handle that gracefully. Test Plan: 1) Apply this patch 2) Modify your SIP2 config to include payment_type_writeoff="06" in the login portion of the account you will be using for the test. 3) Restart your SIP2 server 4) Create a fee for a patron 5) Send a SIP2 fee paid message specifying the payment type code we defined earlier, with a payment amount that is not equal to the amount outstanding for the fee. 6) Note the fee paid response indicates the payment failed 7) Repeat step 5, but this time send the amount outstanding as the payment amount 8) Note that the fee paid response indicates a successful payment 9) Note in Koha that the fee has been written off! Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>	8 years ago
Dimitris Kamenopoulos	84e48d0323	Bug 15427 : Enable TLS support for MySQL In summary, changes are: 1) If you have chosen MySQL, Makefile.PL will ask you if you want TLS (default: "no"), and then the locations for CA cert, client cert and client key (reasonable defaults are provided). Settings <tls>, <ca>, <cert> and <key> are added in koha-conf.xml 2) If <tls>yes</tls> in koha-conf.xml, the installer and database connection scripts add the TLS options in both DBI connection strings and mysql command line To test 1/ Apply patch 2/ Check everything still works and db connections are the same as before 3/ Either run Makefile.PL and step through the options or edit your koha-conf.xml to enable TLS 4/ Check db connections are still working Patch provided to me by Dimitris Kamenopoulos and I reformatted it into a git patch, any errors are probably mine Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
Zoe Schoeler	543dc8e036	Bug 17838 Availability limit broken until an item has been checked out. TEST PLAN 1. Make sure you have no items checked out. 2. Run sudo koha-rebuild-zebra -f -v kohadev. 3. Go to search the catalog and search. 4. Check items availability and then click on limit to currently available items. 5. This should return no results. 6. Apply patch and reload. 7. Results should show. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Attribute 14: " Specifies whether un-indexed fields should be ignored. A zero value (default) throws a diagnostic when an un-indexed field is specified. A non-zero value makes it return 0 hits." From http://www.indexdata.com/zebra/doc/querymodel-zebra.html Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Tomás Cohen Arazi	21d63c8fb0	Bug 17788: (MARC21) Add $9 fields to Koha-Auth-Number:w index Looking at the default framework's fields that are linked to authority records, there's a divergence with the Zebra index definitions. This yields to authority usage count be incorrect for users searching for authority records. MariaDB [koha_kohadev]> SELECT tagfield,tagsubfield,authtypecode FROM marc_subfield_structure WHERE authtypecode IS NOT NULL AND authtypecode<>'' AND frameworkcode='' GROUP BY tagfield,tagsubfield,authtypecode ; +----------+-------------+--------------+ \| tagfield \| tagsubfield \| authtypecode \| +----------+-------------+--------------+ \| 100 \| a \| PERSO_NAME \| \| 110 \| a \| CORPO_NAME \| \| 111 \| a \| MEETI_NAME \| \| 130 \| a \| UNIF_TITLE \| \| 440 \| a \| UNIF_TITLE \| \| 600 \| a \| PERSO_NAME \| \| 610 \| a \| CORPO_NAME \| \| 611 \| a \| MEETI_NAME \| \| 630 \| a \| UNIF_TITLE \| \| 648 \| a \| CHRON_TERM \| \| 650 \| a \| TOPIC_TERM \| \| 651 \| a \| GEOGR_NAME \| \| 654 \| a \| TOPIC_TERM \| \| 655 \| a \| GENRE/FORM \| \| 656 \| a \| TOPIC_TERM \| \| 657 \| a \| TOPIC_TERM \| \| 658 \| a \| TOPIC_TERM \| \| 662 \| a \| GEOGR_NAME \| \| 690 \| a \| TOPIC_TERM \| \| 691 \| a \| GEOGR_NAME \| \| 696 \| a \| PERSO_NAME \| \| 697 \| a \| CORPO_NAME \| \| 698 \| a \| MEETI_NAME \| \| 699 \| a \| UNIF_TITLE \| \| 700 \| a \| PERSO_NAME \| \| 710 \| a \| CORPO_NAME \| \| 711 \| a \| MEETI_NAME \| \| 730 \| a \| UNIF_TITLE \| \| 796 \| a \| PERSO_NAME \| \| 797 \| a \| CORPO_NAME \| \| 798 \| a \| MEETI_NAME \| \| 799 \| a \| UNIF_TITLE \| \| 800 \| a \| PERSO_NAME \| \| 810 \| a \| CORPO_NAME \| \| 811 \| a \| MEETI_NAME \| \| 830 \| a \| UNIF_TITLE \| \| 896 \| a \| PERSO_NAME \| \| 897 \| a \| CORPO_NAME \| \| 898 \| a \| MEETI_NAME \| \| 899 \| a \| UNIF_TITLE \| +----------+-------------+--------------+ This patch adds the missing ones to the authority number index as it is done for the rest of the fields. To test: - Verify that etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml contains intries pointing the $9 subfield of all the fields in the 'tagfield' column above, to the Koha-Auth-Number:w index. - Sign off :-D Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
David Cook	0eb5d8491e	Bug 17871: Remove zebra::snippet to allow access to facets in YAZ 5.8.1+ This patch restores access to zebra facets (or zebra::snippet) with YAZ 5.8.1 or higher. It was failing due to The <retrieval syntax="xml" name="zebra::*" /> entry in retrieval-info-bib-dom.xml which IndexData said it wasn't even needed to get that access. Edit: I amended the commit message (tcohen) Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I tested on kohadevbox and found no regression or behaviour change. I will provide a followup for the packages. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Kyle Hall	af34598448	Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased against master and added a description for the new configuration entries Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	819cea62f2	Bug 7533: Add the template_cache_dir entry to koha-conf.xml And comment it, as we don't know what are the sysop's preferences Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Chris Cormack	b222e7d921	Bug 13029 : Follow up Adding POD, changing the config files to live in a path pointed to by koha-conf.xml This means multiple instances can have their own config Please test the 2 patches together Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Arbitrary arguments can be passed to SMS:Send drivers. If an argument is provided that has already been set by SMS::Send or the driver, it will be overwritten by the value from the YAML file. My only suggestion for an improvement would be an example of what the YAML should look like, but that is a minor thing. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Tomás Cohen Arazi	cb3f899826	Bug 17547: (MARC21\|NORMARC) have Chronological term field $9 indexed This patch makes Zebra index the 648$9 link for chronological terms on bibliographic records. This way an authority search on chronological terms will show the right number in 'Used in X records' message. To test: - Have a record with a 648 field, linked to an authority record (i.e. with an authid on 648$9). - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => FAIL: the term is linked to our record, but koha shows '0' count. - Apply the patch - Run: $ cd kohaclone $ xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ git diff => SUCCESS: Notice the shipped etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl is up-to-date - Run: $ sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ sudo koha-restart-zebra kohadev $ sudo koha-rebuild-zebra -f -b -v kohadev - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => SUCCESS: the term is linked to our record, usage count is 1 - Sign off :-D I assume NORMARC is similar on this regard. Feel free to fail it if the NORMARC part of the patch is wrong. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Josef Moravec	bd13efd8ac	Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "č" - should be sorted after "c", "š" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok Signed-off-by: radiuscz <radek.siman@centrum.cz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I did not test this patch, but trust in the author and signoffer Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Mason James	f2196a2e4f	Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default to test bug... 1/ make a random user 2/ change to random user 3/ access any zebra database with random user and no authentication 4/ read zebra database here is a transcript of the bug... --------------------------- root@xen1:~# adduser bob root@xen1:~# su -l bob bob@xen1:~$ cd /var/lib/koha bob@xen1:/var/lib/koha$ ls topsecret bob@xen1:/var/lib/koha$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.001002 Z> base biblios; Z> find the Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 1130, setno 2 SearchResult-1: term=the cnt=1130 records returned: 0 Elapsed: 0.005518 Z> show Sent presentRequest (1+1). Records: 1 [biblios]Record type: USmarc 01824cam a2200397 a 4500 001 000045782309 003 AuCNLKIN 005 20111013213222.0 008 100707s2011 maua 001 0 e ... --------------------------- 5/ apply changes to a Koha instance's config files, that you plan to test 6/ restart zebra for instance # sudo koha-restart-zebra topsecret 7/ repeat steps 2 and 3, but receive a 'bad user/passwd ' error from zebra bob@xen1:~$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection rejected by v3 target. 1: code=1011 (Init/AC: Bad Userid and/or Password), NOTE: this patch currently will only fixes newly created instances, it wont fix existing instances Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Good catch Mason Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Tomás Cohen Arazi	ea5ec8c4d5	Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Tomás Cohen Arazi	1c957af7bc	Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Magnus Enger	cb72420b46	Bug 17228 - Fix whitespace in etc/SIPconfig.xml Remove trailing whitespace and replace tabs with 4 spaces. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Marcel de Rooy	5b4259be9c	Bug 6499: [QA Follow-up] Trivial adjustments Removes commented line from bib1.att. Adjust OCLC-number to Other-control-number in comment of ccl properties. No need to explicitly add 035$a and $z if you index 035 completely in record.abs as well as biblio-koha-indexdefs.xml. Rerun koha-indexdefs-to-zebra.xsl on index defs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
Barton Chittenden	84f51549c9	Bug 6499: Add Zebra index "Other-control-number" covering MARC21 035$a, 035$z and 035 (entire tag) 1) Apply patch 2) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. pre 3) Replace all modified zebra files and restart zebra server 3) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 4) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add Other Control Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="Other-control-number">Other Control Number</option>'); } }); 5) Do an advanced search, select "Other Control Number" from the search menu, then add the Other Control Number in 035$a for the bib specified in step 1. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	10 years ago
Marcel de Rooy	3fe6abc9d5	Bug 16777: Correct intranet search alias A long-standing typo in our apache config files: [intranet]/search refers to search.pl (which does not exist) This patch refers it to catalogue/search.pl Test plan: Run an install or copy the change from apache-shared-intranet.conf or koha-httpd.conf to your apache config. Restart Apache and check if http://[your staff client]/search works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested by making manual changes according to the patch. Did not test a new installation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Colin Campbell	b27da7e0ce	Bug 15006: Introduce client_timeout in SIPconfig.xml Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network. This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. The sample config sets it to 600, but you can also define a 0 value meaning no timeout. If the parameter is not defined, it will fallback to service timeout. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Restored this patch from Colin in order to separate it from the get_timeout patch. Adjusted the commit message slightly. The original value of 600 from Colin's earlier patch may give less discussion than setting to 0 (no timeout) in a later proposal. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
David Cook	ff6523765d	Bug 15555: Index 024$a into Identifier-other:u url register when source $2 is uri This patch indexes 024$a into the "phrase" index type, and the "url" index type, if the 024$2 equals "uri". TEST PLAN 1) Apply the patch. 1b) If you're using a gitified Koha or a git install, you'll need to upgrade your instance or copy your zebradb files over to /etc/koha/zebradb or your "kohadev" directory. 2) Add a 024$a with a URL like http://libris.kb.se/resource/bib/219553 to a bibliographic record 3) Re-index Zebra 4) Type "id-other,st-urx,fuzzy=http://libris.kb.se/resource/bib/219553" into the "Search the catalog" box in the Staff Client and search 5) Note that you retrieve your record NOTE: The fuzzy is required because Koha's query "parsing" functions change http:// to http=// which won't correctly match the value in the "Identifier-other:u" index. NOTE: Alternatively, you could do the following search instead: "id-other,phr=http libris kb se resource bib 219553". It would work as well by using the "Identifier-other:p" index. Advanced tester version: 4) In a terminal window, find the "koha-conf.xml" file in your "etc" directory. 5) Open "koha-conf.xml" and find <listen id="biblioserver">. Copy the URI you find there. (e.g. unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket). 6) Type "yaz-client unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket" 7) After it connects, type "base biblios" and press enter 8) Type "format xml" and press enter 9) Type "elements zebra::index" and press enter 10) Type "f id-other,st-urx=http://libris.kb.se/resource/bib/219553" and press enter 11) Note that you should have at least one result 12) Type "show 1" 13) If you scroll through the results, you should find something like the following: <index name="Identifier-other" type="w" seq="28">@^</index> <index name="Identifier-other" type="w" seq="1"></index> <index name="Identifier-other" type="w" seq="29">http</index> <index name="Identifier-other" type="w" seq="30">libris</index> <index name="Identifier-other" type="w" seq="31">kb</index> <index name="Identifier-other" type="w" seq="32">se</index> <index name="Identifier-other" type="w" seq="33">resource</index> <index name="Identifier-other" type="w" seq="34">bib</index> <index name="Identifier-other" type="w" seq="35">219553</index> <index name="Identifier-other" type="p" seq="28">http libris kb se resource bib 219553</index> <index name="Identifier-other" type="u" seq="36">http://libris.kb.se/resource/bib/219553</index> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised the record is retrieved Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Some of the statements in the commit message do not work for me. A search like "id-other,phr=http libris kb se resource bib 219553" does not have results. Searching for "id-other,phr=libris.kb.se resource" does. The steps in the advanced tester version do not work for me too. I verified the following in yaz-client: [1] Z> f @attr 1=9012 @attr 4=104 http://libris.kb.se/resource/bib/219553 Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 1, setno 16 [2] First removed $2 and reindexed. Then searched again: Z> f @attr 1=9012 @attr 4=104 http://libris.kb.se/resource/bib/219553 Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 0, setno 1 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
Tomás Cohen Arazi	a96adaadb2	Bug 16222: (QA followup) Add /api dir for the API Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>	8 years ago
Barton Chittenden	2a8c68936d	Bug 14277: (QA followup) Silent GRS-1 tests changed ocurrences of 'lex' to 'lexile-number' in record.abs Edits were made to the deprecated file record.abs solely to quiet warnings in tests -- this makes sense until GRS-1 code is removed from Koha. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>	8 years ago
Barton Chittenden	690ab60da2	Bug 14277: add zebra indexes for lexile that respect 521 indicator 1. Added the following indexes: Interest-age-level \| 591$a ind1=1 Interest-grade-level \| 591$a ind1=2 lexile-number \| 591$a ind1=8 Reading-grade-level \| 591$a ind1=0 Moved 'lex' from a zebra index to a ccl alias to lexile-number. Changed the handling of st-numeric in C4/Search.pm to allow for search ranges. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>	9 years ago
Kyle Hall	59266cbd61	Bug 14512 - Add support for AV field to Koha's SIP2 Server Koha's SIP2 server should have support for the AV field ( field items ). The biggest problem with this field is that its' contents are not really defined in SIP2 protocol specification. All it says is "this field should be sent for each fine item". Due to this, I think the contents of the field need to be configurable at the login level, so that the contents can be defined based on the SIP2 devices requirements for the AV field. Test Plan: 1) Apply this patch 2) Find a patron with outstanding fines 3) Run a patron information request using misc/sip_cli_emulator.pl using the new -s option with the value " Y " 4) Note there is an AV field for each fee containing the description and amount 5) Edit your sip config, add an av_field_template parameter to the login you are using such as av_field_template="TEST [% accountline.description %] [% accountline.amountoutstanding \| format('%.2f') %]" 6) Restart your SIP server 7) Repeat the patron information request 8) Note your custom AV field is being used! Signed-off-by: Chris Davis <cgdavis@uintah.utah.gov> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>	9 years ago
Nicole C Engard	39f9b9ddb0	Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm Hector signing-off. A simple Zebra server restart suffice to get working the searches on date-time-last-modified and dtlm. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>	8 years ago
Nicholas van Oudtshoorn	8c9fe6b2dd	Bug 12549: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Allows for selection of DejaVu font path when installing from the command line. This is useful for non-debian distributions that don't store the fonts in the same place. Adds a new configuration variable to Makefile.PL: FONT_DIR Defaults to the Debian install location for the fonts. Test plan: 1. Run a CLI install, accepting the defaults. 2. Compare the generated koha-conf.xml to a previous install - the font path for DejaVu fonts should be the same. 3. Run another CLI install, this time choosing a custom path for the fonts 4. Check that the path selected is reflected in the koha-conf.xml file. NOTE: 'perl Makefile.pl' and 'make' generates blib/KOHA_CONF_DIR/koha-conf.xml ran with a weird string for the font dir copied that koha-conf.xml to my home dir reran with all defaults compared the two, and only the font paths differed. Also, I cleaned up the tabs that snuck in. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	9 years ago
Zeno Tajoli	cc878aee77	Bug 14332: Skip articles in MARC21 using indicator n.2 of field 245 Only in MARC21 is possible to use ind2 of tag 245 to skip articles. This patch is based on inserting a special template in koha-indexdefs-to-zebra.xsl With this patch you must not insert index Title:s in biblio-koha-indexdefs.xml, it is defined in koha-indexdefs-to-zebra.xsl. It is not the best setup, but I find very difficult to use biblio-koha-indexdefs.xml. To test it in a english MARC21 setup: Insert same records with titles and correct values in ind2 of 245. If you have articles not in the skiping list of sort-string-utf.chr (The\|the\|a\|A\|an\|An) you can see that the sort by articles use also articles. Insert the patch Rebuilt indexes from scratch Now all articles of titles are skipped TO TEST WITHOUT INDEXING: 1. Go to etc/zebradb/marc_defs/marc21/biblios directory. 2. Put the sample MARCXML file in this directory. 3. Transform the file into Zebra indexes: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: 01 Business and Technologies 4. Apply the patch. 5. Repeat: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: Business and Technologies Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Verified working using yaz-client (as in http://wiki.koha-community.org/wiki/Understanding_Zebra_indexing#Examine_Zebra_index, though note that the `elem zebra::index` seems to be unneeded). Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>	9 years ago
Nicholas van Oudtshoorn	3d7bb7647d	Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora. Test plan: Without this patch, doing a zebra reindex on a fedora-based install will cause errors like this: 15:10:47-01/05 zebraidx(16108) [warn] No such record type: dom./etc/koha/zebradb/biblios/etc/dom-config.xml With this patch, reindexing should just work. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> I have tested this doesn't break on debian/ubuntu systems, someone with a non debian system will need to test it on that Signed-off-by: Bob Ewart bob-ewart@bobsown.com It works on openSUSE Leap 42.1 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Just noting that the debian zebra files already contain much more paths here. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	9 years ago
David Cook	dd9a4ed6c6	Bug 15198: Make OpacSuppression work even if there are no records suppressed This patch adds the Zebra special attribute 14 to ccl.properties and opac-search.pl, so that we can turn on OpacSuppression and still return results even if there are no records in Zebra for the Suppress index. _TEST PLAN_ Before applying: 1) Make sure that you have no suppressed records indexed in Zebra 2) Turn on OpacSuppression system preference 3) Search using a keyword which should bring up records 4) Note that no records are returned in the results 5) Change UseQueryParser system preference to "Try" 6) Repeat steps 3-4 Apply the patch. After applying: 7) Repeat step 3 (ie search using a keyword which should bring up records) 8) Confirm that records are appearing in the results! 9) Change UseQueryParser system preference to "Do not try" 10) Repeat step 3 11) Confirm that records are appearing in the results! Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. No more, won't need to have at least one record with the value "1" in the field mapped with this index. All records in OPAC returned. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Kyle Hall	181d3aa56d	Bug 13411: Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Fridolin Somers	b11eb03a4c	Bug 14542: Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as ’ in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code ’ instead of the unicode character) - Without the patch - Create a record with title : L’avion d’argile - Index this record - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You do not find the record - Apply patch - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You find the record - Search for "L avion d argile" => You find the record Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Julian Maurice	2cd6bce442	Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Julian Maurice	93a88eaaf6	Bug 13799: Change Mojolicious default mode to 'production' This avoid getting a debug page when URL is wrong. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Julian Maurice	c83cd77411	Bug 13799: RESTful API with Mojolicious and Swagger2 Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t All API stuff is in /api/v1 (except Perl modules) So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification Change both OPAC and Intranet VirtualHosts to access the API, so we have: http://OPAC/api/v1/swagger.json Swagger specification http://OPAC/api/v1/{path} API endpoint http://INTRANET/api/v1/swagger.json Swagger specification http://INTRANET/api/v1/{path} API endpoint Add a (disabled) virtual host in Apache configuration api.HOSTNAME, so we have: http://api.HOSTNAME/api/v1/swagger.json Swagger specification http://api.HOSTNAME/api/v1/{path} API endpoint Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious Test plan: 1/ Install Perl modules Mojolicious and Swagger2 2/ perl Makefile.PL 3/ make && make install 4/ Change etc/koha-httpd.conf and copy it to the right place if needed 5/ Reload Apache 6/ Check that http://(OPAC\|INTRANET)/api/v1/borrowers and http://(OPAC\|INTRANET)/api/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://(OPAC\|INTRANET)/vX/borrowers (where X is an integer greater than 1) returns a 404 error Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Hector Eduardo Castro Avalos	de272e5b41	Bug 14198: RDA: Indexing 264 field (Zebra) This patch add zebra indexes to RDA 264 field. The new Provider index is added too. QA comments corrected. To test: 1) Download RDA records with 264 fields from this attachment <http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36825>. Import the file and re-index/rebuild zebra. These records contain 260 and 264 fields per record. 2) Do a search with pb:Bethany two records will appear with title The guardian. Search with pl:Minneapolis too, the two records will appear. 3) Select one record of both records and delete the 260 field keeping the 264 field and save, rebuild your zebra. 4) Search again with pb:Bethany and just one record will appear. Thats mean 264 is not indexed. 5) Apply patches. 6) Rebuild your zebra but this time all biblio records. 7) Search again with pv:Bethany or Provider:Bethany, this time will appear the two records, 264 is indexed. Note that if you search again with pb only one record appear. This is because the suggestion of LOC. 10) Search with copydate:2013 only launch records with 260 fields and pv:2013 show both fields, i.e., 260 and 264. 11) Apply QA Test Tools Sponsored-by: Universidad de El Salvador Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Magnus Enger	9faada90bc	Bug 14824: Fix sorting of Norwegian vowels Currently, Norwegian vowels are not sorted correctly, even when you have chosen "nb" as the ZEBRA_LANGUAGE during installation. To test: - Make sure you have three records with titles that begin with ÆØÅ respectively - Do a search that turns up those three records and some others, and sort the results by title, bot ascending and descending. - Verify that ÆØÅ is shown in some weird order. - Edit your sort-string-utf.chr* so it is in line with the current patch. It should include these two lines: lowercase {0-9}{a-z}æøå uppercase {0-9}{A-Z}ÆØÅ - Restart Zebra and reindex all the records, e.g.: $ sudo koha-restart-zebra <instancename> $ sudo koha-rebuild-zebra -f -v <instancename> - Do the search again, make sure you order by title and check that ÆØÅ are sorted in the order of 1. Æ 2. Ø 3. Å, and after all other characters * = If you are on a gitified install, you need to edit this file: /etc/koha/zebradb/lang_defs/<your ZEBRA_LANGUAGE>/sort-string-utf.chr NOT the file in your git clone (yeah, i wasted some time there...) Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Tomás Cohen Arazi	9c3efeaab7	Bug 14106: (RM followup) sick of failing tests in Jessie This patch adds the original fix for source installs too... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Fridolin Somers	aaf3ff3fec	Bug 14154: 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In DOM config file : etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml, the 608$9 is defined a second time instead of 610$9. Just a type I think. Test plan : - Apply patch - Install a UNIMARC + DOM instance - Define in a framework 610 using a thesaurus - Create a new biblio - Create a new authority (same type as the thesaurus defined above) - Index : rebuild_zebra.pl -a -b -x -z - Link the field 610 to the new authority - Index : rebuild_zebra.pl -a -b -x -z - In authorities search, search for the new authority => You see Use in 1 Records(s) Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the typo. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago

1 2 3 4 5 ...

479 Commits (v21.05.01)