Bug 33282: Feed an array of titles so that no dialog message appears

Including but not limited to the one we're testing for

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

t/cypress/integration/Dialog.spec.ts → t/cypress/integration/Dialog_spec.ts

@@ -88,7 +88,15 @@ describe("Dialog operations", () => {
         cy.get("main div[class='dialog message']").contains("Package created");
         cy.get("main div[class='dialog message']").should("have.length", 1);
 
-        cy.get("#navmenulist").contains("Agreements").click();
+        cy.intercept("GET", "/api/v1/erm/eholdings/local/titles*", {
+            statusCode: 200,
+            body: [cy.get_title()],
+            headers: {
+                "X-Base-Total-Count": "1",
+                "X-Total-Count": "1",
+            },
+        });
+        cy.get("#navmenulist").contains("Titles").click();
         // Info messages should be cleared when view is changed
         cy.get("main div[class='dialog message']").should("not.exist");
     });

t/cypress/integration/Titles_spec.ts

@@ -2,55 +2,6 @@ import { mount } from "@cypress/vue";
 const dayjs = require("dayjs"); /* Cannot use our calendar JS code, it's in an include file (!)
                                    Also note that moment.js is deprecated */
 
-function get_title() {
-    return {
-        access_type: "access type",
-        biblio_id: null,
-        coverage_depth: "coverage depth",
-        date_first_issue_online: "date first",
-        date_last_issue_online: "date last",
-        date_monograph_published_online: "date mono online",
-        date_monograph_published_print: "date mono print",
-        embargo_info: "embargo info",
-        external_id: "",
-        first_author: "first author",
-        first_editor: "first editor",
-        monograph_edition: "monograph edition",
-        monograph_volume: "monograph volume",
-        notes: "notes",
-        num_first_issue_online: "num first issue",
-        num_first_vol_online: "num first vol",
-        num_last_issue_online: "num last issue",
-        num_last_vol_online: "num last vol",
-        online_identifier: "online identifier",
-        parent_publication_title_id: "parent id",
-        preceeding_publication_title_id: "preceeding id",
-        print_identifier: "print identifier",
-        publication_title: "publication title",
-        publication_type: "journal",
-        publisher_name: "publication name",
-        resources: [
-            {
-                ended_on: null,
-                package: {
-                    content_type: "",
-                    package_id: 1,
-                    name: "first package name"
-                },
-                package_id: 1,
-                resource_id: 2,
-                title: {
-                    biblio_id: 439,
-                    title_id: 1,
-                },
-                title_id: 1
-            }
-        ],
-        title_id: 1,
-        title_url: "title url"
-      };
-}
-
 function get_packages_to_relate() {
     return [
         {
@@ -82,7 +33,7 @@ describe("Title CRUD operations", () => {
     });
 
     it("Import titles", () => {
-        let erm_title = get_title();
+        let erm_title = cy.get_title();
         let resource = erm_title.resources[0];
 
         // Create a list in case none exists
@@ -146,7 +97,7 @@ describe("Title CRUD operations", () => {
         cy.get("#titles_list").contains("There are no titles defined");
 
         // GET titles returns something
-        let erm_title = get_title();
+        let erm_title = cy.get_title();
         let titles = [erm_title];
 
         cy.intercept("GET", "/api/v1/erm/eholdings/local/titles*", {
@@ -157,11 +108,6 @@ describe("Title CRUD operations", () => {
                 "X-Total-Count": "1",
             },
         });
-        cy.intercept(
-            "GET",
-            "/api/v1/erm/eholdings/local/titles/*",
-            erm_title
-        );
         cy.visit("/cgi-bin/koha/erm/eholdings/local/titles");
         cy.get("#titles_list").contains("Showing 1 to 1 of 1 entries");
     });
@@ -184,7 +130,7 @@ describe("Title CRUD operations", () => {
         cy.get("#titles_add h2").contains("New title");
 
         // Fill in the form for normal attributes
-        let erm_title = get_title();
+        let erm_title = cy.get_title();
 
         cy.get("#titles_add").contains("Submit").click();
         cy.get("input:invalid,textarea:invalid,select:invalid").should(
@@ -257,7 +203,7 @@ describe("Title CRUD operations", () => {
     });
 
     it("Edit title", () => {
-        let erm_title = get_title();
+        let erm_title = cy.get_title();
         let titles = [erm_title];
         // Click the 'Edit' button from the list
         cy.intercept("GET", "/api/v1/erm/eholdings/local/titles*", {
@@ -334,7 +280,7 @@ describe("Title CRUD operations", () => {
     });
 
     it("Show title", () => {
-        let erm_title = get_title();
+        let erm_title = cy.get_title();
         let titles = [erm_title];
         // Click the "name" link from the list
         cy.intercept("GET", "/api/v1/erm/eholdings/local/titles*", {
@@ -406,7 +352,7 @@ describe("Title CRUD operations", () => {
     });
 
     it("Delete title", () => {
-        let erm_title = get_title();
+        let erm_title = cy.get_title();
         let titles = [erm_title];
 
         // Click the 'Delete' button from the list

t/cypress/support/index.js

@@ -19,6 +19,55 @@ import './commands';
 // Alternatively you can use CommonJS syntax:
 // require('./commands')
 
+cy.get_title = () => {
+    return {
+        access_type: "access type",
+        biblio_id: null,
+        coverage_depth: "coverage depth",
+        date_first_issue_online: "date first",
+        date_last_issue_online: "date last",
+        date_monograph_published_online: "date mono online",
+        date_monograph_published_print: "date mono print",
+        embargo_info: "embargo info",
+        external_id: "",
+        first_author: "first author",
+        first_editor: "first editor",
+        monograph_edition: "monograph edition",
+        monograph_volume: "monograph volume",
+        notes: "notes",
+        num_first_issue_online: "num first issue",
+        num_first_vol_online: "num first vol",
+        num_last_issue_online: "num last issue",
+        num_last_vol_online: "num last vol",
+        online_identifier: "online identifier",
+        parent_publication_title_id: "parent id",
+        preceeding_publication_title_id: "preceeding id",
+        print_identifier: "print identifier",
+        publication_title: "publication title",
+        publication_type: "journal",
+        publisher_name: "publication name",
+        resources: [
+            {
+                ended_on: null,
+                package: {
+                    content_type: "",
+                    package_id: 1,
+                    name: "first package name"
+                },
+                package_id: 1,
+                resource_id: 2,
+                title: {
+                    biblio_id: 439,
+                    title_id: 1,
+                },
+                title_id: 1
+            }
+        ],
+        title_id: 1,
+        title_url: "title url"
+      };
+}
+
 cy.get_agreements_to_relate = () => {
     return [
         {