#!/usr/bin/perl # Tests for SIP::ILS::Transaction # Current state is very rudimentary. Please help to extend it! use Modern::Perl; use Test::More tests => 12; use Koha::Database; use t::lib::TestBuilder; use t::lib::Mocks; use C4::SIP::ILS; use C4::SIP::ILS::Patron; use C4::SIP::ILS::Transaction::RenewAll; use C4::SIP::ILS::Transaction::Checkout; use C4::SIP::ILS::Transaction::FeePayment; use C4::SIP::ILS::Transaction::Hold; use C4::SIP::ILS::Transaction::Checkout; use C4::SIP::ILS::Transaction::Checkin; use C4::Reserves; use Koha::CirculationRules; use Koha::Item::Transfer; use Koha::DateUtils qw( dt_from_string output_pref ); my $schema = Koha::Database->new->schema; $schema->storage->txn_begin; my $builder = t::lib::TestBuilder->new(); my $borr1 = $builder->build({ source => 'Borrower' }); my $card = $borr1->{cardnumber}; my $sip_patron = C4::SIP::ILS::Patron->new( $card ); # Create transaction RenewAll, assign patron, and run (no items) my $transaction = C4::SIP::ILS::Transaction::RenewAll->new(); is( ref $transaction, "C4::SIP::ILS::Transaction::RenewAll", "New transaction created" ); is( $transaction->patron( $sip_patron ), $sip_patron, "Patron assigned to transaction" ); isnt( $transaction->do_renew_all, undef, "RenewAll on zero items" ); subtest fill_holds_at_checkout => sub { plan tests => 6; my $category = $builder->build({ source => 'Category', value => { category_type => 'A' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, categorycode=>$category->{categorycode} } }); t::lib::Mocks::mock_userenv({ branchcode => $branch->{branchcode}, flags => 1 }); my $itype = $builder->build({ source => 'Itemtype', value =>{notforloan=>0} }); my $item1 = $builder->build_sample_item({ barcode => 'barcode4test', homebranch => $branch->{branchcode}, holdingbranch => $branch->{branchcode}, itype => $itype->{itemtype}, notforloan => 0, })->unblessed; my $item2 = $builder->build_sample_item({ homebranch => $branch->{branchcode}, holdingbranch => $branch->{branchcode}, biblionumber => $item1->{biblionumber}, itype => $itype->{itemtype}, notforloan => 0, })->unblessed; Koha::CirculationRules->set_rules( { categorycode => $borrower->{categorycode}, branchcode => $branch->{branchcode}, itemtype => $itype->{itemtype}, rules => { onshelfholds => 1, reservesallowed => 3, holds_per_record => 3, issuelength => 5, lengthunit => 'days', } } ); my $reserve1 = AddReserve( { branchcode => $branch->{branchcode}, borrowernumber => $borrower->{borrowernumber}, biblionumber => $item1->{biblionumber} } ); my $reserve2 = AddReserve( { branchcode => $branch->{branchcode}, borrowernumber => $borrower->{borrowernumber}, biblionumber => $item1->{biblionumber} } ); my $bib = Koha::Biblios->find( $item1->{biblionumber} ); is( $bib->holds->count(), 2, "Bib has 2 holds"); my $sip_patron = C4::SIP::ILS::Patron->new( $borrower->{cardnumber} ); my $sip_item = C4::SIP::ILS::Item->new( $item1->{barcode} ); my $transaction = C4::SIP::ILS::Transaction::Checkout->new(); is( ref $transaction, "C4::SIP::ILS::Transaction::Checkout", "New transaction created" ); is( $transaction->patron( $sip_patron ), $sip_patron, "Patron assigned to transaction" ); is( $transaction->item( $sip_item ), $sip_item, "Item assigned to transaction" ); my $checkout = $transaction->do_checkout(); use Data::Dumper; # Temporary debug statement is( $bib->holds->count(), 1, "Bib has 1 holds remaining") or diag Dumper $checkout; t::lib::Mocks::mock_preference('itemBarcodeInputFilter', 'whitespace'); $sip_item = C4::SIP::ILS::Item->new( ' barcode 4 test '); $transaction = C4::SIP::ILS::Transaction::Checkout->new(); is( $sip_item->{barcode}, $item1->{barcode}, "Item assigned to transaction" ); }; subtest "FeePayment->pay tests" => sub { plan tests => 5; # Create a borrower and add some outstanding debts to their account my $patron = $builder->build( { source => 'Borrower' } ); my $account = Koha::Account->new( { patron_id => $patron->{borrowernumber} } ); my $debt1 = $account->add_debit( { type => 'ACCOUNT', amount => 100, interface => 'commandline' } ); my $debt2 = $account->add_debit( { type => 'ACCOUNT', amount => 200, interface => 'commandline' } ); # Instantiate a new FeePayment transaction object my $trans = C4::SIP::ILS::Transaction::FeePayment->new(); is( ref $trans, "C4::SIP::ILS::Transaction::FeePayment", "New fee transaction created" ); # Test the 'pay' method # FIXME: pay should not require a borrowernumber # (we should reach out to the transaction which should contain a patron object) my $pay_type = '00'; # 00 - Cash, 01 - VISA, 02 - Creditcard my $ok = $trans->pay( $patron->{borrowernumber}, 100, $pay_type, $debt1->id, 0, 0 ); ok( $ok, "FeePayment transaction succeeded" ); $debt1->discard_changes; is( $debt1->amountoutstanding + 0, 0, "Debt1 was reduced to 0 as expected" ); my $offsets = Koha::Account::Offsets->search( { debit_id => $debt1->id, credit_id => { '!=' => undef } } ); is( $offsets->count, 1, "FeePayment produced an offset line correctly" ); my $credit = $offsets->next->credit; is( $credit->payment_type, 'SIP00', "Payment type was set correctly" ); }; subtest cancel_hold => sub { plan tests => 7; my $library = $builder->build_object ({ class => 'Koha::Libraries' }); my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, } } ); t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode, flags => 1 }); my $item = $builder->build_sample_item({ library => $library->branchcode, }); Koha::CirculationRules->set_rules( { categorycode => $patron->categorycode, branchcode => $library->branchcode, itemtype => $item->effective_itemtype, rules => { onshelfholds => 1, reservesallowed => 3, holds_per_record => 3, issuelength => 5, lengthunit => 'days', } } ); my $reserve1 = AddReserve( { branchcode => $library->branchcode, borrowernumber => $patron->borrowernumber, biblionumber => $item->biblio->biblionumber, itemnumber => $item->itemnumber, } ); is( $item->biblio->holds->count(), 1, "Hold was placed on bib"); is( $item->holds->count(),1,"Hold was placed on specific item"); my $sip_patron = C4::SIP::ILS::Patron->new( $patron->cardnumber ); my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); my $transaction = C4::SIP::ILS::Transaction::Hold->new(); is( ref $transaction, "C4::SIP::ILS::Transaction::Hold", "New transaction created" ); is( $transaction->patron( $sip_patron ), $sip_patron, "Patron assigned to transaction" ); is( $transaction->item( $sip_item ), $sip_item, "Item assigned to transaction" ); my $hold = $transaction->drop_hold(); is( $item->biblio->holds->count(), 0, "Bib has 0 holds remaining"); is( $item->holds->count(), 0, "Item has 0 holds remaining"); }; subtest do_hold => sub { plan tests => 8; my $library = $builder->build_object( { class => 'Koha::Libraries' } ); my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, } } ); my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, categorycode => $patron_1->categorycode, } } ); t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode, flags => 1 } ); my $item = $builder->build_sample_item( { library => $library->branchcode, } ); my $reserve1 = AddReserve( { branchcode => $library->branchcode, borrowernumber => $patron_1->borrowernumber, biblionumber => $item->biblio->biblionumber, itemnumber => $item->itemnumber, } ); is( $item->biblio->holds->count(), 1, "Hold was placed on bib" ); is( $item->holds->count(), 1, "Hold was placed on specific item" ); my $sip_patron = C4::SIP::ILS::Patron->new( $patron_2->cardnumber ); my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); my $transaction = C4::SIP::ILS::Transaction::Hold->new(); is( ref $transaction, "C4::SIP::ILS::Transaction::Hold", "New transaction created" ); is( $transaction->patron($sip_patron), $sip_patron, "Patron assigned to transaction" ); is( $transaction->item($sip_item), $sip_item, "Item assigned to transaction" ); my $hold = $transaction->do_hold(); is( $item->biblio->holds->count(), 2, "Bib has 2 holds" ); my $THE_hold = $patron_2->holds->next; is( $THE_hold->priority, 2, 'Hold placed from SIP should have a correct priority of 2'); is( $THE_hold->branchcode, $patron_2->branchcode, 'Hold placed from SIP should have the branchcode set' ); }; subtest do_checkin => sub { plan tests => 12; my $library = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, } } ); t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode, flags => 1 } ); my $item = $builder->build_sample_item( { library => $library->branchcode, } ); # Checkout my $sip_patron = C4::SIP::ILS::Patron->new( $patron->cardnumber ); my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); my $co_transaction = C4::SIP::ILS::Transaction::Checkout->new(); is( $co_transaction->patron($sip_patron), $sip_patron, "Patron assigned to transaction" ); is( $co_transaction->item($sip_item), $sip_item, "Item assigned to transaction" ); my $checkout = $co_transaction->do_checkout(); is( $patron->checkouts->count, 1, 'Checkout should have been done successfully'); # Checkin my $ci_transaction = C4::SIP::ILS::Transaction::Checkin->new(); is( $ci_transaction->patron($sip_patron), $sip_patron, "Patron assigned to transaction" ); is( $ci_transaction->item($sip_item), $sip_item, "Item assigned to transaction" ); my $checkin = $ci_transaction->do_checkin($library->branchcode, C4::SIP::Sip::timestamp); is( $patron->checkouts->count, 0, 'Checkin should have been done successfully'); # Test checkin without return date $co_transaction->do_checkout; is( $patron->checkouts->count, 1, 'Checkout should have been done successfully'); $ci_transaction->do_checkin($library->branchcode, undef); is( $patron->checkouts->count, 0, 'Checkin should have been done successfully'); my $result = $ci_transaction->do_checkin($library2->branchcode, undef); is($ci_transaction->alert_type,'04',"Checkin of item no issued at another branch succeeds"); is_deeply( $result, { messages => { 'NotIssued' => $item->barcode, 'WasTransfered' => $library->branchcode, 'TransferTrigger' => 'ReturnToHome' } }, "Messages show not issued and transferred" ); is( $ci_transaction->item->destination_loc,$library->branchcode,"Item destination correctly set"); subtest 'Checkin an in transit item' => sub { plan tests => 5; my $library_1 = $builder->build_object({ class => 'Koha::Libraries' }); my $library_2 = $builder->build_object({ class => 'Koha::Libraries' }); my $patron = $builder->build_object({ class => 'Koha::Patrons', value => {branchcode => $library_1->branchcode, }}); my $sip_patron = C4::SIP::ILS::Patron->new( $patron->cardnumber ); my $item = $builder->build_sample_item({ library => $library_1->branchcode }); my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); t::lib::Mocks::mock_userenv( { branchcode => $library_1->branchcode, flags => 1 } ); my $reserve = AddReserve( { branchcode => $library_1->branchcode, borrowernumber => $patron->borrowernumber, biblionumber => $item->biblionumber, } ); ModReserveAffect( $item->itemnumber, $patron->borrowernumber ); # Mark waiting my $ci_transaction = C4::SIP::ILS::Transaction::Checkin->new(); is( $ci_transaction->patron($sip_patron), $sip_patron, "Patron assigned to transaction" ); is( $ci_transaction->item($sip_item), $sip_item, "Item assigned to transaction" ); my $checkin = $ci_transaction->do_checkin($library_2->branchcode, C4::SIP::Sip::timestamp); my $hold = Koha::Holds->find($reserve); is( $hold->found, 'T', ); is( $hold->itemnumber, $item->itemnumber, ); is( Koha::Checkouts->search({itemnumber => $item->itemnumber})->count, 0, ); }; }; subtest do_checkout_with_holds => sub { plan tests => 7; my $library = $builder->build_object( { class => 'Koha::Libraries' } ); my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, } } ); my $patron2 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, } } ); t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode, flags => 1 } ); my $item = $builder->build_sample_item( { library => $library->branchcode, } ); my $reserve = AddReserve( { branchcode => $library->branchcode, borrowernumber => $patron2->borrowernumber, biblionumber => $item->biblionumber, } ); my $sip_patron = C4::SIP::ILS::Patron->new( $patron->cardnumber ); my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); my $co_transaction = C4::SIP::ILS::Transaction::Checkout->new(); is( $co_transaction->patron($sip_patron), $sip_patron, "Patron assigned to transaction" ); is( $co_transaction->item($sip_item), $sip_item, "Item assigned to transaction" ); # Test attached holds ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 0, $reserve ); # Mark waiting (W) my $hold = Koha::Holds->find($reserve); $co_transaction->do_checkout(); is( $patron->checkouts->count, 0, 'Checkout was not done due to attached hold (W)'); $hold->set_transfer; $co_transaction->do_checkout(); is( $patron->checkouts->count, 0, 'Checkout was not done due to attached hold (T)'); $hold->set_processing; $co_transaction->do_checkout(); is( $patron->checkouts->count, 0, 'Checkout was not done due to attached hold (P)'); # Test non-attached holds C4::Reserves::RevertWaitingStatus({ itemnumber => $hold->itemnumber }); t::lib::Mocks::mock_preference('AllowItemsOnHoldCheckoutSIP', '0'); $co_transaction->do_checkout(); is( $patron->checkouts->count, 0, 'Checkout refused due to hold and AllowItemsOnHoldCheckoutSIP'); t::lib::Mocks::mock_preference('AllowItemsOnHoldCheckoutSIP', '1'); $co_transaction->do_checkout(); is( $patron->checkouts->count, 1, 'Checkout allowed due to hold and AllowItemsOnHoldCheckoutSIP'); }; subtest checkin_lost => sub { plan tests => 2; my $library = $builder->build_object( { class => 'Koha::Libraries' } ); t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode, flags => 1 } ); my $item = $builder->build_sample_item( { library => $library->branchcode, } ); $item->itemlost(1)->itemlost_on(dt_from_string)->store(); my $instituation = { id => $library->id, implementation => "ILS", policy => { checkin => "true", renewal => "true", checkout => "true", timeout => 100, retries => 5, } }; my $ils = C4::SIP::ILS->new( $instituation ); t::lib::Mocks::mock_preference('BlockReturnOfLostItems', '1'); my $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); is( $circ->{screen_msg}, 'Item lost, return not allowed', "Got correct screen message" ); t::lib::Mocks::mock_preference('BlockReturnOfLostItems', '0'); $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); is( $circ->{screen_msg}, 'Item not checked out', "Got 'Item not checked out' screen message" ); }; subtest checkin_withdrawn => sub { plan tests => 2; my $library = $builder->build_object( { class => 'Koha::Libraries' } ); t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode, flags => 1 } ); my $item = $builder->build_sample_item( { library => $library->branchcode, } ); $item->withdrawn(1)->withdrawn_on(dt_from_string)->store(); my $instituation = { id => $library->id, implementation => "ILS", policy => { checkin => "true", renewal => "true", checkout => "true", timeout => 100, retries => 5, } }; my $ils = C4::SIP::ILS->new( $instituation ); t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems', '1'); my $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); is( $circ->{screen_msg}, 'Item withdrawn, return not allowed', "Got correct screen message" ); t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems', '0'); $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); is( $circ->{screen_msg}, 'Item not checked out', "Got 'Item not checked out' screen message" ); }; subtest item_circulation_status => sub { plan tests => 4; my $library = $builder->build_object( { class => 'Koha::Libraries' } ); my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library->branchcode, } } ); t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode, flags => 1 } ); my $item = $builder->build_sample_item( { library => $library->branchcode, } ); my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); my $status = $sip_item->sip_circulation_status; is( $status, '03', "Item circulation status is available"); my $transfer = Koha::Item::Transfer->new({ itemnumber => $item->id, datesent => '2020-01-01', frombranch => $library->branchcode, tobranch => $library2->branchcode, })->store(); $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); $status = $sip_item->sip_circulation_status; is( $status, '10', "Item circulation status is in transit" ); $transfer->delete; my $claim = Koha::Checkouts::ReturnClaim->new({ itemnumber => $item->id, borrowernumber => $patron->id, created_by => $patron->id, })->store(); $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); $status = $sip_item->sip_circulation_status; is( $status, '11', "Item circulation status is claimed returned" ); $claim->delete; $item->itemlost(1)->store(); $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); $status = $sip_item->sip_circulation_status; is( $status, '12', "Item circulation status is lost" ); }; $schema->storage->txn_rollback;