Koha/koha-tmpl/intranet-tmpl/prog/en/modules/reports
Jonathan Druart 00020bdfa9
Bug 24305: Fix links to batch tools when report's columns do not contain integers
If report's columns do not only contain integers, we should not point to
batch tools.
For instance, if the value is a link, the batch tools will not work as
they will not retrieve the id (itemnnumber or biblionumber) properly

Test plan:
Create a report like:
    SELECT CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', biblionumber, '&itemnumber=', itemnumber, '#edititem', '\">', itemnumber, '</a>' ) AS itemnumber
    FROM items
    LIMIT 10;
Execute it
=> There is not link to the batch tools

Edit the report like:
    SELECT itemnumber
    FROM items
    LIMIT 10;
Execute it
=> There is a link to the batch tools

Edit the report like

    SELECT itemnumber, CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', biblionumber, '&itemnumber=', itemnumber, '#edititem', '\">', itemnumber, '</a>' ) AS itemnumber
    FROM items
    LIMIT 10;
Execute it
=> There is link to the batch tools

Try other combinations with biblionumber.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-01-24 15:19:33 +00:00
..
csv
acquisitions_stats.tt
bor_issues_top.tt
borrowers_out.tt
borrowers_stats.tt
cash_register_stats.tt Bug 23805: (QA follow-up) Corrections for cash_register_stats 2019-10-31 17:49:54 +00:00
cat_issues_top.tt
catalogue_out.tt
catalogue_stats.tt
convert_report.tt
dictionary.tt Bug 23227: Remove type attribute from script tags: Reports 2019-07-15 11:27:58 +01:00
guided_reports_start.tt Bug 24305: Fix links to batch tools when report's columns do not contain integers 2020-01-24 15:19:33 +00:00
issues_avg_stats.tt
issues_stats.tt
itemslost.tt Bug 23194: Fix other occurences 2019-07-15 11:27:58 +01:00
itemtypes.tt
orders_by_budget.tt
reports-home.tt
reserves_stats.tt
serials_stats.tt Bug 23444: Terminology - Use library instead of branch 2019-10-17 15:06:57 +01:00