Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
Jonathan Druart dcd1f5d48c Bug 13618: Add html filters to all the variables 
Here we go, next step then.
As we did not fix the performance issue when autofiltering
the variables (see bug 20975), the only solution we have is to add the
filters explicitely.

This patch has been autogenerated (using add_html_filters.pl, see next
pathces) and add the html filter to all the variables displayed in the
template.
Exceptions are made (using the new 'raw' TT filter) to the variable we
already listed in the previous versions of this patch.

To test:
- Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated
data which contain <script> tags

- Remove them from borrower_debarments.comments (there are allowed here)
update  borrower_debarments set comment="html tags possible here";

- From the interface hit page and try to catch alert box.
If you find one it means you find a possible XSS.
To know where it comes from:
* note the exact URL where you found it
* note the alert box content
* Dump your DB and search for the string in the dump to identify its
location (for instance table.field)

Next:
* Ideally we would like to use the raw filter when it is not necessary
to HTML escape the variables (in big loop for instance)
* Provide a QA script to catch missing filters (we want html, uri, url
or raw, certainly others that I am forgetting now)
* Replace the html filters with uri when needed (!)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-17 15:55:05 +00:00

186 lines
7.1 KiB
Text
Raw Blame History

[% USE Branches %]
[% USE KohaDates %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Serials &rsaquo; Check expiration</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="ser_checkexpiration" class="ser">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'serials-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> &rsaquo; Check expiration </div>
<div id="doc3" class="yui-t2">
<div id="bd">
<div id="yui-main">
<div class="yui-b">
<h1>Check expiration</h1>
<form name="f" action="/cgi-bin/koha/serials/checkexpiration.pl" method="get" class="validated">
<fieldset class="rows">
<legend>Filter results:</legend>
<ol>
<li><label for="title">Title:</label>
<input id="title" type="text" name="title" size="15" value="[% title | html %]" /></li>
<li><label for="issn">ISSN:</label>
<input id="issn" type="text" name="issn" size="15" value="[% issn | html %]" /></li>
[% IF can_change_library %]
<li><label for="branch">Library:</label>
<select id="branch" name="branch">
<option value="">All</option>
[% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
</select>
</li>
[% END %]
<li><label for="date" class="required">Expiring before:</label>
<input id="date" type="text" name="date" size="10" value="[% date | $KohaDates %]" class="required focus datepicker" required="required" />
<span class="required">Required</span>
<div class="hint">[% INCLUDE 'date-format.inc' %]</div></li>
</ol>
</fieldset>
<fieldset class="action"><input type="submit" value="Search" /></fieldset>
</form>
[% IF ( subscriptions_loop ) %]
<p>
<b>[% numsubscription | html %]</b> subscription(s)
[% IF ( title ) %]
with title matching <span class="title">[% title | html %]</class>
[% IF ( issn ) %]and [% END %]
[% END %]
[% IF ( issn ) %]
with ISSN matching <b>[% issn | html %]</b>
[% END %]
will expire before <b>[% date | $KohaDates %]</b>
</p>
<div class="checkexpiration-table_table_controls">
<a href="#" class="SelectAll"><i class="fa fa-check"></i> Select all</a> |
<a href="#" class="ClearAll"><i class="fa fa-remove"></i> Clear all</a>
<span class="itemselection_actions">
| Actions:
<a class="itemselection_action_renew" title="Renew selected subscriptions"><i class="fa fa-refresh"></i> Renew selected subscriptions</a>
</span>
</div>
<table>
<tr>
<th></th>
<th>ISSN</th>
<th>Title</th>
[% IF can_change_library %]<th>Library</th>[% END %]
<th>OPAC note</th>
<th>Nonpublic note</th>
<th>Expiration date</th>
<th>Actions</th>
</tr>
[% FOREACH subscriptions_loo IN subscriptions_loop %]
<tr>
<td style="text-align:center;vertical-align:middle">
<input type="checkbox" value="[% subscriptions_loo.subscriptionid | html %]" name="subscriptionid" />
</td>
<td>
[% subscriptions_loo.issn | html %]
</td>
<td><a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptions_loo.subscriptionid |url %]">[% IF ( subscriptions_loo.title ) %]
[% subscriptions_loo.title | html %]
[% ELSE %]
|
[% END %]
</a>
</td>
[% IF can_change_library %]<td>
[% Branches.GetName( subscriptions_loo.branchcode ) | html %]
</td>[% END %]
<td>
[% subscriptions_loo.notes | html %]
</td>
<td>
[% subscriptions_loo.internalnotes | html %]
</td>
<td>
[% subscriptions_loo.expirationdate | $KohaDates %]
</td>
<td class="actions">
<a href="/cgi-bin/koha/serials/subscription-add.pl?op=modify&amp;subscriptionid=[% subscriptions_loo.subscriptionid | html %]" class="btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
<a href="/cgi-bin/koha/serials/subscription-renew.pl?subscriptionid=[% subscriptions_loo.subscriptionid | html %]" data-subscriptionid="[% subscriptions_loo.subscriptionid | html %]" class="btn btn-default btn-xs renew_subscription"><i class="fa fa-refresh"></i> Renew</a>
</td>
</tr>
[% END %]
</table>
[% ELSIF searched %]
<p>No results for your query</p>
[% END %]
</div>
</div>
<div class="yui-b">
[% INCLUDE 'serials-menu.inc' %]
</div>
</div>
[% MACRO jsinclude BLOCK %]
[% INCLUDE 'calendar.inc' %]
<script type="text/javascript" language="JavaScript">
$(document).ready(function(){
$(".renew_subscription").on("click",function(e){
e.preventDefault();
var subscriptionid = $(this).data("subscriptionid");
newin=window.open("/cgi-bin/koha/serials/subscription-renew.pl?mode=popup&subscriptionid="+subscriptionid,'popup','width=590,height=440,toolbar=false,scrollbars=yes,resize=yes');
});
$('a.itemselection_action_renew').on("click", function(e){
e.preventDefault();
newin=window.open($(this).attr('href'),'popup','width=590,height=440,toolbar=false,scrollbars=yes,resize=yes');
});
function itemSelectionBuildRenewLink() {
var subscription_ids= new Array();
$("input[name='subscriptionid'][type='checkbox']:checked").each(function() {
subscription_ids.push($(this).val());
});
if (subscription_ids.length > 0) {
var url = '/cgi-bin/koha/serials/subscription-renew.pl?op=multi_renew';
url += '&subscriptionid=' + subscription_ids.join('&subscriptionid=');
$('a.itemselection_action_renew').attr('href', url);
} else {
return false;
}
return true;
}
function itemSelectionBuildActionLinks() {
var export_link_ok = itemSelectionBuildRenewLink();
if (export_link_ok) {
$('.itemselection_actions').show();
} else {
$('.itemselection_actions').hide();
}
}
itemSelectionBuildActionLinks();
$("input[name='subscriptionid'][type='checkbox']").change(function() {
itemSelectionBuildActionLinks();
});
$(".SelectAll, .ClearAll").on("click",function(e){
e.preventDefault();
var checkboxes = $(this).parent().siblings('table').first().find('input[type="checkbox"]');
checkboxes.prop('checked', $(this).hasClass('SelectAll'));
itemSelectionBuildActionLinks();
});
});
</script>
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]
View git blame Copy permalink