Koha/C4/SIP
Kyle M Hall 017b67e6c5 Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name
This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode.
The subroutine hold_patron_bcode should always return an empty string, not undef.

Test Plan:
1) Using the SIP cli emulator, checkin an item that is not checked out
2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)"
   The hex number will almost certainly be different from this example
3) Apply this patch
4) Restart the SIP server
5) Run the SIP checkin again
6) Note the DA field is no longer present!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-06-25 10:39:37 +02:00
..
ILS Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name 2020-06-25 10:39:37 +02:00
Sip Bug 15253: Rename syslog() to siplog() 2020-05-12 11:46:46 +01:00
t
acstest.py
example_institution_dump.sh
ILS.pm Bug 23403: Catch other cases of ->{patron} 2020-05-15 09:48:35 +01:00
ILS.pod
interactive_item_dump.pl
interactive_patron_check_password.pl
interactive_patron_dump.pl
interactive_renew_all_dump.pl
Logger.pm Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm 2020-05-12 11:47:04 +01:00
Makefile
README Bug 15253: Rename syslog() to siplog() 2020-05-12 11:46:46 +01:00
Sip.pm Bug 15253: Convert all tabs into 4 spaces in affected files 2020-05-12 11:47:01 +01:00
SIPServer.pm Bug 15253: Remove specific logging output 2020-05-12 11:47:07 +01:00
test.txt
Trapper.pm Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm 2020-05-12 11:47:04 +01:00
xmlparse.pl

README for Open NSIP 3M-SIP Server

DEPENDENCIES

SIPServer is written entirely in Perl, but it require these CPAN
perl modules to run:

     Net::Server - The SIP server is a Net::Server::Prefork server
     XML::LibXML
     XML::Parser
     XML::Simple - for parsing the config file
     UNIVERSAL::require - for loading the correct ILS interface module
     Clone - for running the test cases

LOGGING

SIPServer uses Koha::Logger for status and debugging messages.