Main Koha release repository https://koha-community.org
Find a file
Slava Shishkin 024cdf269a
Bug 32504: Fix misalignment of visibility of basket orders table columns and missing export columns
To reproduce:
1. Go to /cgi-bin/koha/admin/columns_settings.pl
2. In the section Acquisition > Basket > Orders uncheck all checkboxes in the table settings
3. Go to a separate browser window to /cgi-bin/koha/acqui/booksellers.pl and open/create a new basket and add one book to it so the basket table will have rows in the "Order" table which we will configure below:
4. Click on the ["Columns" settings] for the table.
5. In the dropdown menu, observe that all Columns are marked as visible and correspond to the current table display.
6. Also check the export table feature: Click on "Export" and choose print, you will see that Columns up to GST (goods_and_services_tax) are displayed, and Fund and Estimated delivery date are missing.
7. Go back to table settings (like it was in steps.1-2)
8. Make the estimated_delivery_date column 'invisible by default' by checking out the appropriate checkbox and saving the changes.
9. Refresh the basket window/page (like in step 3).
10. Observe that in the table the whole columns "Estimated delivery date" is visible but "Fund" is gone.
11. Click on the ["Columns" settings] for the table.
12. In the dropdown menu observe that the wrong column is disabled ("Fund" instead of "Estimated delivery date").
13. Apply the patch.
14. Go through steps 3-12 and make sure that everything mentioned in those steps now works correctly: when you hide any columns in columns_settings.pl they are correctly hidden for the "Order" table, as well when exporting the table, the Fund, and Estimated delivery date columns are now exported.

Note: this patch also respects Koha.Preference('EDIFACT') setting and when it's enabled it also correctly hides/shows and exports the 'supplier_report' column.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-01-31 09:39:57 -03:00
acqui Bug 32054: Add get_import_record_matches object method and use it 2023-01-18 15:58:19 +00:00
admin Bug 32504: Fix typo columnname in columns_settings.yml 2023-01-31 09:39:57 -03:00
api Bug 31797: Add DELETE /items/:item_id endpoint 2023-01-30 12:20:44 -03:00
authorities Bug 30250: Use ApplyFrameworkDefaults when importing a record 2022-11-09 14:03:22 -03:00
basket Bug 16522: (follow-up) MARC display templates and get_marc_host fixes 2023-01-30 12:10:11 -03:00
bin
C4 Bug 32431: Display expiry date on SIP checkout when patron is expired 2023-01-30 15:07:37 -03:00
catalogue Bug 32583: Restore display of only one item in catalogue/moredetails 2023-01-27 16:21:37 -03:00
cataloguing Bug 24606: (QA follow-up) Remove duplicate include 2022-11-11 15:47:36 -03:00
circ Bug 31492: Set CSRF token in circulation.pl 2023-01-18 15:46:29 +00:00
clubs
course_reserves Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-20 13:56:30 +00:00
debian Bug 32465: Add 'queue' to koha-worker help documentation 2023-01-18 15:43:46 +00:00
docs 22.11.00: Update history.txt 2022-11-25 15:20:02 -03:00
erm Bug 32030: Add missing sponsors 2022-11-09 12:25:44 -03:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 32416: Add a warning to the file 2023-01-27 16:08:23 -03:00
ill
installer Bug 32330: DBRev 22.12.00.001 2022-12-19 10:17:26 -03:00
Koha Bug 31797: Add DELETE /items/:item_id endpoint 2023-01-30 12:20:44 -03:00
koha-tmpl Bug 32504: Fix misalignment of visibility of basket orders table columns and missing export columns 2023-01-31 09:39:57 -03:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize
members Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-20 13:56:30 +00:00
misc Bug 32393: (QA follow-up) Add explicit undef response in two catch blocks 2023-01-27 15:10:01 -03:00
offline_circ
opac Bug 32712: (QA follow-up) Use Koha.Preference 2023-01-31 09:34:13 -03:00
patron_lists
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls
reports
reserve Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-20 13:56:30 +00:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials
services
skel
suggestion Bug 32531: Restore behaviour of 'include archived' filter 2023-01-05 09:22:58 -03:00
svc Bug 32631: Error when previewing record during batch record modification 2023-01-27 16:16:43 -03:00
t Bug 32431: Display expiry date on SIP checkout when patron is expired 2023-01-30 15:07:37 -03:00
tags
tmp/modified_authorities
tools Bug 32221: Borrowers.password should no longer be an option 2023-01-20 13:55:17 +00:00
virtualshelves Bug 16522: (follow-up) MARC display templates and get_marc_host fixes 2023-01-30 12:10:11 -03:00
xt Bug 32349: Remove find-nonutf8 tests 2023-01-11 20:44:26 -03:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
.gitignore Bug 32030: Add dist dir to .gitignore 2022-11-08 09:49:57 -03:00
.htaccess
.mailmap Bug 32582: Fix error in .mailmap 2023-01-17 09:27:15 +00:00
.perlcriticrc
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json
about.pl Bug 30808: Add support for version codenames 2022-11-25 15:20:00 -03:00
app.psgi
changelanguage.pl
cpanfile Bug 12758: Make LWP::Protocol::https required module 2022-11-09 09:52:13 -03:00
cypress.json Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
fix-perl-path.PL
gulpfile.js Bug 32422: Hardcoded paths in _common.scss precent using external node_modules 2022-12-12 12:19:10 -03:00
help.pl
INSTALL
Koha.pm Bug 32330: DBRev 22.12.00.001 2022-12-19 10:17:26 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl
Makefile.PL Bug 32030: Fix Makefile.t 2022-11-09 09:48:30 -03:00
MANIFEST.SKIP
package.json Bug 32212: (bug 32030 follow-up) Restore bootstrap 4 2022-11-17 14:49:07 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32030: Move cypress to t/ 2022-11-08 09:44:51 -03:00
yarn.lock Bug 32212: Updated yarn.lock 2022-11-18 12:04:29 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo