ca756f44d7
The /svc endpoint allows you to create and update biblio records. This patch extends it so that it is also possible to delete a biblio. Test plan * Create a new biblio by sending a POST request to /svc/new_bib with a marcxml record as request body. Note the biblionumber it gets assigned. * Make some changes to the marcxml record, and update it by sending a POST request to /svc/bib/{bibilonumber} * Observe that the changes are persisted on the biblio record. * Now delete the bilblio by sending a DELETE request to /svc/bib/{biblionumber} * Observe that the biblio is indeed gone from the db. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described and passes tests and QA script. I tested using curl for a record with and one without items: curl -X DELETE 'http://localhost:8080/cgi-bin/koha/svc/bib/2' --cookie /tmp/svc.cookies <?xml version='1.0' standalone='yes'?> <response> <error>This Biblio has items attached, please delete them first before deleting this biblio </error> </response> curl -X DELETE 'http://localhost:8080/cgi-bin/koha/svc/bib/3' --cookie /tmp/svc.cookies <?xml version='1.0' standalone='yes'?> <response> <status>OK, biblio deleted</status> </response> The deletion is processed correctly and the indexes are updated. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
143 lines
4.5 KiB
Perl
Executable file
143 lines
4.5 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2007 LibLime
|
|
# Copyright 2012 software.coop and MJ Ray
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
#
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI;
|
|
use C4::Auth qw/check_api_auth/;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use XML::Simple;
|
|
|
|
my $query = new CGI;
|
|
binmode STDOUT, ':encoding(UTF-8)';
|
|
|
|
my ($status, $cookie, $sessionID) = check_api_auth($query, { editcatalogue => 'edit_catalogue'} );
|
|
unless ($status eq "ok") {
|
|
print $query->header(-type => 'text/xml', -status => '403 Forbidden');
|
|
print XMLout({ auth_status => $status }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
|
|
exit 0;
|
|
}
|
|
|
|
# do initial validation
|
|
my $path_info = $query->path_info();
|
|
|
|
my $biblionumber = undef;
|
|
if ($path_info =~ m!^/(\d+)$!) {
|
|
$biblionumber = $1;
|
|
} else {
|
|
print $query->header(-type => 'text/xml', -status => '400 Bad Request');
|
|
}
|
|
|
|
# are we retrieving, updating or deleting a bib?
|
|
if ($query->request_method eq "GET") {
|
|
fetch_bib($query, $biblionumber);
|
|
} elsif ($query->request_method eq "POST") {
|
|
update_bib($query, $biblionumber);
|
|
} elsif ($query->request_method eq "DELETE") {
|
|
delete_bib($query, $biblionumber);
|
|
} else {
|
|
print $query->header(-type => 'text/xml', -status => '405 Method not allowed');
|
|
print XMLout({ error => 'Method not allowed' }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
|
|
exit 0;
|
|
}
|
|
|
|
exit 0;
|
|
|
|
sub fetch_bib {
|
|
my $query = shift;
|
|
my $biblionumber = shift;
|
|
my $record = GetMarcBiblio( $biblionumber, $query->url_param('items') );
|
|
if (defined $record) {
|
|
print $query->header(-type => 'text/xml');
|
|
print $record->as_xml_record();
|
|
} else {
|
|
print $query->header(-type => 'text/xml', -status => '404 Not Found');
|
|
}
|
|
}
|
|
|
|
sub update_bib {
|
|
my $query = shift;
|
|
my $biblionumber = shift;
|
|
my $old_record = GetMarcBiblio($biblionumber);
|
|
unless (defined $old_record) {
|
|
print $query->header(-type => 'text/xml', -status => '404 Not Found');
|
|
return;
|
|
}
|
|
|
|
my $result = {};
|
|
my $inxml = $query->param('POSTDATA');
|
|
print $query->header(-type => 'text/xml');
|
|
|
|
my $record = eval {MARC::Record::new_from_xml( $inxml, "utf8", C4::Context->preference('marcflavour'))};
|
|
my $do_not_escape = 0;
|
|
if ($@) {
|
|
$result->{'status'} = "failed";
|
|
$result->{'error'} = $@;
|
|
} else {
|
|
my $fullrecord = $record->clone();
|
|
my ( $itemtag, $itemsubfield ) =
|
|
GetMarcFromKohaField( "items.itemnumber", '' );
|
|
|
|
# delete any item tags
|
|
foreach my $field ( $record->field($itemtag) ) {
|
|
$record->delete_field($field);
|
|
}
|
|
|
|
if ( $query->url_param('items') ) {
|
|
foreach my $field ( $fullrecord->field($itemtag) ) {
|
|
my $one_item_record = $record->clone();
|
|
$one_item_record->add_fields($field);
|
|
ModItemFromMarc( $one_item_record, $biblionumber,
|
|
$field->subfield($itemsubfield) );
|
|
}
|
|
}
|
|
|
|
ModBiblio( $record, $biblionumber, '' );
|
|
my $new_record =
|
|
GetMarcBiblio( $biblionumber, $query->url_param('items') );
|
|
|
|
$result->{'status'} = "ok";
|
|
$result->{'biblionumber'} = $biblionumber;
|
|
my $xml = $new_record->as_xml_record();
|
|
$xml =~ s/<\?xml.*?\?>//i;
|
|
$result->{'marcxml'} = $xml;
|
|
$do_not_escape = 1;
|
|
}
|
|
|
|
print XMLout($result, NoAttr => 1, RootName => 'response', XMLDecl => 1, NoEscape => $do_not_escape);
|
|
}
|
|
|
|
sub delete_bib {
|
|
my $query = shift;
|
|
my $biblionumber = shift;
|
|
my $error = DelBiblio($biblionumber);
|
|
|
|
if (defined $error) {
|
|
print $query->header(-type => 'text/xml', -status => '400 Bad request');
|
|
print XMLout({ error => $error }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
|
|
exit 0;
|
|
}
|
|
|
|
print $query->header(-type => 'text/xml');
|
|
print XMLout({ status => 'OK, biblio deleted' }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
|
|
}
|