Jonathan Druart
2b90ea2cb0
GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
164 lines
5.7 KiB
Perl
Executable file
164 lines
5.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Context;
|
|
use C4::Members;
|
|
use Koha::Database;
|
|
use Koha::Patrons;
|
|
|
|
use t::lib::TestBuilder;
|
|
|
|
use Test::More tests => 31;
|
|
|
|
use_ok('Koha::Patron::Debarments');
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $library = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
|
|
my $patron_category = $builder->build({ source => 'Category' });
|
|
my $borrowernumber = AddMember(
|
|
firstname => 'my firstname',
|
|
surname => 'my surname',
|
|
categorycode => $patron_category->{categorycode},
|
|
branchcode => $library->{branchcode},
|
|
);
|
|
|
|
my $success = AddDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
expiration => '9999-06-10',
|
|
type => 'MANUAL',
|
|
comment => 'Test 1',
|
|
});
|
|
is( $success, 1, "AddDebarment returned true" );
|
|
|
|
|
|
my $debarments = GetDebarments({ borrowernumber => $borrowernumber });
|
|
is( @$debarments, 1, "GetDebarments returns 1 debarment" );
|
|
is( $debarments->[0]->{'type'}, 'MANUAL', "Correctly stored 'type'" );
|
|
is( $debarments->[0]->{'expiration'}, '9999-06-10', "Correctly stored 'expiration'" );
|
|
is( $debarments->[0]->{'comment'}, 'Test 1', "Correctly stored 'comment'" );
|
|
|
|
|
|
$success = AddDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
comment => 'Test 2',
|
|
});
|
|
|
|
$debarments = GetDebarments({ borrowernumber => $borrowernumber });
|
|
is( @$debarments, 2, "GetDebarments returns 2 debarments" );
|
|
is( $debarments->[1]->{'type'}, 'MANUAL', "Correctly stored 'type'" );
|
|
is( $debarments->[1]->{'expiration'}, undef, "Correctly stored debarrment with no expiration" );
|
|
is( $debarments->[1]->{'comment'}, 'Test 2', "Correctly stored 'comment'" );
|
|
|
|
|
|
ModDebarment({
|
|
borrower_debarment_id => $debarments->[1]->{'borrower_debarment_id'},
|
|
comment => 'Test 3',
|
|
expiration => '9998-06-10',
|
|
});
|
|
$debarments = GetDebarments({ borrowernumber => $borrowernumber });
|
|
is( $debarments->[1]->{'comment'}, 'Test 3', "ModDebarment functions correctly" );
|
|
|
|
my $patron = Koha::Patrons->find( $borrowernumber )->unblessed;
|
|
is( $patron->{'debarred'}, '9999-06-10', "Field borrowers.debarred set correctly" );
|
|
is( $patron->{'debarredcomment'}, "Test 1\nTest 3", "Field borrowers.debarredcomment set correctly" );
|
|
|
|
|
|
AddUniqueDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES'
|
|
});
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 1, "GetDebarments returns 1 OVERDUES debarment" );
|
|
is( $debarments->[0]->{'type'}, 'OVERDUES', "AddOverduesDebarment created new debarment correctly" );
|
|
|
|
AddUniqueDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
expiration => '9999-11-09',
|
|
type => 'OVERDUES'
|
|
});
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 1, "GetDebarments returns 1 OVERDUES debarment after running AddOverduesDebarment twice" );
|
|
is( $debarments->[0]->{'expiration'}, '9999-11-09', "AddOverduesDebarment updated OVERDUES debarment correctly" );
|
|
|
|
|
|
my $delUniqueDebarment = DelUniqueDebarment({
|
|
});
|
|
is( $delUniqueDebarment, undef, "DelUniqueDebarment without the arguments 'borrowernumber' and 'type' returns undef" );
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 1, "DelUniqueDebarment without the arguments 'borrowernumber' and 'type' does not delete the debarment" );
|
|
|
|
$delUniqueDebarment = DelUniqueDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
});
|
|
is( $delUniqueDebarment, undef, "DelUniqueDebarment without the argument 'type' returns undef" );
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 1, "DelUniqueDebarment without the argument 'type' does not delete the debarment" );
|
|
|
|
$delUniqueDebarment = DelUniqueDebarment({
|
|
type => 'OVERDUES'
|
|
});
|
|
is( $delUniqueDebarment, undef, "DelUniqueDebarment without the argument 'borrowernumber' returns undef" );
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 1, "DelUniqueDebarment without the argument 'borrowerumber' does not delete the debarment" );
|
|
|
|
$delUniqueDebarment = DelUniqueDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'SUSPENSION',
|
|
});
|
|
is( $delUniqueDebarment, undef, "DelUniqueDebarment with wrong arguments returns undef" );
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 1, "DelUniqueDebarment with wrong arguments does not delete the debarment" );
|
|
|
|
$delUniqueDebarment = DelUniqueDebarment({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( $delUniqueDebarment, 1, "DelUniqueDebarment returns 1" );
|
|
$debarments = GetDebarments({
|
|
borrowernumber => $borrowernumber,
|
|
type => 'OVERDUES',
|
|
});
|
|
is( @$debarments, 0, "DelUniqueDebarment functions correctly" );
|
|
|
|
|
|
$debarments = GetDebarments({ borrowernumber => $borrowernumber });
|
|
foreach my $d ( @$debarments ) {
|
|
DelDebarment( $d->{'borrower_debarment_id'} );
|
|
}
|
|
$debarments = GetDebarments({ borrowernumber => $borrowernumber });
|
|
is( @$debarments, 0, "DelDebarment functions correctly" );
|
|
|
|
$dbh->do(q|UPDATE borrowers SET debarred = '1970-01-01'|);
|
|
is( Koha::Patrons->find( $borrowernumber )->is_debarred, undef, 'A patron with a debarred date in the past is not debarred' );
|
|
|
|
$dbh->do(q|UPDATE borrowers SET debarred = NULL|);
|
|
is( Koha::Patrons->find( $borrowernumber )->is_debarred, undef, 'A patron without a debarred date is not debarred' );
|
|
|
|
$dbh->do(q|UPDATE borrowers SET debarred = '9999-12-31'|); # Note: Change this test before the first of January 10000!
|
|
is( Koha::Patrons->find( $borrowernumber )->is_debarred, '9999-12-31', 'A patron with a debarred date in the future is debarred' );
|