Marcel de Rooy
8c510e1a92
Similar to the full path test in sub themelanguage, this patch makes a change in _get_template_file. This allows you to pass a template outside the modules directory to get_template_and_user. (Note: the sub badtemplatecheck already blocks bad paths.) Especially, this would be helpful for plugins using templates. As can be seen in Templates.pm, a change was made earlier to overwrite the filename for a plugin in sub gettemplate. This exception can now be removed. Also note the small change in Koha/Plugin/Base.pm; mbf_path is already absolute and if we pass a full path, we do not need it. This allows use of a regular Koha template or a shared template between plugins (as long as badtemplatecheck allows the path). What are the side-effects of this change? [1] We should not pass absolute paths if we mean relative ones. A follow-up patch deals with one occurrence in the codebase. No regressions for regular use. [2] Plugins can call get_template_and_user directly or go via get_template in Koha/Plugin/Base (absolute paths don't go via mbf_path). Note: replaced two single quotes in Auth.pm to show template name in test description. Test plan: [1] Open some page on OPAC or staff client to trigger a template. [2] Run t/db_dependent/Auth.t to verify not allowing some bad templates. [3] Run t/db_dependent/Templates.t to verify an absolute path. [4] Run t/db_dependent/Plugins.t to verify using templates in a plugin. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
123 lines
5.4 KiB
Perl
Executable file
123 lines
5.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 32;
|
|
use CGI;
|
|
use File::Basename;
|
|
use File::Spec;
|
|
use File::Temp qw( tempdir tempfile );
|
|
use FindBin qw($Bin);
|
|
use Archive::Extract;
|
|
use Module::Load::Conditional qw(can_load);
|
|
use Test::MockModule;
|
|
|
|
use C4::Context;
|
|
use t::lib::Mocks;
|
|
|
|
BEGIN {
|
|
push( @INC, dirname(__FILE__) . '/..' );
|
|
|
|
use_ok('Koha::Plugins');
|
|
use_ok('Koha::Plugins::Handler');
|
|
use_ok('Koha::Plugins::Base');
|
|
use_ok('Koha::Plugin::Test');
|
|
}
|
|
|
|
my $mock_plugin = Test::MockModule->new( 'Koha::Plugin::Test' );
|
|
$mock_plugin->mock( 'test_template', sub {
|
|
my ( $self, $file ) = @_;
|
|
my $template = $self->get_template({ file => $file });
|
|
$template->param( filename => $file );
|
|
return $template->output;
|
|
});
|
|
|
|
ok( can_load( modules => { "Koha::Plugin::Test" => undef } ), 'Test can_load' );
|
|
|
|
my $plugin = Koha::Plugin::Test->new({ enable_plugins => 1, cgi => CGI->new });
|
|
|
|
isa_ok( $plugin, "Koha::Plugin::Test", 'Test plugin class' );
|
|
isa_ok( $plugin, "Koha::Plugins::Base", 'Test plugin parent class' );
|
|
|
|
ok( $plugin->can('report'), 'Test plugin can report' );
|
|
ok( $plugin->can('tool'), 'Test plugin can tool' );
|
|
ok( $plugin->can('to_marc'), 'Test plugin can to_marc' );
|
|
ok( $plugin->can('opac_online_payment'), 'Test plugin can opac_online_payment' );
|
|
ok( $plugin->can('opac_online_payment_begin'), 'Test plugin can opac_online_payment_begin' );
|
|
ok( $plugin->can('opac_online_payment_end'), 'Test plugin can opac_online_payment_end' );
|
|
ok( $plugin->can('configure'), 'Test plugin can configure' );
|
|
ok( $plugin->can('install'), 'Test plugin can install' );
|
|
ok( $plugin->can('uninstall'), 'Test plugin can install' );
|
|
|
|
is( Koha::Plugins::Handler->run({ class => "Koha::Plugin::Test", method => 'report', enable_plugins => 1 }), "Koha::Plugin::Test::report", 'Test run plugin report method' );
|
|
|
|
my $metadata = $plugin->get_metadata();
|
|
is( $metadata->{'name'}, 'Test Plugin', 'Test $plugin->get_metadata()' );
|
|
|
|
is( $plugin->get_qualified_table_name('mytable'), 'koha_plugin_test_mytable', 'Test $plugin->get_qualified_table_name()' );
|
|
is( $plugin->get_plugin_http_path(), '/plugin/Koha/Plugin/Test', 'Test $plugin->get_plugin_http_path()' );
|
|
|
|
# test absolute path change in get_template with Koha::Plugin::Test
|
|
# using the mock set before
|
|
# we also add tmpdir as an approved template dir
|
|
t::lib::Mocks::mock_config( 'pluginsdir', [ File::Spec->tmpdir ] );
|
|
my ( $fh, $fn ) = tempfile( SUFFIX => '.tt', UNLINK => 1 );
|
|
print $fh 'I am [% filename %]';
|
|
close $fh;
|
|
my $classname = ref($plugin);
|
|
like( $plugin->test_template($fn), qr/^I am $fn/, 'Template works' );
|
|
|
|
# testing GetPlugins
|
|
my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({
|
|
method => 'report'
|
|
});
|
|
my @names = map { $_->get_metadata()->{'name'} } @plugins;
|
|
is( scalar grep( /^Test Plugin$/, @names), 1, "Koha::Plugins::GetPlugins functions correctly" );
|
|
@plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({
|
|
metadata => { my_example_tag => 'find_me' },
|
|
});
|
|
@names = map { $_->get_metadata()->{'name'} } @plugins;
|
|
is( scalar grep( /^Test Plugin$/, @names), 1, "GetPlugins also found Test Plugin via a metadata tag" );
|
|
# Test two metadata conditions; one does not exist for Test.pm
|
|
# Since it is a required key, we should not find the same results
|
|
my @plugins2 = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({
|
|
metadata => { my_example_tag => 'find_me', not_there => '1' },
|
|
});
|
|
isnt( scalar @plugins2, scalar @plugins, 'GetPlugins with two metadata conditions' );
|
|
|
|
for my $pass ( 1 .. 2 ) {
|
|
my $plugins_dir;
|
|
my $module_name = 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink';
|
|
my $pm_path = 'Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm';
|
|
if ( $pass == 1 ) {
|
|
my $plugins_dir1 = tempdir( CLEANUP => 1 );
|
|
t::lib::Mocks::mock_config('pluginsdir', $plugins_dir1);
|
|
$plugins_dir = $plugins_dir1;
|
|
push @INC, $plugins_dir1;
|
|
} else {
|
|
my $plugins_dir1 = tempdir( CLEANUP => 1 );
|
|
my $plugins_dir2 = tempdir( CLEANUP => 1 );
|
|
t::lib::Mocks::mock_config('pluginsdir', [ $plugins_dir2, $plugins_dir1 ]);
|
|
$plugins_dir = $plugins_dir2;
|
|
pop @INC;
|
|
push @INC, $plugins_dir2;
|
|
push @INC, $plugins_dir1;
|
|
}
|
|
my $full_pm_path = $plugins_dir . '/' . $pm_path;
|
|
|
|
my $ae = Archive::Extract->new( archive => "$Bin/KitchenSinkPlugin.kpz", type => 'zip' );
|
|
unless ( $ae->extract( to => $plugins_dir ) ) {
|
|
warn "ERROR: " . $ae->error;
|
|
}
|
|
use_ok('Koha::Plugin::Com::ByWaterSolutions::KitchenSink');
|
|
$plugin = Koha::Plugin::Com::ByWaterSolutions::KitchenSink->new({ enable_plugins => 1});
|
|
my $table = $plugin->get_qualified_table_name( 'mytable' );
|
|
|
|
ok( -f $plugins_dir . "/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm", "KitchenSink plugin installed successfully" );
|
|
$INC{$pm_path} = $full_pm_path; # FIXME I do not really know why, but if this is moved before the $plugin constructor, it will fail with Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::KitchenSink"
|
|
Koha::Plugins::Handler->delete({ class => "Koha::Plugin::Com::ByWaterSolutions::KitchenSink", enable_plugins => 1 });
|
|
my $sth = C4::Context->dbh->table_info( undef, undef, $table, 'TABLE' );
|
|
my $info = $sth->fetchall_arrayref;
|
|
is( @$info, 0, "Table $table does no longer exist" );
|
|
ok( !( -f $full_pm_path ), "Koha::Plugins::Handler::delete works correctly." );
|
|
}
|