ed7543287b
Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious This patch: - adds a Template::Toolkit plugin that generates <script> and <link> tags for JS and CSS files, and inserts automatically the Koha version in the filename - use the new plugin to remove all occurences of [% KOHA_VERSION %] - remove the code that was adding KOHA_VERSION as a template variable Test plan: 1. Apply patch 2. Go to several different pages in Koha (opac and intranet) while checking your browser's dev tools (there should be no 404 for JS and CSS files, and the Koha version should appear in filenames) and the server logs (there should be no "File not found") 3. `git grep KOHA_VERSION` should return nothing 4. prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
285 lines
8.9 KiB
Text
285 lines
8.9 KiB
Text
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › MARC check
|
|
[% IF ( total ) %] :[% total %] errors found[% ELSE %] : Configuration OK![% END %]</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
<body id="admin_checkmarc" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › MARC check
|
|
[% IF ( total ) %]: [% total %] errors found[% ELSE %] : Configuration OK![% END %]</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<h1>MARC bibliographic framework test</h1>
|
|
<table>
|
|
<tr>
|
|
<th>Test</th>
|
|
<th>Result</th>
|
|
</tr>
|
|
<!-- -->
|
|
[% IF ( itemnum ) %]
|
|
<tr>
|
|
<td>itemnum</td>
|
|
<td><ul><li>The field itemnum MUST be mapped </li>
|
|
<li>The corresponding subfield MUST be in with -1 (ignore) tab</li></ul></td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>itemnum : the field itemnumber is mapped to a field in tab -1</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( itemfields ) %]
|
|
<tr>
|
|
<td>item fields</td>
|
|
<td>ALL items fields MUST :<br />
|
|
<ul><li>be mapped to the same tag,</li>
|
|
<li>and they must all be in the 10 (items) tab</li></ul></td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>All item fields are in the same tag and in item tab</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( itemtags ) %]
|
|
<tr>
|
|
<td>Item tag</td>
|
|
<td>There is more than 1 MARC tag related to items tab (10) : [% itemtags %]</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>Only 1 MARC tag mapped to items</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( itemtype ) %]
|
|
<tr>
|
|
<td>itemtype NOT mapped</td>
|
|
<td>the biblioitems.itemtype field MUST :<br />
|
|
<ul><li>be mapped to a MARC subfield, </li>
|
|
<li>the corresponding subfield MUST have "Authorized value" set to "itemtype"</li></ul></td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>biblioitems.itemtype defined</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( branch ) %]
|
|
<tr>
|
|
<td>homebranch NOT mapped</td>
|
|
<td>the items.homebranch field MUST :<br />
|
|
<ul><li>be mapped to a MARC subfield,</li>
|
|
<li>the corresponding subfield MUST have "Authorized value" set to "branches"</li></ul></td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>homebranch defined</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( holdingbranch ) %]
|
|
<tr>
|
|
<td>holdingbranch NOT mapped</td>
|
|
<td>the items.holdingbranch field MUST :<br />
|
|
<ul><li>be mapped to a MARC subfield, </li>
|
|
<li>the corresponding subfield MUST have "Authorized value" set to "branches"</li></ul></td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>holdingbranch defined</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( itemtypes_empty ) %]
|
|
<tr>
|
|
<td>item type not defined</td>
|
|
<td>at least 1 item type must be defined</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>at least 1 item type defined</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( branches_empty ) %]
|
|
<tr>
|
|
<td>library not defined</td>
|
|
<td>at least 1 library must be defined</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>at least 1 library defined</td>
|
|
</tr>
|
|
[% END %]
|
|
<!-- -->
|
|
[% IF ( biblionumber ) %]
|
|
<tr>
|
|
<td>biblio and biblionumber</td>
|
|
<td>The biblio.biblionumber and biblioitems.biblioitemnumber fields be mapped to a MARC subfield,</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>biblionumber and biblioitemnumber mapped correctly</td>
|
|
</tr>
|
|
[% END %]
|
|
|
|
[% IF ( frameworknull ) %]
|
|
<tr>
|
|
<td>framework values</td>
|
|
<td>there is a null value in a frameworkcode. Check the following tables<br />
|
|
<li>select * from marc_subfield_structure where frameworkcode is NULL</li>
|
|
<li>select * from marc_tag_structure where frameworkcode is NULL</li>
|
|
</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>no NULL value in frameworkcode</td>
|
|
</tr>
|
|
[% END %]
|
|
|
|
[% IF ( inconsistent_tabs ) %]
|
|
<tr>
|
|
<td style="vertical-align:top;">subfields not in same tabs</td>
|
|
<td>Not all subfields for the following tags are in the same tab (or marked 'ignored').
|
|
<table>
|
|
<tr>
|
|
<th>Code</th>
|
|
<th>Description</th>
|
|
<th>Tag</th>
|
|
<th>Tabs in use</th>
|
|
</tr>
|
|
[% FOREACH tab_inf IN tab_info %]
|
|
<tr>
|
|
<td>[% tab_inf.frameworkcode %]</td>
|
|
[% IF ( tab_inf.frameworkcode ) %]
|
|
<td>[% tab_inf.frameworktext %]</td>
|
|
[% ELSE %]
|
|
<td>Default framework</td>
|
|
[% END %]
|
|
<td>[% tab_inf.tagfield %]</td>
|
|
<td>[% tab_inf.tabs %]</td>
|
|
</tr>
|
|
[% END %]
|
|
</table>
|
|
</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>all subfields for each tag are in the same tab (or ignored)</td>
|
|
</tr>
|
|
[% END %]
|
|
|
|
[% IF ( invalid_authtypecodes ) %]
|
|
<tr>
|
|
<td style="vertical-align:top;">invalid authority types</td>
|
|
<td>Not all authority types referred to by the frameworks are defined.
|
|
<table>
|
|
<tr>
|
|
<th>Framework code</th>
|
|
<th>Framework description</th>
|
|
<th>Tag</th>
|
|
<th>Subfield</th>
|
|
<th>Invalid authority type</th>
|
|
</tr>
|
|
[% FOREACH authtypecode_inf IN authtypecode_info %]
|
|
<tr>
|
|
<td>[% authtypecode_inf.frameworkcode %]</td>
|
|
[% IF ( authtypecode_inf.frameworkcode ) %]
|
|
<td>[% authtypecode_inf.frameworktext %]</td>
|
|
[% ELSE %]
|
|
<td>Default framework</td>
|
|
[% END %]
|
|
<td>[% authtypecode_inf.tagfield %]</td>
|
|
<td>[% authtypecode_inf.tagsubfield %]</td>
|
|
<td>[% authtypecode_inf.authtypecode %]</td>
|
|
</tr>
|
|
[% END %]
|
|
</table>
|
|
</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>all authority types used in the frameworks are defined</td>
|
|
</tr>
|
|
[% END %]
|
|
|
|
[% IF ( permanent_location_mapped ) %]
|
|
<tr>
|
|
<td style="vertical-align:top;">items.permanent_location mapped</td>
|
|
<td>The following mappings exist for items.permanent_location, and they shouldn't.
|
|
<table>
|
|
<tr>
|
|
<th>Framework code</th>
|
|
<th>Framework description</th>
|
|
<th>Tag</th>
|
|
<th>Subfield</th>
|
|
</tr>
|
|
[% FOREACH mapped_perm_loc IN mapped_permanent_location %]
|
|
<tr>
|
|
<td>[% mapped_perm_loc.frameworkcode %]</td>
|
|
[% IF ( mapped_perm_loc.frameworkcode ) %]
|
|
<td>[% mapped_perm_loc.frameworktext %]</td>
|
|
[% ELSE %]
|
|
<td>Default framework</td>
|
|
[% END %]
|
|
<td>[% mapped_perm_loc.tagfield %]</td>
|
|
<td>[% mapped_perm_loc.tagsubfield %]</td>
|
|
</tr>
|
|
[% END %]
|
|
</table>
|
|
</td>
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
<td>OK</td>
|
|
<td>items.permanent_location is not mapped on the frameworks</td>
|
|
</tr>
|
|
[% END %]
|
|
|
|
<!-- -->
|
|
[% IF ( total ) %]
|
|
<tr>
|
|
<td>TOTAL</td>
|
|
<td>You have [% total %] error(s) in your MARC configuration. Please fix them before using Koha</td>
|
|
</tr>
|
|
</table>
|
|
[% ELSE %]
|
|
</table>
|
|
<p><b>Configuration OK, you don't have errors in your MARC parameters table</b></p>
|
|
[% END %]
|
|
|
|
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") %]
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|