053d9a58ac
Added missing upgrade SQL system preference. Corrected system preference screen message Fixes on purge_suggestions.pl - perlcritic friendlier - address $PERL5LIB comment by using $PROGRAM_NAME (comment #10) - used STDERR (comment #10) - perltidy TEST PLAN --------- $ ./installer/data/mysql/updatedatabase.pl -- should run upgrade and generate new systempreference in table $ ./misc/cronjobs/purge_suggestions.pl --help -- should give help with a real path used instead of $PERL5LIB. $ ./misc/cronjobs/purge_suggestions.pl -days -1 -- should give error message as expected $ ./misc/cronjobs/purge_suggestions.pl -days 0 -- should give error message as expected Go to OPAC system preferences tab and check the PurgeSuggestionsOlderThan system preference -- message should be as expected (see comment #9) run koha qa test tools -- all should pass Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: Moved new pref from OPAC to Acquisitions preferences. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
81 lines
2 KiB
Perl
Executable file
81 lines
2 KiB
Perl
Executable file
#!/usr/bin/perl -w
|
|
|
|
# Copyright 2010 Biblibre SARL
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use utf8;
|
|
|
|
BEGIN {
|
|
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/../kohalib.pl" };
|
|
}
|
|
|
|
use Getopt::Long;
|
|
use Pod::Usage;
|
|
use C4::Suggestions;
|
|
use C4::Log;
|
|
use C4::Context;
|
|
|
|
my ( $help, $days );
|
|
|
|
GetOptions(
|
|
'help|?' => \$help,
|
|
'days=s' => \$days,
|
|
);
|
|
|
|
my $usage = << 'ENDUSAGE';
|
|
This script delete old suggestions
|
|
Parameters:
|
|
-help|? This message
|
|
-days TTT to define the age of suggestions to delete
|
|
|
|
Example:
|
|
ENDUSAGE
|
|
$usage .= $0 . " -days 30\n";
|
|
|
|
# If this script is called without the 'days' parameter, we use the system preferences value instead.
|
|
if ( !defined($days) && !$help ) {
|
|
my $purge_sugg_days =
|
|
C4::Context->preference('PurgeSuggestionsOlderThan') || q{};
|
|
if ( $purge_sugg_days ne q{} and $purge_sugg_days >= 0 ) {
|
|
$days = $purge_sugg_days;
|
|
}
|
|
}
|
|
|
|
# If this script is called with the 'help' parameter, we show up the help message and we leave the script without doing anything.
|
|
if ($help) {
|
|
print $usage;
|
|
exit;
|
|
}
|
|
|
|
if ( defined($days) && $days ne q{} && $days > 0 ) {
|
|
cronlogaction();
|
|
DelSuggestionsOlderThan($days);
|
|
}
|
|
elsif (!defined($days)){
|
|
print $usage;
|
|
}
|
|
elsif ( $days == 0 ) {
|
|
warn "This script is not executed with 0 days. Aborted.\n";
|
|
}
|
|
else {
|
|
warn "This script requires a positive number of days. Aborted.\n";
|
|
}
|