Marcel de Rooy
07de37f0e5
The original patch creates a lockfile in the ZEBRA_LOCKDIR. It can fall back to /var/lock or even /tmp. If the create fails, it dies. This can be considered as very exceptional. This followup adjusts the fallback location in /var/lock or /tmp slightly. It appends the database name to the folder in order to prevent interfering between multiple Koha instances. Creation of the lockfile has been moved to a subroutine extending directory and file creation testing. In the very unlikely case that we cannot create the lockfile (after three separate tries), this follow-up allows you to continue instead of die. This is just as we did before we had file locking here. Every time skipping a reindex could cause more harm than continuing and having the race condition once in a while. Test plan: Test adding and removing lockdir from your koha-conf.xml. Check fallback. Note that fallback in /var/lock or /tmp must contain database name. Remove the lockdir config line and remove permissions from fallback. In this case the reindex should continue but with a warning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with daemon and one-off invocation simultaneously. Tested new wait parameter. Tried all variations of lock directory (changing permissions etc.) Signed-off-by: Galen Charlton <gmc@esilibrary.com> |
||
|---|---|---|
| .. | ||
| 22_to_30 | ||
| build_oai_sets.pl | ||
| buildCOUNTRY.pl | ||
| buildEDITORS.pl | ||
| buildLANG.pl | ||
| bulkmarcimport.pl | ||
| checkNonIndexedBiblios.pl | ||
| create_analytical_rel.pl | ||
| fix_onloan.pl | ||
| koha-svc.pl | ||
| merge_authority.pl | ||
| rebuild_solr.pl | ||
| rebuild_zebra.pl | ||
| rebuild_zebra_sliced.sh | ||
| remove_unused_authorities.pl | ||
| switch_marc21_series_info.pl | ||
| upgradeitems.pl | ||