Jonathan Druart
238fabc4ab
The purpose of this script was to load the relevant Koha lib for the different scripts (installation, cronjob, CLI, etc.) However it is not used consistently and we prefer to rely on PERL5LIB. From bug 28617 comment 6 from Galen: """ Time marches on, and one of the motivations for having kohalib.pl - making it possible to install Koha without setting a single environment variable - has been obviated by the vast improvements in the ease of installing Koha. Consequently, I think kohalib.pl can go away. """ Test plan: confirm that the changes make sense and that kohalib.pl can be removed safely. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
107 lines
2.9 KiB
Perl
Executable file
107 lines
2.9 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# Copyright (C) 2012 ByWater Solutions
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use Koha::Script;
|
|
use C4::Context;
|
|
|
|
use Getopt::Long qw( GetOptions );
|
|
use Data::Dumper;
|
|
|
|
sub print_usage {
|
|
print <<_USAGE_
|
|
$0: Remove duplicate fines
|
|
|
|
Due to bug 8253, upgrading from Koha 3.6 to 3.8 may introduce duplicate fines.
|
|
This script will remove these duplicate fines. To use, repeatably run this
|
|
script until there are no more duplicates in the database.
|
|
|
|
Parameters:
|
|
--confirm or -c Confirm you want to run the script.
|
|
--help or -h Print out this help message.
|
|
_USAGE_
|
|
}
|
|
|
|
my $help;
|
|
my $confirm;
|
|
my $result = GetOptions(
|
|
'confirm|c' => \$confirm,
|
|
'help|h' => \$help,
|
|
);
|
|
if ( $help || !$confirm ) {
|
|
print_usage();
|
|
exit 0;
|
|
}
|
|
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $query = "
|
|
SELECT * FROM accountlines
|
|
WHERE ( accounttype = 'FU' OR accounttype = 'F' )
|
|
AND description like '%23:59%'
|
|
ORDER BY borrowernumber, itemnumber, accountlines_id, description
|
|
";
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute();
|
|
my $results = $sth->fetchall_arrayref( {} );
|
|
|
|
$query =
|
|
"SELECT * FROM accountlines WHERE description LIKE ? AND description NOT LIKE ?";
|
|
$sth = $dbh->prepare($query);
|
|
|
|
foreach my $keeper (@$results) {
|
|
|
|
warn "WORKING ON KEEPER: " . Data::Dumper::Dumper( $keeper );
|
|
my ($description_to_match) = split( / 23:59/, $keeper->{'description'} );
|
|
$description_to_match .= '%';
|
|
|
|
warn "DESCRIPTION TO MATCH: " . $description_to_match;
|
|
|
|
$sth->execute( $description_to_match, $keeper->{'description'} );
|
|
|
|
my $has_changed = 0;
|
|
|
|
while ( my $f = $sth->fetchrow_hashref() ) {
|
|
|
|
warn "DELETING: " . Data::Dumper::Dumper( $f );
|
|
|
|
if ( $f->{'amountoutstanding'} < $keeper->{'amountoutstanding'} ) {
|
|
$keeper->{'amountoutstanding'} = $f->{'amountoutstanding'};
|
|
$has_changed = 1;
|
|
}
|
|
|
|
my $sql =
|
|
"DELETE FROM accountlines WHERE accountlines_id = ?";
|
|
$dbh->do( $sql, undef, $f->{'accountlines_id'} );
|
|
}
|
|
|
|
if ($has_changed) {
|
|
my $sql =
|
|
"UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ?";
|
|
$dbh->do(
|
|
$sql, undef,
|
|
$keeper->{'amountoutstanding'}, $keeper->{'accountlines_id'}
|
|
);
|
|
}
|
|
}
|
|
|
|
exit;
|