Main Koha release repository https://koha-community.org
Find a file
Kyle M Hall 0b1a1261ff Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used
Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules.

Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value.

Test Plan:
1) Check out Koha 22.05.05
2) Create a default all/all/all rule, 3 other rules. Ensure they all have Loan period set to 7, with one of the non-default rules having a Loan period of 14.
3) Delete all but one of the non-default rules with the following query:
   Delete from circulation_rules where rule_name  = 'issuelength' and ( rule_value != 14 and not ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2;
4) Check out 254f721320
5) Run updatedatabase.pl and restart
6) Note the rules were recreated with the value 0
7) Repeat steps 1-4
8) Apply this patch
9) If you're using the same database, set the version to 22.0600023 and restart
10) Run updatedatabase.pl
11) Note the rules were recreated, but the value is the derived value from the all/all/all rule!

Signed-off-by: Kevin Carnes <kevin.carnes@ub.lu.se>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Bug 33847: Rewrite to use SQL

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Squashed, and added reference to new bug too
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit f6f2d1ae41)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 8b04a3f642)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2024-01-04 20:38:48 +00:00
acqui Bug 35254: Add import_record_id to order inputs 2023-11-10 21:07:59 -10:00
admin Bug 35278: Fix warn from column_settings.pl 2023-11-10 21:26:52 -10:00
api Bug 34008: Harmonize attribute names 2023-11-07 22:41:49 -10:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-17 22:49:50 -10:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
bin
C4 Bug 35405: Remove noise from MARC::Record in SearchAuthorities 2024-01-04 20:26:30 +00:00
catalogue Bug 33047: Return 404 instead of 500 when biblio does not exist 2023-07-18 10:28:24 +01:00
cataloguing Bug 35414: Silence warn related to number_of_copies 2023-12-14 21:16:05 +00:00
circ Bug 29007: Add cancellation reason input on check in 2023-11-10 21:54:19 -10:00
clubs
course_reserves
debian Bug 35174: update control files for koha-l10n dependency package 2023-11-22 09:35:04 +01:00
docs Bug 34424: Add Emily Lamancusa to QA Team 2023-11-07 22:28:02 -10:00
erm
errors
etc Bug 30843: Add mfa_range configuration option for TOTP 2023-10-05 08:36:20 -10:00
ill
installer Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used 2024-01-04 20:38:48 +00:00
Koha Bug 30287: (follow-up) Add content wrap matching send time 2024-01-04 20:34:51 +00:00
koha-tmpl Bug 30287: (follow-up) Add content wrap matching send time 2024-01-04 20:34:51 +00:00
labels
lib/CGI/Session/Serialize
members Bug 30287: Conditionally render notice preview 2024-01-04 20:34:51 +00:00
misc Update release notes for 23.05.07 release 2024-01-03 14:56:46 +00:00
offline_circ Bug 33961: Remove built-in offline circ tool 2023-07-17 08:18:59 +01:00
opac Bug 35496: (QA follow-up): tidy up code 2024-01-04 18:52:26 +00:00
patron_lists
patroncards
plugins
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-07-17 14:51:00 +01:00
reports Bug 34859: Remove unnecessary params from reports-home.pl 2023-10-05 14:52:14 -10:00
reserve Bug 34634: Show expirationdate of expired holds on reserve/request.pl 2023-09-07 20:13:21 -10:00
reviews
rotating_collections
serials Bug 35073: perltidy subscription-batchedit.pl 2023-11-09 16:06:34 -10:00
services
skel
suggestion Bug 35276: Remove authentication params from suggestion hash 2023-11-14 08:54:11 -10:00
svc Bug 35181: Don't pass undef to header 2023-11-09 21:10:13 -10:00
t Bug 30287: (follow-up) Make unit test more reliable in ktd 2024-01-04 20:34:51 +00:00
tags
tools Bug 35291: (QA follow-up) Tidying script for QA test tools 2023-11-24 10:58:50 -10:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-05 09:38:43 -10:00
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-22 09:34:59 +01:00
.htaccess
.mailmap Update .mailmap 2023-07-17 08:12:22 +01:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-07-12 07:55:00 +01:00
.proverc.dist
.stylelintrc.json
about.pl Bug 35174: Add a warning to the about page 2023-11-22 09:34:27 +01:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 33964: (QA follow-up) Remove library from cpanfile 2023-08-07 20:05:46 -10:00
cypress.json
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2024-01-04 18:14:27 +00:00
help.pl
INSTALL
Koha.pm Increment version for 23.05.07 release 2024-01-03 14:06:44 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-25 20:22:12 -10:00
Makefile.PL Bug 26700: Remove occurrences in Makefile.PL 2023-07-17 11:01:46 +01:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo