252f4674a5
So far the administration module only allowed for 2 permissions:
- circulation conditions (manage_circ_rules)
- everything else (parameters_remaining_permissions)
With this patch almost every section of the administration page
will have its own granular permission.
To test:
- Create different staff users:
1) One with parameters_remaining_permissions
2) One with parameters
3) One with catalogue and no parameters
4) One superlibrarian
- Apply the patch
- Run the database update
- Check the staff users:
1) All subpermissions, but manage_circ_rules
should be checked
2) Nothing should have changed
3) manage_item_serach_fields shoudl be checked
(page had catalogue permission before)
4) Nothing should have changed
- Try different settings of the permissions and
verify that
- Administration page behaves correctly
- Administration menu behaves correctly
! You shoudl only see what you have permission for
https://bugs.koha-community.org/show_bug.cgi?id=14391
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
73 lines
2.8 KiB
Perl
Executable file
73 lines
2.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use Koha::DateUtils qw( dt_from_string output_pref );
|
|
use Koha::Libraries;
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "admin/usage_statistics.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { parameters => 'manage_usage_stats' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $query->param('op') || q||;
|
|
|
|
if ( $op eq 'update' ) {
|
|
my $UsageStats = $query->param('UsageStats');
|
|
my $UsageStatsCountry = $query->param('UsageStatsCountry');
|
|
my $UsageStatsLibraryName = $query->param('UsageStatsLibraryName');
|
|
my $UsageStatsLibraryType = $query->param('UsageStatsLibraryType');
|
|
my $UsageStatsLibraryUrl = $query->param('UsageStatsLibraryUrl');
|
|
my $UsageStatsLibrariesInfo = $query->param('UsageStatsLibrariesInfo');
|
|
my $UsageStatsGeolocation = $query->param('UsageStatsGeolocation');
|
|
C4::Context->set_preference('UsageStats', $UsageStats);
|
|
C4::Context->set_preference('UsageStatsCountry', $UsageStatsCountry);
|
|
C4::Context->set_preference('UsageStatsLibraryName', $UsageStatsLibraryName);
|
|
C4::Context->set_preference('UsageStatsLibraryType', $UsageStatsLibraryType);
|
|
C4::Context->set_preference('UsageStatsLibraryUrl', $UsageStatsLibraryUrl);
|
|
C4::Context->set_preference('UsageStatsLibrariesInfo', $UsageStatsLibrariesInfo);
|
|
C4::Context->set_preference('UsageStatsGeolocation', $UsageStatsGeolocation);
|
|
my $libraries = Koha::Libraries->search;
|
|
while ( my $library = $libraries->next ) {
|
|
if ( my $latlng = $query->param('geolocation_' . $library->branchcode) ) {
|
|
$library->geolocation( $latlng )->store;
|
|
}
|
|
}
|
|
}
|
|
|
|
if ( C4::Context->preference('UsageStatsLastUpdateTime') ) {
|
|
my $dt = DateTime->from_epoch( epoch => C4::Context->preference('UsageStatsLastUpdateTime'));
|
|
$template->param(UsageStatsLastUpdateTime => output_pref($dt) );
|
|
}
|
|
|
|
my $libraries = Koha::Libraries->search;
|
|
$template->param(
|
|
libraries => $libraries,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|