Koha/admin/oai_servers.pl
Owen Leonard 8a433d4f20
Bug 37826: Remove the use of the script_name variable where it is unnecessary
Most of the places where a "script_name" variable used it is not
strictly necessary. Because it is also used inconsistently, I think it's
better to simply remove the use of the variable where it isn't strictly
necessary.

This patch removes creation of the template variable from several
scripts and updates the corresponding template with the URL itself.

To test, apply the patch and restart services. Test the following pages,
including the various permutations where they are present, e.g. New,
Edit, Delete.

- Administration -> Cities and towns -> Search via the header search
  form
- Administratoin -> Currencies and exchange rates -> Search via the
  header search form
- Administration -> Desks
- Administration -> Budgets
- Administration -> Authority types
- Administration -> Authority types -> MARC structure -> Subfields
- Administration -> Classification configuration
- Administration -> MARC bibliographic framework
- Administration -> MARC bibliographic framework -> MARC structure ->
  Subfields
- Administration -> Record matching rules
- Administration -> OAI repositories
- Administration -> Patron attribute types
- Administration -> System preferences -> Local use
- Administration -> Z39.50/SRU servers
- Acquisitions -> Vendor -> Contracts
- Acquisitions -> Vendor -> Basket -> Export as CSV
- Acquisitions -> Vendor -> Basket -> Edit basket
- Acquisitions -> Vendor -> Basket groups
- Tools -> Import patrons
- Tools -> Notices and slips

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-12-27 17:33:51 +01:00

122 lines
4 KiB
Perl
Executable file

#!/usr/bin/perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
# This script is used to maintain the OAI servers table.
# Parameter $op is operation: list, new, edit, add_validated, delete_confirmed.
# add_validated saves a validated record and goes to list view.
# delete_confirmed deletes a record and goes to list view.
use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Context;
use C4::Auth qw( get_template_and_user );
use C4::Output qw( output_html_with_http_headers );
use Koha::Database;
use Koha::OAIServers;
# Initialize CGI, template, database
my $input = CGI->new;
my $op = $input->param('op') || 'list';
my $id = $input->param('id') || 0;
my $type = $input->param('type') || '';
my $searchfield = '';
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "admin/oai_servers.tt",
query => $input,
type => "intranet",
flagsrequired => { parameters => 'manage_search_targets' },
}
);
my $path = C4::Context->config('intrahtdocs') . "/prog/";
$template->param( xslt_path => $path );
my $schema = Koha::Database->new()->schema();
# Main code
# First process a confirmed delete, or save a validated record
if ( $op eq 'cud-delete_confirmed' && $id ) {
my $server = Koha::OAIServers->find($id);
if ($server) {
$server->delete;
$template->param( msg_deleted => 1, msg_add => $server->servername );
} else {
$template->param( msg_notfound => 1, msg_add => $id );
}
$id = 0;
} elsif ( $op eq 'cud-add_validated' ) {
my @fields = qw/endpoint oai_set dataformat
recordtype servername
add_xslt/;
my $formdata = _form_data_hashref( $input, \@fields );
if ($id) {
my $server = Koha::OAIServers->find($id);
if ($server) {
$server->set($formdata)->store;
$template->param( msg_updated => 1, msg_add => $formdata->{servername} );
} else {
$template->param( msg_notfound => 1, msg_add => $id );
}
$id = 0;
} else {
Koha::OAIServer->new($formdata)->store;
$template->param( msg_added => 1, msg_add => $formdata->{servername} );
}
} elsif ( $op eq 'search' ) {
# use searchfield only in remaining operations
$searchfield = $input->param('searchfield') || '';
}
# Now list multiple records, or edit one record
my $data = [];
if ( $op eq 'add' || $op eq 'edit' ) {
$data = server_search( $schema, $id, $searchfield ) if $searchfield || $id;
delete $data->[0]->{id} if @$data && $op eq 'add'; #cloning record
$template->param(
add_form => 1, server => @$data ? $data->[0] : undef,
op => $op, type => $op eq 'add' ? lc $type : ''
);
} else {
$data = server_search( $schema, $id, $searchfield );
$template->param(
loop => \@$data, searchfield => $searchfield, id => $id,
op => 'list'
);
}
output_html_with_http_headers $input, $cookie, $template->output;
# End of main code
sub server_search { # find server(s) by id or name
my ( $schema, $id, $searchstring ) = @_;
return Koha::OAIServers->search(
$id ? { oai_server_id => $id } : { servername => { like => $searchstring . '%' } },
)->unblessed;
}
sub _form_data_hashref {
my ( $input, $fieldref ) = @_;
return { map { ( $_ => scalar $input->param($_) // '' ) } @$fieldref };
}