Jonathan Druart
0c8496a85a
The selector is not correct, we must to not rely on the number.
This patch fixes a regression caused by bug 28445, but also a
long-standing bug.
* Regression:
The barcode plugin is broken is autoBarcode=<branchcode>yymm0001
There is a JS error in the console:
Uncaught TypeError: form.field_value is undefined
Focustag_952_subfield_p_878344
Focustag_952_subfield_p_878344_handler
jQuery 11
BindEventstag_952_subfield_p_878344
* Long standing bug:
If there are several item forms on the same page, the branchcode is not
correctly retrieved. For instance on the "Serial edition" page there are
2 item forms, the homebranch that is used by the barcode plugin will be
the one from the last form.
Test plan:
* regression
Set autoBarcode=<branchcode>yymm0001
Catalogue a new item, click into the barcode input
Notice that without this patch you get a JS error in the console
* long standing bug
Create a new subscription, select "Create an item record when receiving this serial".
Receive a serial
Open the 2 item forms ("Click to add item")
Select 2 different home library and click the barcode inputs.
The prefix (branchcode) should be correct with this patch applied.
QA Note: it would be way easier if all add item forms were using the new
methods, it could be:
let loc = document.getElementsByName('items.homebranch')[0].value;
Yes, that's all!
Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
|
||
|---|---|---|
| .. | ||
| Acquisition | ||
| api/v1 | ||
| Auth | ||
| AuthoritiesMarc | ||
| Authority | ||
| Biblio | ||
| Circulation | ||
| CourseReserves | ||
| Creators | ||
| cronjobs | ||
| data | ||
| Exporter | ||
| Holds | ||
| Illrequest | ||
| Items | ||
| Koha | ||
| Labels | ||
| LDAP | ||
| Letters | ||
| Members | ||
| misc/translator | ||
| OAI | ||
| Patron | ||
| Record | ||
| Reports | ||
| Reserves | ||
| Search | ||
| selenium | ||
| Serials | ||
| SIP | ||
| Template/Plugin | ||
| Utils | ||
| www | ||
| 00-strict.t | ||
| 01-test_dbic.t | ||
| Accounts.t | ||
| Acquisition.t | ||
| Amazon.t | ||
| ArticleRequests.t | ||
| AudioAlerts.t | ||
| Auth.t | ||
| Auth_with_cas.t | ||
| Auth_with_ldap.t | ||
| AuthorisedValues.t | ||
| AuthoritiesMarc.t | ||
| AuthUtils.t | ||
| BackgroundJob.t | ||
| Barcodes.t | ||
| Barcodes_ValueBuilder.t | ||
| Biblio.t | ||
| Breeding.t | ||
| Budgets.t | ||
| Cache.t | ||
| Calendar.t | ||
| Charset.t | ||
| check_kohastructure.t | ||
| check_sysprefs.t | ||
| Circulation.t | ||
| Clubs.t | ||
| Context.t | ||
| Contract.t | ||
| CourseReserves.t | ||
| db_structure.t | ||
| DecreaseLoanHighHolds.t | ||
| Filter_MARC_ViewPolicy.t | ||
| Fines.t | ||
| FrameworkPlugin.t | ||
| Heading.t | ||
| Heading_MARC21.t | ||
| Hold.t | ||
| Holds.t | ||
| HoldsQueue.t | ||
| Holidays.t | ||
| Illcomments.t | ||
| Illrequestattributes.t | ||
| Illrequests.t | ||
| ILSDI_Services.t | ||
| ImportBatch.t | ||
| ImportExportFramework.t | ||
| Installer.t | ||
| Items.t | ||
| Koha.t | ||
| Koha_Authority.t | ||
| Koha_Database.t | ||
| Koha_Elasticsearch.t | ||
| Koha_ExternalContent_OverDrive.t | ||
| Koha_ExternalContent_RecordedBooks.t | ||
| Koha_Misc_Files.t | ||
| Languages.t | ||
| Letters.t | ||
| LibraryGroups.t | ||
| Linker_Default.t | ||
| Linker_FirstMatch.t | ||
| Log.t | ||
| MarcModificationTemplates.t | ||
| Members.t | ||
| Message.t | ||
| MungeMarcPrice.t | ||
| Overdues.t | ||
| Passwordrecovery.t | ||
| Patroncards.t | ||
| PatronLists.t | ||
| Patrons.t | ||
| Record.t | ||
| RecordProcessor_EmbedSeeFromHeadings.t | ||
| Reports.t | ||
| Reserves.t | ||
| rollingloans.t | ||
| RotatingCollections.t | ||
| Search.t | ||
| Serials.t | ||
| Serials_2.t | ||
| Service.t | ||
| ShelfBrowser.t | ||
| Sitemapper.t | ||
| Stats.t | ||
| StockRotationItems.t | ||
| StockRotationRotas.t | ||
| StockRotationStages.t | ||
| SuggestionEngine_ExplodedTerms.t | ||
| Suggestions.t | ||
| sysprefs.t | ||
| TablesSettings.t | ||
| Tags.t | ||
| Templates.t | ||
| TestBuilder.t | ||
| Upload.t | ||
| UsageStats.t | ||
| Virtualshelves.t | ||
| XISBN.t | ||
| XSLT.t | ||
| yaml.t | ||
| zebra_config.pl | ||