Tomas Cohen Arazi
05705ab2ad
This patch makes Koha::Logger initialization happen in the ->new method for the Koha::ExternalContent-derived classes. In the case of RecordedBooks, it doesn't look like it is used at all. In the case of OverDrive, it will now use the Koha::ExternalContent exported logger accessor. I added tests for this addition to Koha::ExternalContent to the OverDrive tests. I also removed references to Test::DBIx::Class as it is not used at all. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha_ExternalContent_OverDrive.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
52 lines
1.7 KiB
Perl
Executable file
52 lines
1.7 KiB
Perl
Executable file
#!/usr/bin/env perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More;
|
|
use Test::MockModule;
|
|
use t::lib::Mocks;
|
|
|
|
use Module::Load::Conditional qw( can_load check_install );
|
|
|
|
BEGIN {
|
|
if ( check_install( module => 'WebService::ILS::OverDrive::Patron' ) ) {
|
|
plan tests => 6;
|
|
} else {
|
|
plan skip_all => "Need WebService::ILS::OverDrive::Patron"
|
|
}
|
|
}
|
|
|
|
use_ok('Koha::ExternalContent::OverDrive');
|
|
|
|
t::lib::Mocks::mock_preference('SessionStorage','tmp');
|
|
|
|
t::lib::Mocks::mock_preference('OverDriveClientKey', 'DUMMY');
|
|
t::lib::Mocks::mock_preference('OverDriveClientSecret', 'DUMMY');
|
|
t::lib::Mocks::mock_preference('OverDriveLibraryID', 'DUMMY');
|
|
|
|
my $client = Koha::ExternalContent::OverDrive->new({koha_session_id => 'DUMMY'});
|
|
|
|
my $user_agent_string = $client->user_agent->agent();
|
|
ok ($user_agent_string =~ m/^Koha/, 'User Agent string is set')
|
|
or diag("User Agent string: $user_agent_string");
|
|
|
|
my $base_url = "http://mykoha.org";
|
|
ok ($client->auth_url($base_url), 'auth_url()');
|
|
local $@;
|
|
eval { $client->auth_by_code("blah", $base_url) };
|
|
ok($@, "auth_by_code() dies with bogus credentials");
|
|
SKIP: {
|
|
skip "No exception", 1 unless $@;
|
|
my $error_message = $client->error_message($@);
|
|
ok($error_message =~ m/Authorization Failed/i, "error_message()")
|
|
or diag("Original:\n$@\nTurned into:\n$error_message");
|
|
}
|
|
|
|
subtest 'logger() tests' => sub {
|
|
|
|
plan tests => 2;
|
|
|
|
my $external_content = Koha::ExternalContent::OverDrive->new({koha_session_id => 'DUMMY'});
|
|
ok( $external_content->can('logger'), 'A Koha::ExternalContent object has a logger accessor' );
|
|
is( ref($external_content->logger), 'Koha::Logger', 'The accessor return the right object type' );
|
|
};
|