Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
163 lines
4.8 KiB
Perl
Executable file
163 lines
4.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 14;
|
|
use MARC::Record;
|
|
|
|
use t::lib::Mocks;
|
|
use C4::Context;
|
|
use Koha::Database;
|
|
|
|
BEGIN {
|
|
use_ok('C4::Record', qw( marc2marc marc2marcxml marcxml2marc marc2dcxml marc2modsxml marc2bibtex ));
|
|
}
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
t::lib::Mocks::mock_preference( "BibtexExportAdditionalFields", q{} );
|
|
|
|
my @marcarray=marc2marc;
|
|
is ($marcarray[0],"Feature not yet implemented\n","error works");
|
|
|
|
my $marc=MARC::Record->new;
|
|
my $marcxml=marc2marcxml($marc);
|
|
my $testxml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<record
|
|
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
|
|
xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"
|
|
xmlns="http://www.loc.gov/MARC21/slim">
|
|
|
|
<leader> a </leader>
|
|
</record>
|
|
);
|
|
is ($marcxml, $testxml, "testing marc2xml");
|
|
|
|
my $rawmarc=$marc->as_usmarc;
|
|
$marcxml=marc2marcxml($rawmarc);
|
|
$testxml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<record
|
|
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
|
|
xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"
|
|
xmlns="http://www.loc.gov/MARC21/slim">
|
|
|
|
<leader>00026 a2200025 4500</leader>
|
|
</record>
|
|
);
|
|
is ($marcxml, $testxml, "testing marc2xml");
|
|
|
|
my $marcconvert=marcxml2marc($marcxml);
|
|
is ($marcconvert->as_xml,$marc->as_xml, "testing xml2marc");
|
|
|
|
my $marcsrwdc=marc2dcxml( $marc, undef, undef, "srwdc" );
|
|
my $test2xml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<srw_dc:dc xmlns:srw_dc="info:srw/schema/1/dc-schema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="info:srw/schema/1/dc-schema http://www.loc.gov/z3950/agency/zing/srw/dc-schema.xsd">
|
|
<type xmlns="http://purl.org/dc/elements/1.1/"/>
|
|
</srw_dc:dc>
|
|
);
|
|
|
|
is ($marcsrwdc, $test2xml, "testing SRWDC Metadata");
|
|
|
|
my $marcoaidc=marc2dcxml( $marc, undef, undef, "oaidc" );
|
|
my $test3xml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<oai_dc:dc xmlns:oai_dc="http://www.openarchives.org/OAI/2.0/oai_dc/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd">
|
|
<dc:type/>
|
|
<dc:language/>
|
|
</oai_dc:dc>
|
|
);
|
|
|
|
is ($marcoaidc, $test3xml, "testing OAIDC Metadata");
|
|
|
|
my $marcrdfdc=marc2dcxml( $marc, undef, undef, "rdfdc" );
|
|
my $test4Axml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<rdf:Description xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:dc="http://purl.org/dc/elements/1.1/">
|
|
<dc:type/>
|
|
<dc:language/>
|
|
</rdf:Description>
|
|
);
|
|
|
|
is ($marcrdfdc, $test4Axml, "testing RDFDC Metadata");
|
|
|
|
my $marcdc=marc2dcxml( $marc, undef, undef, "dc" );
|
|
my $test4Bxml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<rdf:Description xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:dc="http://purl.org/dc/elements/1.1/">
|
|
<dc:type/>
|
|
<dc:language/>
|
|
</rdf:Description>
|
|
);
|
|
|
|
is ($marcrdfdc, $test4Bxml, "testing DC Metadata");
|
|
|
|
my $mods=marc2modsxml($marc);
|
|
my $test5xml=qq(<?xml version="1.0" encoding="UTF-8"?>
|
|
<mods xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/mods/v3" version="3.1" xsi:schemaLocation="http://www.loc.gov/mods/v3 http://www.loc.gov/standards/mods/v3/mods-3-1.xsd">
|
|
<typeOfResource/>
|
|
<originInfo>
|
|
<issuance/>
|
|
</originInfo>
|
|
<recordInfo/>
|
|
</mods>
|
|
);
|
|
|
|
is ($mods, $test5xml, "testing marc2modsxml");
|
|
|
|
$marc->append_fields(MARC::Field->new(
|
|
'100', ' ', ' ', a => 'Rowling, J.K.'
|
|
));
|
|
my $field = MARC::Field->new('245','','','a' => "Harry potter");
|
|
$marc->append_fields($field);
|
|
$marc->append_fields(MARC::Field->new(
|
|
'260', ' ', ' ', b => 'Scholastic', c => '2001'
|
|
));
|
|
|
|
#my $endnote=marc2endnote($marc->as_usmarc);
|
|
#print $endnote;
|
|
|
|
my $bibtex=marc2bibtex($marc, 'testID');
|
|
my $test6xml=qq(\@book{testID,
|
|
author = {Rowling, J.K.},
|
|
title = {Harry potter},
|
|
publisher = {Scholastic},
|
|
year = {2001}
|
|
}
|
|
);
|
|
|
|
is ($bibtex, $test6xml, "testing bibtex");
|
|
|
|
t::lib::Mocks::mock_preference( "BibtexExportAdditionalFields", "'\@': 260\$b\ntest: 260\$b" );
|
|
$bibtex = marc2bibtex( $marc, 'testID' );
|
|
my $test7xml = qq(\@Scholastic{testID,
|
|
\tauthor = {Rowling, J.K.},
|
|
\ttitle = {Harry potter},
|
|
\tpublisher = {Scholastic},
|
|
\tyear = {2001},
|
|
\ttest = {Scholastic}
|
|
}
|
|
);
|
|
is( $bibtex, $test7xml, "testing bibtex" );
|
|
t::lib::Mocks::mock_preference( "BibtexExportAdditionalFields", q{} );
|
|
|
|
$marc->append_fields(MARC::Field->new(
|
|
'264', '3', '1', b => 'Reprints', c => '2011'
|
|
));
|
|
$bibtex = marc2bibtex($marc, 'testID');
|
|
my $rdabibtex = qq(\@book{testID,
|
|
author = {Rowling, J.K.},
|
|
title = {Harry potter},
|
|
publisher = {Reprints},
|
|
year = {2011}
|
|
}
|
|
);
|
|
is ($bibtex, $rdabibtex, "testing bibtex with RDA 264 field");
|
|
|
|
my @entity=C4::Record::_entity_encode("Björn");
|
|
is ($entity[0], "Björn", "Html umlauts");
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|