Koha/cataloguing/value_builder/callnumber.pl
Marcel de Rooy 0d177c9546 Bug 10480: Remove useless routines and irrelevant pod lines
This patch makes the following cleanup actions for all plugins:

1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.

Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-04-16 14:48:40 -03:00

106 lines
3.4 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2010 BibLibre SARL
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use strict;
use warnings;
use C4::Auth;
use CGI qw ( -utf8 );
use C4::Context;
=head1 DESCRIPTION
Is used for callnumber computation.
If the user send an empty string, we return a simple incremented callnumber.
If a prefix is submited, we look for the highest callnumber with this prefix, and return it incremented.
In this case, a callnumber has this form : "PREFIX 0009678570".
- PREFIX is an upercase word
- a space separator
- 10 digits, with leading 0s if needed
=cut
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $res="
<script type='text/javascript'>
function Blur$field_number() {
var code = document.getElementById('$field_number');
var url = '../cataloguing/plugin_launcher.pl?plugin_name=callnumber.pl&code=' + code.value;
var req = \$.get(url);
req.done(function(resp){
code.value = resp;
return 1;
});
return 1;
}
</script>
";
return ($field_number,$res);
}
sub plugin {
my ($input) = @_;
my $code = $input->param('code');
my ($template, $loggedinuser, $cookie) = get_template_and_user({
template_name => "cataloguing/value_builder/ajax.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => {editcatalogue => '*'},
debug => 1,
});
my $dbh = C4::Context->dbh;
# If the textbox is empty, we return a simple incremented callnumber
if ( $code eq "" ) {
my $sth = $dbh->prepare("SELECT MAX(CAST(itemcallnumber AS SIGNED)) FROM items");
$sth->execute;
if ( my $max = $sth->fetchrow ) {
$template->param(
return => $max+1,
);
}
# If a prefix is submited, we look for the highest itemcallnumber with this prefix, and return it incremented
} elsif ( $code =~ m/^[A-Z.\-']+$/ ) {
my $sth = $dbh->prepare("SELECT MAX(CAST(SUBSTRING_INDEX(itemcallnumber,' ',-1) AS SIGNED)) FROM items WHERE itemcallnumber LIKE ?");
$sth->execute($code.' %');
if ( my $max = $sth->fetchrow ) {
$template->param(
return => $code.' '.($max+1)
);
}
else {
$template->param(
return => $code.' 1'
);
}
# The user entered a custom value, we don't touch it, this could be handled in js
} else {
$template->param(
return => $code
);
}
output_html_with_http_headers $input, $cookie, $template->output;
}