Koha/cataloguing/value_builder/marc21_field_006.pl
Marcel de Rooy 0d177c9546 Bug 10480: Remove useless routines and irrelevant pod lines
This patch makes the following cleanup actions for all plugins:

1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.

Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-04-16 14:48:40 -03:00

95 lines
3 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use strict;
#use warnings; FIXME - Bug 2505
use C4::Auth;
use CGI qw ( -utf8 );
use C4::Context;
use C4::Search;
use C4::Output;
use XML::LibXML;
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ($dbh, $record, $tagslib, $field_number, $tabloop) = @_;
my $function_name = $field_number;
my $res = "
<script type=\"text/javascript\">
//<![CDATA[
function Clic$function_name(i) {
defaultvalue=document.getElementById(\"$field_number\").value;
newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=marc21_field_006.pl&index=$field_number&result=\"+defaultvalue,\"tag_editor\",'width=1000,height=600,toolbar=false,scrollbars=yes');
}
//]]>
</script>
";
return ($function_name, $res);
}
sub plugin {
my ($input) = @_;
my $index = $input->param('index');
my $result = $input->param('result');
my $dbh = C4::Context->dbh;
my ($template, $loggedinuser, $cookie) = get_template_and_user(
{ template_name => "cataloguing/value_builder/marc21_field_006.tt",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => { editcatalogue => '*' },
debug => 1,
}
);
$result = "a|||||r|||| 00| 0 " unless $result;
my $errorXml = '';
# Check if the xml, xsd exists and is validated
my $dir = C4::Context->config('intrahtdocs') . '/prog/' . $template->{lang} . '/data/';
if (-r $dir . 'marc21_field_006.xml') {
my $doc = XML::LibXML->new->parse_file($dir . 'marc21_field_006.xml');
if (-r $dir . 'marc21_field_CF.xsd') {
my $xmlschema = XML::LibXML::Schema->new(location => $dir . 'marc21_field_CF.xsd');
eval {
$xmlschema->validate( $doc );
};
$errorXml = 'Can\'t validate the xml data from ' . $dir . 'marc21_field_006.xml' if ($@);
}
} else {
$errorXml = 'Can\'t read the xml file ' . $dir . 'marc21_field_006.xml';
}
$template->param(tagfield => '006',
index => $index,
result => $result,
errorXml => $errorXml,
);
output_html_with_http_headers $input, $cookie, $template->output;
}